Coupons, some bugs?

[rued]

Standard Zen Cart 1.3.9h, updated in steps from 1.3.9c
No addons or hacks

First of the discount name is not stored when editing or saving discounts in admin.

Next customers in some weird circumstances gets «You must spend at least xxx to redeem this coupon»

The coupon can be set to t.ex. 1000 in minimum order value, and the customer have products for 1010.

But if adding one product more so the total of products is 1014 the coupon works fine.

Tax rate for products is 25% and can not be a issue itself, when speeking of module config - the diff in value is to small

No specials or gift cards in cart/active.

[rued]

Issue with name seems to have been in some earlier version, there was noting stored in coupons_description table. But when adding this manually for exiting coupons it's seems fine, both for editing and new.

But the value issue is still something weird ... :)

[Ajeh]

Could you re-state this a little slower ... I am not following:

The coupon can be set to t.ex. 1000 in minimum order value, and the customer have products for 1010.

But if adding one product more so the total of products is 1014 the coupon works fine.

Are you saying a:
Minimum 1000

works for $1010 but not $1014 ... or what are you trying to say?

[rued]

No no ...

0-1012 is not working, but 1013+ is (for a coupon with minimum sett to 1000).

Weird isn't it

[DrByte]

Test scenario:
- Brand new clean install of v1.3.9h, with demo products, USD as default currency. Taxes not included in prices.
- Create a new product for $1,000 price
- Create a coupon for $300 off, with minimum $1000 purchase
- Add the $1,000 product to the cart
- Start checkout, choose any shipping method
- Enter the 1000 coupon code
- "Congratulations you have redeemed teh Discount Coupon"

Looks fine to me.

[rued]

Yes it does indeed, but not with several cheap products in my tests.

Do you have some ideas for debuging the values used in cart?

[DrByte]

I repeated the test again with the 12 $25 products in the Big Unlinked category, adding various quantities of each to bring the cart to $1000.
Again, coupon worked just fine.

[rued]

Sure ...

But we don't use flat prices ex tax etc.

We have amounts like 3,20 etc. ex tax (4 inc), and the cart can have 30 products or so before it's reaching the minimum.

Would be nice to debug the values used in order total module, but heck ... that's some kind of work to figure out everything there.

But OK, I'm downloading a complete copy of the site and will do a dif of it to see if something is accidentally changed in some way. Will also test the db on a fresh file base.

Will post back later ...

[rued]

OK, now I see something causing this - but not how to fix it yet ...
The file system was fine btw.

If I add tax in any shipping modules it fails, if I disable tax in the shipping module the coupon code works fine.

How the shipping modules tax can influence on coupon codes I don't see atm ...

And it applies to all shipping modules I've tested, both core and custom.

Settings in ot_coupon:

This module is installed
true

Sort Order
280

Include Shipping
false

Include Tax
false

Re-calculate Tax
Standard

Tax Class
MVA 25%

[rued]

I commented line 458 in ot_coupon.php, and it seems to be working now - in a way I will say is correct ...

    //if ($this->include_shipping != 'true') $order_total_tax -= $order->info['shipping_tax'];

Please let me know the thoughts behind this line, and if you see any potential issues with my "fix".