Page 1 of 2 12 LastLast
Results 1 to 10 of 13
  1. #1
    Join Date
    Jun 2008
    Location
    Bordeaux, France
    Posts
    69
    Plugin Contributions
    6

    Default zc_install doesnt recognize my 1.3.8 database during upgrade (specific languages)

    I have ZC 1.3.8a installed with DB_VERSION=1.3.8 (fresh install for demo purposes)

    If i run "zc_install/index.php?main_page=inspect" like for doing an upgrade, the system recognize a db_version of 1.3.0.2 only.

    Seems that "zc_install\includes\classes\class.installer_version_manager.php" finds "sort_order=115" in "configuration where configuration_key='SHOW_ACCOUNT_LINKS_ON_SITE_MAP'".

    This condition is also true for 1.3.8 and the system cannot differentiate them.

  2. #2
    Join Date
    Jan 2004
    Posts
    66,364
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: zc_install doesnt recognize my 1.3.8 database

    I can't replicate that problem on a fresh 1.3.8a install without addons.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  3. #3
    Join Date
    Jun 2008
    Location
    Bordeaux, France
    Posts
    69
    Plugin Contributions
    6

    Default Re: zc_install doesnt recognize my 1.3.8 database

    Yes, you are right what you said, but I see the pb.
    Ive checked again with my ZC (Full French 1.3.8a) and the original 1.3.8a (English version)

    French 1.3.8a gives a DB_VERSION of 1.3.0.2 (false), English 1.3.8a gives 1.3.8 (correct)

    Problem comes from the translation of 'zc_install\sql\mysql_zencart.sql' in French, to have an admin comprehensible for all our merchants. In 'zc_install\includes\classes\class.installer_version_manager.php', the functions 'check_version_XXX()'
    were all refering to NUMBERS up to the 1302(). Then the comparison is done with 'configuration_title' (in English words)
    which cannot be found in our version (French words). So it returns always false for 'check_version_XXX()' > 1302.

  4. #4
    Join Date
    Jan 2004
    Posts
    66,364
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: zc_install doesnt recognize my 1.3.8 database

    "configuration_title" is a field inside the database, and should not be translated.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  5. #5
    Join Date
    Jun 2008
    Location
    Bordeaux, France
    Posts
    69
    Plugin Contributions
    6

    Default Re: zc_install doesnt recognize my 1.3.8 database

    So, what the langage packs are for if the admin cannot be translated ? Its the comparison which should not have been done against something variable and langage dependant.

  6. #6
    Join Date
    Jan 2004
    Posts
    66,364
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: zc_install doesnt recognize my 1.3.8 database

    Feel free to translate language files located under the /includes/languages folder.
    But don't go translating the core SQL code or you're naturally going to have problems.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  7. #7
    Join Date
    Jun 2008
    Location
    Bordeaux, France
    Posts
    69
    Plugin Contributions
    6

    Default Re: zc_install doesnt recognize my 1.3.8 database

    The Polish Language Pack (v 1.3.7 - ZenCart.pl Group) and Italian Group (http://www.zencart-italia.it/) at least are in the same case as us as they have translated 'zc_install\sql\mysql_zencart.sql'.

    Some of our merchants doesnt understand English very well and have difficulties on very small problems. Thats why a full translation had been done (long work).

  8. #8
    Join Date
    Jun 2005
    Location
    Cumbria, UK
    Posts
    10,262
    Plugin Contributions
    3

    Default Re: zc_install doesnt recognize my 1.3.8 database

    The issue here is compatibility between LABELS in the code and TABLES in the database.

    You can call a database table anything you like (conforming of course to MySQL protocols).

    Then you just need to make sure that references in the php (or other) code accurately use that table name.

    But you should have no need to alter table names or code. You just need to alter the define constants for language descriptives.
    19 years a Zencart User

  9. #9
    Join Date
    Jun 2008
    Location
    Bordeaux, France
    Posts
    69
    Plugin Contributions
    6

    Default Re: zc_install doesnt recognize my 1.3.8 database

    I just say bad tests are done relying on langage dependant text inside TABLE_CONFIGURE to determine DB_VERSION. Nobody had been advised NOT to change English text in TABLE_CONFIGURE for localisation, and having so many options in English make merchants lost.

    I think it was more simple to have the functions check_version_XXX() of 'zc_install\includes\classes\class.installer_version_manager.php' look directly in TABLE_PRODUCT_VERSION_HISTORY for the db-updates that have occured.

    Making 1 or 2 checks in TABLE_CONFIGURATION does not mean
    the last update has completely performed. Any SQL upgrade script can fail between its begin (update/insert into TABLE_CONFIGURATION) and
    its end (upadte/insert into TABLE_PRODUCT_VERSION_HISTORY), so that you could have TABLE_CONFIGURATION up-to-date but not the others tables comming after.

    Suppose a SQL failure, as it is, zc_install would find with check_version_XXX() that the last update has occured (but not completely in reality).
    Last edited by gob33; 20 Nov 2009 at 04:07 PM.

  10. #10
    Join Date
    Jan 2004
    Posts
    66,364
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: zc_install doesnt recognize my 1.3.8 database

    gob33, while I understand what you're saying, all your arguments are moot if whoever has translated the SQL code actually changed the database FIELD names.
    If you want to translate descriptive text, feel free. But leave the underlying architecture alone.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

 

 
Page 1 of 2 12 LastLast

Similar Threads

  1. Replies: 11
    Last Post: 19 Jan 2016, 03:38 PM
  2. Replies: 4
    Last Post: 5 Dec 2012, 01:45 AM
  3. v151 Upgrade to 1.5 from a 1.3 version error during zc_install
    By marie893 in forum Upgrading to 1.5.x
    Replies: 5
    Last Post: 6 Oct 2012, 04:52 AM
  4. Oops screen disallowing the zc_install to upgrade database.
    By notageek in forum Upgrading from 1.3.x to 1.3.9
    Replies: 8
    Last Post: 19 Nov 2010, 04:44 AM
  5. Doesnt recognize database or missing something?
    By stefanl in forum Upgrading from 1.3.x to 1.3.9
    Replies: 2
    Last Post: 15 Jun 2010, 10:30 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR