Nixaks Sagepay Form Module

[sailsport]

Hi,

I've had the same problem as above and I've added a couple of lines that basically check to see if the Delivery information is missing ( to be specific I check the street address and country ) and if it is I copy the billing details into the delivery details array.

I've tested it and it works fine for me.

See modified file attached with the updated code commented.
I hope someone else will find it usefull

Regards,

Mark
www.avova.ie

Mark, I too have the same problem with Gft Vouchers, as ZenCart treats them as virtual products and fails to fill in shipping address, which makes SagePay reject it.

I tried your code, but it doesn't work for me. In fact it has exactly the same number of lines (475) of code as the original 1.3.

Maybe I am tired and doing something supid, or maybe you posted the wrong file. Can you check, and see if I'm going mad?

I'm guessing I could code the appropriate IF statement with a bit of trial and error, but I'm a bit new to PHP, so if you have code that works then that would be good.

Alan

[Nixak]

Hi all,
I belive I have a fix for all of you who have problems with virtual products where the delivery fields are not being sent to SagePay

However you should note this fix is untested, so if you apply this fix the first thing you MUST do is backup your database and server files (sorry about the next bit, but if I don't say it then someone will moan at me if things go wrong) as I will not be held responsable if anything bad happens and you didn't backup everything first.

Ok so here goes

1) BACKUP EVERYTHING
2) Open includes/modules/payment/sagepay_form.php (in a good text editor such as notepad++)
3) find this block of code

$plain .= "DeliverySurname=" . $order->delivery['lastname'] . "&";
		$plain .= "DeliveryFirstnames=" . $order->delivery['firstname'] . "&";
		$plain .= "DeliveryAddress1=" . $order->delivery['street_address'] . "&";
      if (ACCOUNT_SUBURB == 'true') {
        $plain .= "DeliveryAddress2=" . $order->delivery['suburb'] . "&";
    }
		$plain .= "DeliveryCity=" . $order->delivery['city'] . "&";
		$plain .= "DeliveryPostCode=" . $order->delivery['postcode'] . "&";
		$plain .= "DeliveryCountry=" . $order->delivery['country']['iso_code_2'] . "&";
     if (($order->delivery['country']['iso_code_2']) == 'US') {
		$orderdelivstate = $order->delivery['state'];
		$plain .= "DeliveryState=" . $us_state_codes[$orderdelivstate] . "&";
	 }else{
		$plain .= "DeliveryState=" . "&";
    }
		$plain .= "DeliveryPhone=" . $order->customer['telephone'] . "";

4) replace all of the block of code with the code below

// DeliveryXXX fields	
		if ($order->delivery['lastname']===NULL) {
		$plain .= "DeliverySurname=" . $order->billing['lastname'] . "&";
		} else {
		$plain .= "DeliverySurname=" . $order->delivery['lastname'] . "&";
	}	
		if ($order->delivery['firstname']===NULL) {
		$plain .= "DeliveryFirstnames=" . $order->billing['firstname'] . "&";
		} else {
		$plain .= "DeliveryFirstnames=" . $order->delivery['firstname'] . "&";
	}	
		if ($order->delivery['street_address']===NULL) {
		$plain .= "DeliveryAddress1=" . $order->billing['street_address'] . "&";
		} else {
		$plain .= "DeliveryAddress1=" . $order->delivery['street_address'] . "&";
	}	
		if (($order->delivery['suburb']===NULL) && (ACCOUNT_SUBURB == 'true')) {
        $plain .= "DeliveryAddress2=" . $order->billing['suburb'] . "&";
		} elseif ((ISSET($order->delivery['suburb'])) && (ACCOUNT_SUBURB == 'true')) {
		$plain .= "DeliveryAddress2=" . $order->delivery['suburb'] . "&";
		} else {
		$plain .= "DeliveryAddress2=" . "" . "&";
    }
		if ($order->delivery['city']===NULL) {
		$plain .= "DeliveryCity=" . $order->billing['city'] . "&";
		} else {
		$plain .= "DeliveryCity=" . $order->delivery['city'] . "&";
	}
		if ($order->delivery['postcode']===NULL) {
		$plain .= "DeliveryPostCode=" . $order->billing['postcode'] . "&";
		} else {
		$plain .= "DeliveryPostCode=" . $order->delivery['postcode'] . "&";
	}
		if ($order->delivery['country']['iso_code_2']===NULL) {
		$plain .= "DeliveryCountry=" . $order->billing['country']['iso_code_2'] . "&";
		} else {
		$plain .= "DeliveryCountry=" . $order->delivery['country']['iso_code_2'] . "&";
	}
		
	if (($order->delivery['country']['iso_code_2']) == 'US') {
		$orderdelivstate = $order->delivery['state'];
		$plain .= "DeliveryState=" . $us_state_codes[$orderdelivstate] . "&";
	 }else{
		$plain .= "DeliveryState=" . "&";
    }
      
		$plain .= "DeliveryPhone=" . $order->customer['telephone'] . "";

5) Save the file and upload it

You should now hopefully be all fixed

If anyone has any problems just post them in here as I have notifications for this thread turned on, so I will know right away

Regards
Nixak

[sailsport]

Many thanks.

I have tested this on my test system with virtual, non virtual, and combined virtual and non virtual, same shipping and different shipping addresses, and it seems good.

As Nixaks says, back it all up first. The first attempt I failed to cut and paste the complete code ......

Alan

[Nixak]

Many thanks.

I have tested this on my test system with virtual, non virtual, and combined virtual and non virtual, same shipping and different shipping addresses, and it seems good.

Thank you

As Nixaks says, back it all up first. The first attempt I failed to cut and paste the complete code ......

Alan

Lol the perils of coding ...... hope you had it all backed up

[orexis]

hi, sorry about this but I'm having some trouble.

no matter what i try i cant get away from the 5030 error. the password I'm entering is correct as I can access the account on the sign in section of sagepay so I'm guessing its invalid encoding however this is the first time I've had to work with SSL and curl and so I've no idea what to do. Its also the first time I've worked with both Zen cart and sagepay.

If any one can help I'd be really thankful.

(version number: 1.3.9d)

[sailsport]

I possible clue, you say " the password I'm entering is correct as I can access the account on the sign in section of sagepay "

The password for the module is the encryption password not your normal user log-in to sagepay password.

I can't recall right now where I got the encryption password from, but it is definitely different to my log-in password. Hope that helps

[Nixak]

Hi all, sorry about the late reply but i've been away on holiday.

Orexis your problem is as described by Sailsport ... when you received your paperwork for SagePay you will have received 2 passwords - 1 of these is your login password and the other is labelled as an encryption password, you need to use the encryption password, which I belive is case sensitive.

Hope this helps
Nixak

[Checooper]

Hi,

I am having the following issue -

Customer picks sagepay has payment then goes to sagepay fills out cards details etc.. and confirms, but the payment fails saying the below in an email to admin -

** FAILURE notification **

The following transaction FAILED... An error occurred at Sage Pay. Please contact us with the details shown below.
Transaction type: PAYMENT
VendorTxCode: xxxxxxxxxxxx
VPSTxId: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Amount: 216.19 GBP
Gift Aid: No - Not a Gift Aid transaction.
AVS/CV2 Response: DATA NOT CHECKED - CV2:NOTPROVIDED, Address:NOTPROVIDED, Post Code:NOTPROVIDED
3D Secure Result: NOTCHECKED
Customer Name: xxxxxx xxxx
Customer e-mail: [email protected]
Contact Number:
Contact Fax:
IP Address Location: Country: United Kingdom
Card Used: Card used: Visa Debit / Delta - XXXX XXXX XXXXxxxx - Attempt:1
Card Issuer: xxxxxxx Bank Plc, United Kingdom
Bullet Point Order total: 216.19 GBP
Card used: Lloyds Tsb Bank Plc, United Kingdom - Visa Debit / Delta - XXXX XXXX XXXXxxx - Attempt:1
Bullet Point Your customer bought: Goods from York Flooring Supplies
Description Quantity Item Value Item Tax Item Total Line Total
SISAL TETOUAN 1 179 31.33 210.33 210.33
Shipping --- --- --- --- 4.99


Zen Cart Version 1.3.9f
Fast and easy checkout
IH 2 rev8
zen lightbox


site - www.yorkflooringsupplies.co.uk

I tested in demo and all worked fine, Can anyone please help.

Thanks Che

[Checooper]

Hi,

I am having the following issue -

Customer picks sagepay has payment then goes to sagepay fills out cards details etc.. and confirms, but the payment fails saying the below in an email to admin -

** FAILURE notification **

The following transaction FAILED... An error occurred at Sage Pay. Please contact us with the details shown below.
Transaction type: PAYMENT
VendorTxCode: xxxxxxxxxxxx
VPSTxId: xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
Amount: 216.19 GBP
Gift Aid: No - Not a Gift Aid transaction.
AVS/CV2 Response: DATA NOT CHECKED - CV2:NOTPROVIDED, Address:NOTPROVIDED, Post Code:NOTPROVIDED
3D Secure Result: NOTCHECKED
Customer Name: xxxxxx xxxx
Customer e-mail: [email protected]
Contact Number:
Contact Fax:
IP Address Location: Country: United Kingdom
Card Used: Card used: Visa Debit / Delta - XXXX XXXX XXXXxxxx - Attempt:1
Card Issuer: xxxxxxx Bank Plc, United Kingdom
Bullet Point Order total: 216.19 GBP
Card used: Lloyds Tsb Bank Plc, United Kingdom - Visa Debit / Delta - XXXX XXXX XXXXxxx - Attempt:1
Bullet Point Your customer bought: Goods from York Flooring Supplies
Description Quantity Item Value Item Tax Item Total Line Total
SISAL TETOUAN 1 179 31.33 210.33 210.33
Shipping --- --- --- --- 4.99


Zen Cart Version 1.3.9f
Fast and easy checkout
IH 2 rev8
zen lightbox


site - www.yorkflooringsupplies.co.uk

I tested in demo and all worked fine, Can anyone please help.

Thanks Che

*** Solved this now ***

[Nixak]

*** Solved this now ***

Hi I've just got in from work, I'm glad to see you solved the problem if it's ok to do so can you let us know what was wrong?

Cheers
Nixak