[Done v1.3.9] Bug in ot_shipping prevents tax_basis flag from working correctly

[angeljusto]

Sorry to bother you because I am most probably wrong and this is not a bug, I thought I better post it just in case. I haven't found any post on this subject.

In Zencart 1.3.8, ot_shipping.php, at line 61, we have:

if (!defined($GLOBALS[$module]->tax_basis)) { 

The thing is, left like that, no matter what I choose in the admin, I always get the default "Store" basis for shipping tax calculation, because the property always evaluates as not defined.

I changed this for:

if (!isset($GLOBALS[$module]->tax_basis)) { 

And it seems to work as it should. Am I doing somehting wrong?

[DrByte]

You're correct. The change you suggested is appropriate.

[jw00dy]

What is the full path to that file?

[DrByte]

/includes/modules/order_totals/ot_shipping.php

[jw00dy]

Oh you beat me to it :)

Thank you.

[Sawhorse]

I see that line of code at line 44 not 61. I have not modified this file. I am using ZC v1.3.8a. Am I in the wrong place or missing something?

Sawhorse

[DrByte]

Line 44 is correct.

[Sawhorse]

Thank you!