Manul PHP 5.3 Patch for 1.3.8a?

[limelites]

If you mean this one:

http://www.zen-cart.com/forum/showthread.php?t=140960

Then that's the thread I'm referring to from the start. It has a bunch of files for 1.3.8a patch, but it offers manual patches for 1.3.7

I was wondering if there was a manual patch list for 1.3.8a?

[DrByte]

If you mean this one:

http://www.zen-cart.com/forum/showthread.php?t=140960

Then that's the thread I'm referring to from the start. It has a bunch of files for 1.3.8a patch, but it offers manual patches for 1.3.7

I was wondering if there was a manual patch list for 1.3.8a?

No. You can easily create a list of actual changes using WinMerge yourself.

[limelites]

It's just that having my existing files already heavily modified, it's pretty hard to tell if (a) the changes highlighted by WinMerge are due to the mods or (b) if the changes highlighted are due to the 5.3 compatibility patches.

It's also pretty difficult to tell which mod has brought about the changes to the individual files and thereby determine if it's a PHP 5.3 compatible mod.

Example, in admin/orders.php I can see that date_diff needs to change to zen_date_diff.............. However, I have a mod with commands like, date_add(now(), INTERVAL " . TIME_ZONE_OFFSET . " HOUR), ................ and I'm wondering if that would need changed to, zen_date_add(now(), INTERVAL " . TIME_ZONE_OFFSET . " HOUR),

I think I'll get a quote from someone with more experience

[barco57]

You would have to winmerge the 5.3 patch files against a stock set of 1.3.8a files to build yourself a list of the changes, and then you could take that list to patch your customized files. Its gonna be a multistep project.

[limelites]

OK, last question on this hopefully.

I’ve gone through all the patch files and WinMerged them with my existing files. It wasn't as difficult as I'd anticipated and I’m pretty confident that I’ve did it correctly. Thanks for the pointer on the two stage merging process.

My question now is, ‘is it ok to upload the new patched files to the server and replace the current files, even though the server isn’t running PHP 5.3.x yet?’

[g1smd]

Yes. PHP 5.3 removes some older functions that ZenCart had still been using. Replacement, improved, functions had already been added to PHP very many versions ago. The updates to Zencart change these functions to use ones still in PHP 5.3 but which are also in previous versions of PHP.

[limelites]

OK, I've WinMerged my 1.4.8a files with the patch files and then Winmerged with my mod files. I've uploaded them all to the server on a test site, but before I upload these same files to my main live site, is there anything in particular you think I should test for?

If anything's gone wrong, what's it likely to be? Other than the mods, what functionality should I be testing to make sure I've patched these files correctly?

[g1smd]

Unfortunately the best advice is "test everything". There's no knowing what has been missed or might contain an error.

[limelites]

Not the answer I was looking for, but cset la vie.

I've noticed something odd straight away. PayPal is no longer calculating the shipping costs!

[kuroi]

I didn't think that Paypal ever did calculate the shipping costs. That's the responsibility of the relevant shipping mod, not your payment mod.