[Done v1.3.9b] Tax name wont show up on order if tax is 0.00

[Argyle]

Upgraded to 1.3.9a.

When a costumer places his/her order the tax name wont show up...Will just say how much tax it is but nothing more...

I got the tax class GST...Before it always said.

Sub-Total: $36.00
Zone Rates (Shipping to AU): $25.00
GST: $0.00


Now it looks like this after the update...Should say GST

Sub-Total: $36.00
Zone Rates (Shipping to AU): $25.00
: $0.00


Any ideas? everything else works fine... I don't charge any sales tax but i have to display it...

Cheers
Robin

[RodG]

Any ideas? everything else works fine... I don't charge any sales tax but i have to display it...

Unless someone beats me too it I'll try to take a closer look at this later today.

Meanwhile, assuming you are referring to Australian GST you DO NOT have to display the tax amounts (zero or otherwise) - The exception being is if you are registered for GST and provide a TAX INVOICE that contains one or more GST exempt items.

If you provide a TAX INVOICE with no tax amounts specified then all items on the invoice are assumed to be taxed at 10%

If you are not registered for GST then you *cannot* provide a TAX INVOICE, nor can you charge GST - You simply provide your customer with a SALES INVOICE which implies no GST was charged.

My advice to you is if you aren't registered for GST (and there is no need, and no good reason to do so unless your annual turnover is >$75k) then simply ignore/disable anything to do with tax, and ensure you provide your customers with a sales invoice rather than a tax invoice. (The only diiference between a sales invoice and a tax invoice is:
1. A tax invoice must clearly identify itself as a "tax invoice"
2. A tax invoice must include your ABN

Anything else is simply a sales invoice.

Cheers
Rod

[Argyle]

I'm from New Zealand....

I'm not registered for GST since my annual turnover is not above 60 000dollars...

But i'm pretty sure I have to display and tell if i don't charge GST here, everybody else does that...

Cheers
Robin

[RodG]

I'm from New Zealand....

Don't worry, I won't hold that against you

I'm not registered for GST since my annual turnover is not above 60 000dollars...

But i'm pretty sure I have to display and tell if i don't charge GST here, everybody else does that...

Cheers
Robin

It doesn't surprise me that NZ rules and AU are different. I had assumed you were Australian - We don't seem to see to many kiwis around here.

Sorry, I haven't had a chance to check out your display problem yet (I got side tracked on a more pressing matter).

Cheers
Rod

[Argyle]

Well the real truth is that I'm from Sweden, but immigrated to NZ a couple of years ago...

Might have been a genuine fault also, i made a mock order with my swedish credit card... I don't know if that made it play up a bit, but if you can check if you get the same problem i would appreciate it!

cheers mate

Robin

[Argyle]

the page is www.pbmarkers.co.nz

[RodG]

the page is www.pbmarkers.co.nz

Quick note to confirm that this appears to be a bug. I am getting the same results on my test system.. I need to do a bit more digging to see if I can isolate the cause.

Time for a teabreak, more info later this evening.

Cheers
Rod

[Argyle]

Will keep myself updated to see what you've come up with, can't be a big problem..

[RodG]

Will keep myself updated to see what you've come up with, can't be a big problem..

How come non programmers always think that something like this "can't be a big problem"?

Sure, it isn't going to be a big problem AFTER the fix has been found, but finding it can take hours .... days .....

Needless to say, I've been looking at this for several hours now and still haven't found the cause/cure (However, if you are desperate I can offer you several 'work-arounds' to the problem).

Anyway, I need to call it quits for the night and probably won't have much time to spend on it tomorrow, I hoping that one of the core devs (Dr.Byte, Ajeh, etc) will pick up this thread and possibly offer some insights, so what follows is mostly for their benefit.

-------------------------------------

Zencart V1.3.9a
Problem: Tax rate description(s) not being displayed if tax is zero. (during checkout)

Description: With Sales Tax Display Status set to '0' the entire item line is correctly removed from the output when tax == 0

With Sales Tax Display Status set to '1' the tax item line will correctly display $0.00 (when appropriate) but tax description outputs a NULL if the Show Split Tax Lines == false, and a '0' if Show Split Tax Lines == true

It may be a coincidence, but my fresh installation of 1.3.9 doesn't appear to have this problem, it is only happens with the site(s) I've upgraded, and assumedly the OP also performed an upgrade.

Debugging performed
I've spent most of my time working with the /modules/order_total/ot_tax.php file (seemed like a logical place to start) and have eliminated this file as being the cause of the issue.

The problem appears to originate further back in the depths of the code, specifically, wherever it is that processes the data that populates the $order->info['tax_groups'] array.

It appears that if tax == 0 this array is populated with : Array ( [0] => 0 ) rather than Array ( [tax_description] => 0 )

--------------------------------------------------------------------
As Argyle says, I'm sure its not going to be a big problem, especially now that I've told you what to look for <big grin>


Cheers
Rod

[Argyle]

Sad you could not find it, I will just have to write GST with a pen until someone's found the problem. Must be a tricky one to find I guess, heaps of code to go trough!

I've done a upgrade and not a fresh install.