[Done v1.3.9e/f] 139c DoExpressCheckoutPayment variables missing

[frank18]

Would that mean the $sumoLineTax should be changed as well?

Payphone line 606 and others. Seems like same case mistake everywhere sumofLineItems appears.

Just skimmed through this file myself - I think you are right on the money.

$sumofLineTax only appears once in the whole file, no reference in any other formula.

[dbltoe]

auto-spellchecker got me

Payphone line 606 and others.

shoulda been

shows up on line 1606 and other files.

[Website Rob]

The following modification fixed the issue for me. I warn it may not fix it for others.

replace a line 1262 in file paypalwpp.php
if ($sumofLineItems == 0) {

with
if ($sumofLineItems === 0) {


There must be a difference between being Equal and Identical. Or the change may just shut down the equation altogether and bypass the needed logic. I don't know, not smart enough. I need the line items and am willing to take the chance at the moment.

Dennis

I noticed your use of the triple = instead of the more common double. Although this is true for solving strange problems within JS, is it also true for PHP?

I also noticed 'paypalwpp.php' has neither a closing ?> nor EOF. Any concern with that?

[dbltoe]

Rob,
Need to read up a few posts. I think the === was not required once the sumofLineItems was changed to sumOfLineItems.

[Website Rob]

Understood, but it is the specific use of === within PHP that I am curious about. I have only seen that used within JS.

[DrByte]

Understood, but it is the specific use of === within PHP that I am curious about. I have only seen that used within JS.

It's a perfectly valid operator in PHP when doing type-matching: http://php.net/manual/en/language.op...comparison.php

And ... you're way off topic for this bug-fix thread

[DrByte]

I also noticed 'paypalwpp.php' has neither a closing ?> nor EOF. Any concern with that?

That's been common practice now in Zen Cart for several years, starting in various files touched since v1.3.7.1: http://tutorials.zen-cart.com/index.php?article=313

[DrByte]

NOTE: v1.3.9e has now been released and contains the fixes to the issue described by stagebrace initially. See the News & Announcements section of the forum for details.

[dbltoe]

$sumofLineTax is still at line 1264 of the paypalwpp.php

In the // Sanity Check

// Sanity Check of line-item subtotals
for ($j=0; $j<$k; $j++) {
$itemAMT = $optionsLI["L_AMT$j"];
$itemQTY = $optionsLI["L_QTY$j"];
$itemTAX = (isset($optionsLI["L_TAXAMT$j"]) ? $optionsLI["L_TAXAMT$j"] : 0);
$sumOfLineItems += ($itemQTY * $itemAMT);
$sumOfLineTax += ($itemQTY * $itemTAX);
}
$sumOfLineItems = round($sumOfLineItems, 2);
$sumOfLineTax = round($sumOfLineTax, 2);

if ($sumOfLineItems == 0) {
$sumofLineTax = 0;
$optionsLI = array();
$discountProblemsFlag = TRUE;
if ($optionsST['SHIPPINGAMT'] == $optionsST['AMT']) {
$optionsST['SHIPPINGAMT'] = 0;
}
}

[DrByte]

So it is.