Spaces problem in bad coupon notification

[moosesoom]

Whenever I try to use a coupon not valid because of some restrictions previously set I receive this notification:

This%20coupon%20code%20is%20not%20valid%20for%20any%20product%20currently%20in%20your%20cart.

That comes from languages/CUSTOM_TEMPLATE/english.php:

define('TEXT_INVALID_COUPON_PRODUCT', 'This coupon code is not valid for any product currently in your cart.');

Other notifications, as the coupon success one, coming from same define file are correctly visualized with spaces, and not with "%20".

Is it a known bug? I cannot find any news about it.

[moosesoom]

I've just found in /includes/modules/order_total/ot_coupon.php:

if (!$foundvalid) zen_redirect(zen_href_link(FILENAME_CHECKOUT_PAYMENT, 'credit_class_error_code=' . $this->code . '&credit_class_error=' . urlencode(TEXT_INVALID_COUPON_PRODUCT . ' ' . $dc_check), 'SSL',true, false)); 

So I think it's the urlencode() function that changes spaces to %20
Every other notification use messageStack way....not this one....

So I found the "WHERE", can you please show me the "WHY"? :)

[moosesoom]

I actually patched /includes/modules/order_total/ot_coupon.php as below changing:

if (!$foundvalid) zen_redirect(zen_href_link(FILENAME_CHECKOUT_PAYMENT, 'credit_class_error_code=' . $this->code . '&credit_class_error=' . urlencode(TEXT_INVALID_COUPON_PRODUCT . ' ' . $dc_check), 'SSL',true, false)); 

to

if (!$foundvalid) {
         $messageStack->add_session('checkout_payment', TEXT_INVALID_COUPON_PRODUCT, 'error');
         $this->clear_posts();
         zen_redirect(zen_href_link(FILENAME_CHECKOUT_PAYMENT, '', 'SSL',true, false));
       } 

Anyway, I hope someone (ajeh? dr.byte? anyone else?) tell me if that's wrong, dangerous or simply stupid. (I followed other error messages convention :)

Thanks