Potential zen_has_product_attributes_values() error

[gjh42]

I noticed that in /includes/functions/functions_lookups.php, this function could apparently return a false negative if there were two or more attributes with equal and opposite total values (e.g. one adds $5.00 to base price and the other subtracts $5.00 from base).

/*
 *  Check if product has attributes values
 */
  function zen_has_product_attributes_values($products_id) {
    global $db;
    $attributes_query = "select sum(options_values_price) as total
                         from " . TABLE_PRODUCTS_ATTRIBUTES . "
                         where products_id = '" . (int)$products_id . "'";

    $attributes = $db->Execute($attributes_query);

    if ($attributes->fields['total'] != 0) {
      return true;
    } else {
      return false;
    }
  } 

It would appear that taking the absolute values of the prices before summing them would correct this.
"select sum(options_values_price)
"select sum((abs)options_values_price) or whatever is correct syntax for mysql.

[gjh42]

Another possibility would be to test in the query:

    $attributes_query = "select options_values_price
                         from " . TABLE_PRODUCTS_ATTRIBUTES . "
                         where products_id = '" . (int)$products_id . "'"
                         and options_values_price != 0
                         limit 1; 

then return true if there is a value for the field.

[Ajeh]

Could you give a real world example of where this is producing a problem?

[gjh42]

No, I haven't tested it, but if you had
(e.g. one adds $5.00 to base price and the other subtracts $5.00 from base)
would this not trigger it, acting as if there were no attribute price values?

I presume the value returned from this function matters in some situation, or else why have it at all?

/includes/templates/template_default/templates/tpl_product_info_display.php

Line #70 : echo $one_time . ((zen_has_product_attributes_values((int)$_GET['products_id']) and $flag_show_product_info_starting_at == 1) ? TEXT_BASE_PRICE : '') . zen_get_products_display_price((int)$_GET['products_id']);

[gjh42]

So presumably in the case above, you would not get the TEXT_BASE_PRICE text when it should appear.

[Ajeh]

I am trying to come up with a real world example where this can happen ... and so far, that only works if I have one Color Red for 5.00 and Size Small for -5.00 and no other choices ...

If you come up with a good test example let us know ...