Page 8 of 57 FirstFirst ... 67891018 ... LastLast
Results 71 to 80 of 567
  1. #71
    Join Date
    Jun 2009
    Posts
    389
    Plugin Contributions
    0

    Default Re: The NEW Google Merchant Thread - Version 1.12.0

    Quote Originally Posted by CandleMan View Post
    Just for information, I turned on the Advanced XML Sanitization and all is now working great.
    Excellent!

    Thanks for the information and good luck with your store.

  2. #72
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,571
    Plugin Contributions
    30

    Default bugs in version 1.12.0 and handling non-english language

    Just to summarise what I have found, (in case Numinix reads this)..when adapting this to cope with both english and spanish.

    Bugs
    1) for the country pulldown list in the admin.
    The function call as named by the sql install and the actual function name are not the same. Probably easiest to rename the function
    PHP Code:
    if (!function_exists('google_cfg_pull_down_country_list')){
        function 
    google_cfg_pull_down_country_list($countries_id$key '') {//steve was google_cfg_pull_down_country_iso3_list 
    This has been mentioned above but I would like to point out its a bug.

    2) the options for automatically adding the product types based on your category path.
    "bottom" is incorrectly coded in googlefroogle.php.

    Correction:
    PHP Code:
     $bottom_level $product_type[sizeof($product_type) - 1]; // sets last category in array as bottom-level, steve bug was +1 
    3) in the same location, the category names go through the htmlentities function to encode special characters (as per google feed specs). This garbles utf-8 as php defaults to iso-8859 so the correct code should be:
    PHP Code:
    $product_type htmlentities($bottom_levelENT_QUOTES,'UTF-8'); 
    However, when the accented characters are represented correctly in the feed, Google still complains of invalid format.
    So, get rid of the function altogether in the three instances, for example:
    PHP Code:
       $product_type $product_type[0];//steve removed htmlentities, Google no like
                  
    } elseif (GOOGLE_PRODUCTS_PRODUCT_TYPE == 'bottom') {
                    
    $bottom_level $product_type[sizeof($product_type) - 1]; // sets last category in array as bottom-level, steve bug was +1
                    
    $product_type $bottom_level;//steve removed htmlentities, Google no like
                  
    } elseif (GOOGLE_PRODUCTS_PRODUCT_TYPE == 'full') {
                    
    $full_path implode(","$product_type);
                    
    $product_type $full_path;//steve removed htmlentities, Google no like 
    4) Duplicated <g:google_product_category> after each item.
    There is duplicated code in both googlefroogle and/classes/ google_base to deal with attributes. I did not investigate this fullly as I don't use attributes.
    I chose to comment out the code in google_base, this may not be the correct solution for your store.
    In any case search for g:google_product_category to find the repeated code.


    I have added code to the mod to be able to generate each feed with its own store description, currency, and default google category. If anyone wants it for their dual language store, pm me.
    Steve
    github.com/torvista: Spanish Language Pack, Google reCaptcha, Structured Data, Multiple Copy-Move-Delete, Image Checker, BackupMySQL Admin/Auto...

  3. #73
    Join Date
    Jun 2009
    Posts
    389
    Plugin Contributions
    0

    Default Re: bugs in version 1.12.0 and handling non-english language

    Quote Originally Posted by torvista View Post
    Just to summarise what I have found, (in case Numinix reads this)..when adapting this to cope with both english and spanish.

    Bugs
    1) for the country pulldown list in the admin.
    The function call as named by the sql install and the actual function name are not the same. Probably easiest to rename the function
    PHP Code:
    if (!function_exists('google_cfg_pull_down_country_list')){
        function 
    google_cfg_pull_down_country_list($countries_id$key '') {//steve was google_cfg_pull_down_country_iso3_list 
    This has been mentioned above but I would like to point out its a bug.

    2) the options for automatically adding the product types based on your category path.
    "bottom" is incorrectly coded in googlefroogle.php.

    Correction:
    PHP Code:
     $bottom_level $product_type[sizeof($product_type) - 1]; // sets last category in array as bottom-level, steve bug was +1 
    3) in the same location, the category names go through the htmlentities function to encode special characters (as per google feed specs). This garbles utf-8 as php defaults to iso-8859 so the correct code should be:
    PHP Code:
    $product_type htmlentities($bottom_levelENT_QUOTES,'UTF-8'); 
    However, when the accented characters are represented correctly in the feed, Google still complains of invalid format.
    So, get rid of the function altogether in the three instances, for example:
    PHP Code:
       $product_type $product_type[0];//steve removed htmlentities, Google no like
                  
    } elseif (GOOGLE_PRODUCTS_PRODUCT_TYPE == 'bottom') {
                    
    $bottom_level $product_type[sizeof($product_type) - 1]; // sets last category in array as bottom-level, steve bug was +1
                    
    $product_type $bottom_level;//steve removed htmlentities, Google no like
                  
    } elseif (GOOGLE_PRODUCTS_PRODUCT_TYPE == 'full') {
                    
    $full_path implode(","$product_type);
                    
    $product_type $full_path;//steve removed htmlentities, Google no like 
    4) Duplicated <g:google_product_category> after each item.
    There is duplicated code in both googlefroogle and/classes/ google_base to deal with attributes. I did not investigate this fullly as I don't use attributes.
    I chose to comment out the code in google_base, this may not be the correct solution for your store.
    In any case search for g:google_product_category to find the repeated code.


    I have added code to the mod to be able to generate each feed with its own store description, currency, and default google category. If anyone wants it for their dual language store, pm me.
    Steve, you are amazing!

    Thanks for all the updates too.

  4. #74
    Join Date
    May 2006
    Location
    Gardiner, Maine
    Posts
    2,289
    Plugin Contributions
    22

    Default Re: The NEW Google Merchant Thread - Version 1.12.0

    Numinix released a new version yesterday - nothing major but does include a bug fix - don't know what.

    http://www.numinix.com/zen-cart-modu...-center-feeder
    The full-time Zen Cart Guru. WizTech4ZC.com

  5. #75
    Join Date
    Jun 2009
    Posts
    389
    Plugin Contributions
    0

    Default Re: The NEW Google Merchant Thread - Version 1.12.0

    Quote Originally Posted by delia View Post
    Numinix released a new version yesterday - nothing major but does include a bug fix - don't know what.

    http://www.numinix.com/zen-cart-modu...-center-feeder
    You rock Delia...

    Hopefully some of the major bugs are fixed....keeping my fingers crossed..

  6. #76
    Join Date
    May 2006
    Location
    Gardiner, Maine
    Posts
    2,289
    Plugin Contributions
    22

    Default Re: The NEW Google Merchant Thread - Version 1.12.0

    Quote Originally Posted by PinkLeopard View Post

    Hopefully some of the major bugs are fixed....keeping my fingers crossed..
    Only one and he doesn't say what.
    The full-time Zen Cart Guru. WizTech4ZC.com

  7. #77
    Join Date
    Jun 2009
    Posts
    389
    Plugin Contributions
    0

    Default Re: The NEW Google Merchant Thread - Version 1.12.0

    Quote Originally Posted by delia View Post
    Only one and he doesn't say what.
    Ok.

    Just for the folks here and myself...do you recommend un-installing and re-installing the new version?

    Thanks!

  8. #78
    Join Date
    May 2006
    Location
    Gardiner, Maine
    Posts
    2,289
    Plugin Contributions
    22

    Default Re: The NEW Google Merchant Thread - Version 1.12.0

    No, there are no database changes.
    The full-time Zen Cart Guru. WizTech4ZC.com

  9. #79
    Join Date
    Jun 2009
    Posts
    389
    Plugin Contributions
    0

    Default Re: The NEW Google Merchant Thread - Version 1.12.0

    Quote Originally Posted by delia View Post
    No, there are no database changes.
    Great!

    Also, as I have searched the other forum too...do you have any idea on how to fix that double entry for product category?

    Thanks!

  10. #80
    Join Date
    May 2006
    Location
    Gardiner, Maine
    Posts
    2,289
    Plugin Contributions
    22

    Default Re: The NEW Google Merchant Thread - Version 1.12.0

    I haven't seen it happen myself. Would need access to the cart where it's happening before I could figure it out.
    The full-time Zen Cart Guru. WizTech4ZC.com

 

 
Page 8 of 57 FirstFirst ... 67891018 ... LastLast

Similar Threads

  1. v139h Adding GTIN values to Numinix Google Merchant Feeder
    By longstockings in forum All Other Contributions/Addons
    Replies: 2
    Last Post: 22 Nov 2016, 08:01 PM
  2. v155 Numinix Product Fields / Google Merchant feed error
    By CandleMan in forum All Other Contributions/Addons
    Replies: 9
    Last Post: 22 Nov 2016, 07:10 PM
  3. v154 Numinix Module Version Plugin
    By DarkAngel in forum General Questions
    Replies: 2
    Last Post: 16 Jul 2015, 01:00 AM
  4. v150 Need someone to volunteer to install Numinix Merchant feed. Google base feeder.
    By coucho in forum All Other Contributions/Addons
    Replies: 0
    Last Post: 29 Jun 2012, 04:18 AM
  5. Google Chrome Reporting Old Version on Product Page
    By drkramer in forum General Questions
    Replies: 3
    Last Post: 4 Sep 2008, 06:44 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR