Update currencies from timegenie.com's xml feed

[simon1066]

I wonder if someone can spare a few lines of code to alter admin/includes/functions/localization.php so that exchange rates are taken from timegenie's xml file rather than ecb's.

I've added this to init_general_funcs.php

define('CURRENCY_SERVER_PRIMARY', 'timegenie'); 

and have this at the top of localization.php

function quote_timegenie_currency($currencyCode = '', $base = DEFAULT_CURRENCY)
{
  $requested = $currencyCode;
  $url = 'http://rss.timegenie.com/forex.xml';
  $data = '';
  // check via file() ... may fail if php file Wrapper disabled.
  $XMLContent = @file($url);
  if (! is_object($XMLContent) && function_exists('curl_init')) {
    // check via CURL instead.
    $XMLContent = doCurlCurrencyRequest('POST', $url, $data);
    $XMLContent = explode("\n", $XMLContent);
  }
  $currencyArray = array();
  $rate = 1;
  $line = '';
//  $currencyCode = '';
  $currencyArray['EUR'] = 1;
  foreach ($XMLContent as $line) {
    if (preg_match("/currency='([[:alpha:]]+)'/", $line, $currencyCode)) {
      if (preg_match("/rate='([[:graph:]]+)'/", $line, $rate)) {
        $currencyArray[$currencyCode[1]] = (float)$rate[1];
      }
    }
  }
  if ($requested == $base) {
    $rate = 1;
  } else {
    $rate = (string)((float)$currencyArray[$requested] / $currencyArray[DEFAULT_CURRENCY]);
  }
  return $rate;
} 

timegenie's xml format is

<credit>
<!--
In order to use this data feed from timegenie.com, you have to display the following text, or something similar, clearly visible on your web page. The text should be a link to www.timegenie.com
-->
<!--
Please read more about our conditions and guidelines at http://rss.timegenie.com/free_xml_csv_feeds
-->
<text>Courtesy of Time Genie</text>
<url>http://www.timegenie.com/</url>
<title>foreign exchange rates courtesy of Time Genie</title>
</credit>
<data>
<code>BSD</code>
<description>Bahamas Dollar</description>
<rate>1.3176</rate>
</data>

whereas the existing ecb's format was

<Cube currency="USD" rate="1.3160"/>

I'm unsure as to how to make the necessary edits, although this has prompted me to start learning more about php.

[simon1066]

From what I've gathered so far, it appears that I should probably not try parsing timegenie's feed using regular expression, as is the existing method for the ecb feed, due to its nested tags. Instead use an xml parser - need to look into this.

[DrByte]

Why is it you want to use timegenie specifically?
What about their terms and conditions?

[simon1066]

Timegenie provides a more comprehensive list of currencies than those on currently updated by zencart.

As far as I can see, their terms are simply to provide attribution, which I don't see as a problem.

[DrByte]

I'll be happy to take a look, but it might be several days til I get to it.

[simon1066]

Thank you. Absolutely no rush - I'll obviously be updating manually in the meantime.

[DrByte]

/admin/includes/functions/extra_functions/currency_timegenie.php

<?php
/**
 * @package admin
 * @copyright Copyright 2003-2012 Zen Cart Development Team
 * @copyright Portions Copyright 2003 osCommerce
 * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
 * @version $Id: currencyupdate_timegenie.php 2012-02-09 drbyte $
 */
/**
 * This allows you to extract currency exchange rates from TimeGenie
 * YOU MUST GIVE CREDIT TO THEM VIA A LINK ON YOUR SITE. THIS IS REQUIRED ACCORDING TO THEIR TERMS AND CONDITIONS:
 * Please read more about TimeGenie conditions and guidelines at http://rss.timegenie.com/foreign_exchange_rates_forex
 *
 * In order to use this data feed from timegenie.com, you have to display the following text, or something similar, clearly visible on your web page. The text should be a link to www.timegenie.com
 * Foreign exchange rates courtesy of Time Genie http://www.timegenie.com/
 */
/**
 * EUR|Euro|1
 */
function quote_timegenie_currency($code, $base = DEFAULT_CURRENCY)
{
  if ($code == $base) return 1;
  $url = 'http://rss.timegenie.com/forex.txt';
  // check via file() ... may fail if php file Wrapper disabled.
  $page = @file($url);
  if ((!isset($page) || $page == '') && function_exists('curl_init')) {
    // check via cURL instead.
    $page = doCurlCurrencyRequest('GET', $url);
    $page = explode("\n", $page);
  }
  if ($page !='') {
    $currencyArray = array();
    foreach($page as $key) {
      $val = explode('|', $key);
      $currencyArray[$val[0]] = (float)$val[2];
    }
    return (string)((float)$currencyArray[$code] / $currencyArray[DEFAULT_CURRENCY]);
  }
}

/admin/includes/extra_configures/currency_timegenie.php

<?php
/**
 * @package admin
 * @copyright Copyright 2003-2012 Zen Cart Development Team
 * @copyright Portions Copyright 2003 osCommerce
 * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
 * @version $Id: currencyupdate_timegenie.php 2012-02-09 drbyte $
 */
if (!defined('IS_ADMIN_FLAG')) {
  die('Illegal Access');
}
define('CURRENCY_SERVER_PRIMARY', 'TimeGenie');

YOU MUST GIVE CREDIT TO THEM VIA A LINK ON YOUR SITE. THIS IS REQUIRED ACCORDING TO THEIR TERMS AND CONDITIONS:
See and follow their conditions and guidelines at http://rss.timegenie.com/foreign_exchange_rates_forex

[brevardcountypcr]

nice work

[simon1066]

That's great, thanks for doing this.

[simon1066]

The reason for my original question is that I'm carrying out an exercise to include all of the world's currencies in a zen cart site.

In order to maximise the automatic update of exchange rates and avoiding paid subscriptions I believe the best way is to gather rates from Timegenie, Ecb & Boc. I've successfully added a 'tertiary' server reference but am having trouble with Boc's feed.

On a 'pre-timegenie' copy of the site and setting Boc as the primary server the automatic update only gets the rate for USD and errors out on the others - picking them up from the secondary server.

Could it be that the code for retrieving the Boc feed needs revising?

Has anyone else been able to retrive rates from this source?