Re: Odd link problem after upgrade
Thanks Rod. You poked me in the right direction.
I checked the /includes/functions/html_output.php file against a clean copy from my untouched 1.3.9h files and it is, as I suspected, just the default one. I also checked all mods installed, and the few that added anything to the includes/functions folder did so correctly, by using the extra_functions folder, and none of them modified that particular file anyway. But...
Looking at that file, just above where you said to insert the echo line (which I tried, but no lightbulbs went off over my head), I saw this line...
$link = preg_replace('/&/', '&', $link);
I'm not much of a hand at PHP but that seemed to me to be replacing an escaped ampersand with the offending HTML entity ampersand. So I commented that line out and reloaded the page. Et voila! The problem disappeared, all links seem to be written correctly and all work correctly.
I think it's safe to leave everything like this, since there is clearly another line above that one which is concatenating any extra ampersands properly. I'll test all the way through an order just to be sure. But now the question becomes, why would I have to do that to a default ZC file which works fine as is on other sites? Or maybe, why was the New Products For [Month] box bypassing that clean up routine when it too is standard ZC? Or maybe the real question is, how many lines of code does Zen Cart contain?
Breakfast: the most important donut of the day.