Price not getting displayed correctly; with attributes

[devyani]

Hi,
I have used radio buttons to price a product, based on its sizes.
So in the pricing screen I have kept the price as 0. This is an exempted product, hence I have created a new tax class called "no vat" & mentioned the rate as 0%.
attaching the screen shot for the same:


Next in the attribute section I have done the following setting :


On this category I have put a discount of 10% thru salemaker.

But, if you see the website - the amount next to radio button has not taken the discount, whereas the amount next to the price is showing the discount.

Another funny thing is that despite mentioning "no vat", a vat of 5.5% is added on each of these products in the attribute window. I have highlighted that in the image above.
I have a vat category of 5.5%, but clearly I have not defined it here.
I have no clue what to change where. Please help !

[devyani]

Anyone ?

[RixStix]

What price is displayed on the public side of things, not admin screen?

[Ajeh]

I am pretty sure that I have found the issue for that, I just need to test a little more ...

Is there anywhere else you see a problem on the Product Tax/No Tax issue besides the Attributes Controller?

I will try to finish testing this fix as soon as I can and get the fix for v1.5.1 as I have been working on fixes for v1.5.3 ...

[devyani]

@ RixStix - by mistake I have attached wrong image. The last one was meant to be the site image. Here it is :

[devyani]

@ RixStix - by mistake I have attached wrong image. The last one was meant to be the site image. Here it is :

[devyani]

@ Ajeh, Thank you so much !
There are only two categories; on my site; where there is no tax. One of them is books and the other these. I do not have attributes on books, so can't see any issue there.
If you want me to do some testing at my end, would be happy to help :)

[devyani]

@ Ajeh, Thank you so much !
There are only two categories; on my site; where there is no tax. One of them is books and the other these. I do not have attributes on books, so can't see any issue there.
If you want me to do some testing at my end, would be happy to help :)

[Ajeh]

devyani ... pretty positive I will have your solution tomorrow after I wake up and have some coffee ... :)

Your issue is actually more of a "proper display" problem and not an error of bad or damaged code and does not affect you store, but is wrong and a pain in the admin ...

Please let me know if you have seen this anywhere else in your admin or your store, besides the attributes controller so that I can give you those fixes when I put the fix together for you on the Attributes Controller ...

NOTE: This will also be fixed in our next release and I am surprised as heck that no one has reported this until now ... thanks for the excellent catch! I will get you the solution quick as I can tomorrow but it is 3:14am here and I gotta snooze a bit first ...

[Ajeh]

To fix the Attributes controller to display the Tax or No Tax on a Product, edit the file:
/your_secret_admin/attributes_controller.php

Change the code around line 1222 and add the code in RED:

<?php
  $current_options_name = '';
  // get products tax id
  $product_check = $db->Execute("select products_tax_class_id from " . TABLE_PRODUCTS . " where products_id = '" . $products_filter . "'" . " limit 1");
//  echo '$products_filter: ' . $products_filter . ' tax id: ' . $product_check->fields['products_tax_class_id'] . '<br>';
  while (!$attributes_values->EOF) {
    $current_attributes_products_id = $attributes_values->fields['products_id'];

Change the code around line 1594 and add the code in RED:

$attributes_price_final = $currencies->display_price($attributes_price_final, zen_get_tax_rate($product_check->fields['products_tax_class_id']), 1);

Change the code around line 1596 and add the code in RED:

$attributes_price_final_onetime = $currencies->display_price($attributes_price_final_onetime, zen_get_tax_rate($product_check->fields['products_tax_class_id']), 1);

Change the code around line 1629 and add the code in RED:

      $new_attributes_price = '|' . $currencies->display_price($new_attributes_price, zen_get_tax_rate($product_check->fields['products_tax_class_id']), 1);

Now check to see if the Product without tax displays in the Attributes Controller right and check it a Product with tax displays in the Attributes Controller right ...