Store Pickup and my other address-based delivery needs

[EZorb]

@frank
On the pages that have to be merged I believe you used a older file than the one in 155e. So how can you tell which is your code or maybe code change on the older page itself. I assumed (not good idea) all differences on your page was your changes and merged all into 155e page.

[EZorb]

Hey Ezorb, this may be a good point to take that part of the discussion to the plugin's support thread (helps you and others), and then of course could reference the discussion from here. Thread: http://www.zen-cart.com/showthread.p...PDP%29-Support

With post going back and forth I thought we were on the support page. Maybe some admin person can move it there.
Also the reason I never address your many repeated questions is I thought that was answered in post #19. Sorry for my miss understanding.

[frank18]

@frank
On the pages that have to be merged I believe you used a older file than the one in 155e. So how can you tell which is your code or maybe code change on the older page itself. I assumed (not good idea) all differences on your page was your changes and merged all into 155e page.

Which file is it please?

[frank18]

.....
What about it Frank should the review page only show the two services if zip codes match?

Yep, that's correct.

[EZorb]

Which file is it please?

Here is a few pages as an example.

Your Page:
functions_general.php
* General functions used throughout Zen Cart
*
* @package functions
* @copyright Copyright 2003-2014 Zen Cart Development Team
* @copyright Portions Copyright 2003 osCommerce
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version GIT: $Id: Author: Ian Wilson Wed Feb 19 15:57:35 2014 +0000 Modified in v1.5.3 $

1.5.5e Page
<?php
/**
* functions_general.php
* General functions used throughout Zen Cart
*
* @package functions
* @copyright Copyright 2003-2016 Zen Cart Development Team
* @copyright Portions Copyright 2003 osCommerce
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version $Id: Author: zcwilt Fri Apr 22 22:16:43 2015 +0000 Modified in v1.5.5 $
*/
Checkout_shipping.php
storepickup.php
tpl_product_info.php
tpl_shopping_cart-default.php

All of these pages you used (now) are older than same page in 155e. What I am trying to understand is how can a person tell if the difference in your page and the same page in 155e is your code that needs to be merge or if the differences shown is an update to the page in general?

Larry

[EZorb]

Yep, that's correct.

Then that means I do have something wrong with the review page. Way back in the post in the image you should see both options offered and shipping address is not a match at all. All my zip codes are in 79xxx series. When I click on Checkout Page then the two options are not displayed and they should not be. So if I understand you they should not be displayed on review page either.
Do you have a clue what I should check?

Larry

[frank18]

@Ezorb

The lines of concern are

    $check_cart_local = $_SESSION['cart']->in_cart_check('product_is_local_delivery','1'); 

and

      // if product is local delivery only - disable all other modules
      case ($check_cart_local and $shipping_module != 'localdelivery' || $shipping_module != 'storepickup'):
        return false;
        break; 

I am aware that this needs to be changed in the next update of this plugin to the effect that functions_general.php is not changed from the stock file.

BTW, any issues related to this module (PDP) should really be posted in the dedicated support thread found here:

https://www.zen-cart.com/showthread....PDP%29-Support

[EZorb]

I will wait to next update, not that big of deal. Yes I agree needs to be moved. How do you do that?

[lankeeyankee]

I use the regular store pickup and have changed the text on the site to reflect that it is for pick up at our store location with our city name included. This helps to avoid confusion. I find it is beneficial to us to not have it restricted by zip code or other means since we use store pickup for walk in customers who can come from far afield and also do have customers ordering online and coming in to pick up from out of state when they are passing through.

I can see how it would be useful for other people to be able to configure some type of restriction like zone or zip/postal code, and think it would be a good idea to incorporate this option in the core code.

[mc12345678]

Perhaps it gets incorporated or not, but I would actually suggest either a little "rebranding" or maybe modify the product description for it to appear in a search for zipcode. :) if Frank hadn't been on top of this topic, I know I wouldn't have found it or considered the use of postcode/postalcode (standard terminology for some areas that also speak English.) and while it appears to have initiated as a "delivery" method it now includes a pickup method as well.