Different Total Displayed

[todoonada]

@todonada, have you tested to see if the code in the current GitHub master branch (https://github.com/zencart/zencart) corrects this issue? I'm pretty sure that this was one of the test cases I used when making those pricing-calculation updates.

Sorry for the late reply!

I applied the changes described here
https://github.com/lat9/zencart/comm...44631fc0b06cba
and here
https://github.com/zencart/zencart/pull/6141/files

So far everything seems to work fine and the problem from the initial post is solved thanks to your code changes.

[lat9]

Sorry for the late reply!

I applied the changes described here
https://github.com/lat9/zencart/comm...44631fc0b06cba
and here
https://github.com/zencart/zencart/pull/6141/files

So far everything seems to work fine and the problem from the initial post is solved thanks to your code changes.

Thanks to you, @todoonada! I appreciate the 3rd-party verification as well as your original posting of the issue.

[todoonada]

Hello lat9,
I have one more question.
Currently a tax of 173.6363 is rounded to 173. (I have no decimals in the currency).
I would like to have it rounded to 174 (half round up method).
In the sense of "Total is 1910, a 10% tax of 174 is included".
Now it displays 173 instead of 174.

Where do I have to change your code?

[todoonada]

I went to includes/modules/order_total/ot_tax.php
and changed line 98 from

'text' => $currencies->format($taxValue, true, $order->info['currency'], $order->info['currency_value']),

to

'text' => $taxValue,

Now on the front end the 10% tax is displayed as 173.3. Round this and it is 173 of course.
The value of 173.3 is not correctly. It should be 173.6.
So it seems it is not the wrong rounding method, but the calculation of $taxValue is off.

[todoonada]

Sorry, some further information:

a) If I have a product price of 8280 and no shipping costs, the tax is displayed correctly as 753.
b) If I have a product price of 8280 and shipping costs of 910 (total of 9190), the tax is displayed as 836, it should be 835.
c) If I change the product price to 9190 (same like total in above) and free shipping, the tax is displayed correctly 835.

So it seems there is something wrong with the tax calculation of the shipping costs.

[OldNGrey]

Versions affected: zc158a with patches and zc200
file /includes/classes/order.php

Issue: currency conversion applied on item price in shopping_cart and reapplied on the sub-total for checkout_payment.

I updated /includes/classes/order.php to include changes from #6094 and #6141 to correct tax calculations.
Prices are displayed including tax. Most orders are for domestic orders so they include tax. When the delivery address is overseas the items become tax exempt. This is determined by zones.


Now with the new code:

• user selects a currency eg Euro and creates an account with a delivery address outside Australia.
• The currency conversion is applied on the item:
• item cost in AUD ex tax = $118.77 converted to EUR = €73.58 [ conversion rate of 0.61948508] = result is OK
• in checkout shipping, postage is calculated and returned in Euro = result is OK
• in checkout payment, the sub-total before postage is now €45.93 = INCORRECT [ this is the items price in EURO reconverted to EURO by the same conversion factor ]

[lat9]

Thanks for the details, OldNGrey. Once I've coffeed-up, I'll take a look on zc200-rc1 and report back.

[lat9]

OldNGrey, what's the full (with 4 decimal digits) price recorded in the database for that 118.77 product?

[lat9]

Sorry, some further information:

a) If I have a product price of 8280 and no shipping costs, the tax is displayed correctly as 753.
b) If I have a product price of 8280 and shipping costs of 910 (total of 9190), the tax is displayed as 836, it should be 835.
c) If I change the product price to 9190 (same like total in above) and free shipping, the tax is displayed correctly 835.

So it seems there is something wrong with the tax calculation of the shipping costs.

@todoonada, I'll be looking at this as well using the zc200-rc1 code.

[lat9]

Zen Cart issue created to track the correction(s) for the above two pricing issues: https://github.com/zencart/zencart/issues/6318