Incorrect processing of Tax

[dbltoe]

@dbltoe, I can't explain why that site's having those issues. I

- Installed an as-shipped zc158a with no demo data.
- Configured the store in United States/Florida, tax basis Store/Store, display prices with tax.
- Changed the default "Taxable Goods" rate to be 10% (easier calculations)
- Added a $100.00 product, using the default "Taxable Goods"
- Removed all but the Flat shipping module, which is configured with Tax Basis = Store and Tax Class = "Taxable Goods"

Created an account at the store, added the product to my cart.
- Shopping-cart page shows $110.00
- Checkout payment shows: Sub-Total ($110.00), Flat Rate ($5.50), FL TAX 10% ($10.50), Total ($115.50), using either a Florida or California-based shipping address.

Is this perhaps a typo?
Even if the tax is on the $100 product versus the Sub-Total of $110, and not charged on shipping, shouldn't that tax show as $10 versus $10.50.
And, if the tax is taxing both the $100 product and the $5.50 shipping, shouldn't the tax should show $10.55.

Regardless, the only difference between your settings and the site's settings are the tax zone/rate and product price which should only affect the final total not the amounts shown on the shopping cart or in OPC.

I have compared the DB with a standard install and found nothing that should affect the sales tax.

I do note that the site is no longer displaying the price with tax as selected in the admin.

Looking further.

[dbltoe]

Okay, I installed a fresh 1.5.8a with no demo

Configuration >> My Store >> Basis of Product Tax and Basis of Shipping Tax set to Store

Display Prices with Tax to true

Single $100 product added and set as Taxable Goods

Payment is only Check/Money Order

Shipping is Flat Rate set at $5.50, Taxable Goods, Tax Basis - Store

Zone Definitions show Florida and described as Florida local sales tax zone

Tax Classes set to Taxable Goods

Tax Rates is set to Taxable Goods, Zone - Florida, Tax Rate - 10%

Logged in a customer from Texas and the item price changed to $100.

Page 1 of checkout showed Flat Rate at $5.50

Page 2 showed a Sub-Total of $100, a Flat Rate of $5.50, and a total of $105.50

Finally, I was presented a bill for $105.50 at Page 3 of standard checkout. No tax.

Before clicking on the confirm order, I clicked on Shopping Cart and the item showed a price of $100 versus the $110 prior to logging in.

Logged out and went to the product again. The price shown was $110.

[dbltoe]

My initial feeling was that possibly that something in the display prices with tax was not playing well with all the other settings.

I removed just that setting and created a completely new user only to have the same results.

I have even ensured that the Initial Setup Wizard is a valid Miami address and that the Podtal Code under Shipping/Packaging is set to 33130.

I will be glad to furnish access to the test site. This customer is having to pay $$$$ in tax that they are not able to collect.

[dbltoe]

More info since we can't bump

The site had EO 4.6.2 installed and, of course, it was not working.

I noticed work on 4.7.0 on GitHub and removed all 4.6.2 EO and installed 4.7.0 with the optional overrides.

EO seems to work but, on the edit page, I get the

Warning: You have configured Zen Cart to display prices without tax. This page is currently displaying prices with tax.

. The database reports that the setting IS set to true.

I know you said that you have not tested EO with that feature so, I turned on the debug and got the following:

2023-11-27 22:52:38, Edit Orders entered (4.7.0-beta2) action (edit)Enabled Order Totals: ot_subtotal.php;ot_shipping.php;ot_coupon.php;ot_group_pricing.php;ot_tax.php;ot_loworderfee.php;ot_gv.php;ot_total.php
getOrderInfo(edit), on entry: Called by /home/******/public_html/##########/edit_orders.php on line #112
    Subtotal: (not set), Shipping: (not set), Shipping Tax-Rate:  (not set), Shipping Tax-Description:  (not set), Shipping Tax: (not set), Tax: 0.0000, Total: 40.5500, Tax Groups: {"0.0000":"1"}
    $_SESSION['shipping']: (not set)


Order Totals
        ot_subtotal. Text: $34.95, Value: 34.9500
        ot_shipping. Text: $5.60, Value: 5.6000
        ot_tax. Text: $0.00, Value: 0.0000
        ot_total. Text: $40.55, Value: 40.5500




getProductTaxes(Tax)
{"products_tax_class_id":"1"}{"qty":1,"id":"324","orders_products_id":"2398","name":"Texas Horned Lizard Pewter Figurines","model":"1111-0203 1\"","tax":"0.0000","price":"0.0000","final_price":"34.9500","onetime_charges":"0.0000","products_priced_by_attribute":"1","product_is_free":"0","products_discount_type":"0","products_discount_type_from":"0","products_weight":"0.247","products_virtual":0,"product_is_always_free_shipping":0,"products_quantity_order_min":"1","products_quantity_order_units":"1","products_quantity_order_max":"0","products_quantity_mixed":1,"products_mixed_discount_quantity":0,"attributes":[{"option":"Size:","value":"Stretch 4 inches","option_id":"2","value_id":"13","prefix":"+","price":"34.9500","product_attribute_is_free":1}]}
getProductTaxes, returning 0.


eo_get_country, returning modified country array: {"id":"223","title":"United States","iso_code_2":"US","iso_code_3":"USA"}
eo_get_country, returning modified country array: {"id":"223","title":"United States","iso_code_2":"US","iso_code_3":"USA"}
eo_get_country, returning modified country array: {"id":"223","title":"United States","iso_code_2":"US","iso_code_3":"USA"}
getOrderInfo(edit), on exit:


    Subtotal: 34.9500, Shipping: (not set), Shipping Tax-Rate:  (not set), Shipping Tax-Description:  (not set), Shipping Tax: (not set), Tax: 0.0000, Total: 40.5500, Tax Groups: {"Tax":0}
    $_SESSION['shipping']: (not set)


Order Totals
        ot_subtotal. Text: $34.95, Value: 34.9500
        ot_shipping. Text: $5.60, Value: 5.6000
        ot_tax. Text: $0.00, Value: 0.0000
        ot_total. Text: $40.55, Value: 40.5500


eoInitializeShipping(1559, edit), on entry: 
    Subtotal: 34.9500, Shipping: (not set), Shipping Tax-Rate:  (not set), Shipping Tax-Description:  (not set), Shipping Tax: (not set), Tax: 0.0000, Total: 40.5500, Tax Groups: {"Tax":0}
    $_SESSION['shipping']: (not set)


Order Totals
        ot_subtotal. Text: $34.95, Value: 34.9500
        ot_shipping. Text: $5.60, Value: 5.6000
        ot_tax. Text: $0.00, Value: 0.0000
        ot_total. Text: $40.55, Value: 40.5500


calculateOrderShippingTax returning 0, rate = '0.0000', cost = 5.6000.
removeTaxFromShippingCost, updated: 1, 5.6000, 5.6, 0
eoInitializeShipping(1559, edit), on exit: 
    Subtotal: 34.9500, Shipping: 5.6, Shipping Tax-Rate: 0.0000, Shipping Tax-Description:  (not set), Shipping Tax: 0, Tax: 0, Total: 40.5500, Tax Groups: {"Tax":0}
    $_SESSION['shipping']: {"title":"United States Postal Service (USPS Ground Advantage™)","id":"usps_","cost":"5.6000"}


Order Totals
        ot_subtotal. Text: $34.95, Value: 34.9500
        ot_shipping. Text: $5.60, Value: 5.6000
        ot_tax. Text: $0.00, Value: 0.0000
        ot_total. Text: $40.55, Value: 40.5500


    Checking whether the product's attribute is a download, option_id = 2, value_id = 13: (1)


Checking order for virtual status.  Order contains 1 unique products, 0 of those are virtual


============================================================
= Creating display of Order Product #2398
============================================================
Product Details:
{
    "qty": 1,
    "id": "324",
    "orders_products_id": "2398",
    "name": "Texas Horned Lizard Pewter Figurines",
    "model": "1111-0203 1\"",
    "tax": "0.0000",
    "price": "0.0000",
    "final_price": "34.9500",
    "onetime_charges": "0.0000",
    "products_priced_by_attribute": "1",
    "product_is_free": "0",
    "products_discount_type": "0",
    "products_discount_type_from": "0",
    "products_weight": "0.247",
    "products_virtual": 0,
    "product_is_always_free_shipping": 0,
    "products_quantity_order_min": "1",
    "products_quantity_order_units": "1",
    "products_quantity_order_max": "0",
    "products_quantity_mixed": 1,
    "products_mixed_discount_quantity": 0,
    "attributes": [
        {
            "option": "Size:",
            "value": "Stretch 4 inches",
            "option_id": "2",
            "value_id": "13",
            "prefix": "+",
            "price": "34.9500",
            "product_attribute_is_free": 1
        }
    ]
}




Options ID #2
Product Attribute: 
[
    "1849"
]
Options Info:
{
    "options": {
        "1828": "Please Select Size:",
        "1829": "1 inch",
        "1830": "1 1\/4 inches",
        "1831": "1 3\/4 inches",
        "1832": "2 inches",
        "1840": "2.2 inches",
        "1833": "Up Tail 2 1\/2 inches",
        "1834": "3 inch",
        "1835": "Out Tail 3 1\/2 inches",
        "1836": "Stretch 4 inches",
        "1837": "5 inches",
        "1839": "7 inches"
    },
    "name": "Size:",
    "type": "2",
    "length": "32",
    "size": "32",
    "rows": "0"
}
Preparing to display status history: {
    "date_added": {
        "title": "Date Added",
        "show_function": "zen_datetime_short",
        "include_field_name": false
    },
    "customer_notified": {
        "title": "Customer Notified",
        "show_function": "eo_display_customers_notifications_icon",
        "align": "center",
        "include_field_name": false
    },
    "orders_status_id": {
        "title": "Status",
        "show_function": "built-in"
    },
    "comments": {
        "title": "Comments",
        "show_function": "built-in"
    },
    "updated_by": {
        "title": "Updated By",
        "align": "center",
        "show_function": "built-in"
    }
}

Perhaps this additional information can get us on the right track

[dbltoe]

Looking further, EO will change and add the tax on the EO page when the tax is correctly entered as 7.75%.

However, although the tax is shown on the form, it is not added into the total.

The order's invoice also shows the tax but it is not included in the total.

When looking at an in-state order, the tax rate is not shown but the tax is shown below above the total.

As in the other scenario, the Total does not include the tax.

[dbltoe]

Okay, I installed a fresh 1.5.8a with no demo

Configuration >> My Store >> Basis of Product Tax and Basis of Shipping Tax set to Store

Display Prices with Tax to true

Single $100 product added and set as Taxable Goods

Payment is only Check/Money Order

Shipping is Flat Rate set at $5.50, Taxable Goods, Tax Basis - Store

Zone Definitions show Florida and described as Florida local sales tax zone

Tax Classes set to Taxable Goods

Tax Rates is set to Taxable Goods, Zone - Florida, Tax Rate - 10%

Logged in a customer from Texas and the item price changed to $100.

Page 1 of checkout showed Flat Rate at $5.50

Page 2 showed a Sub-Total of $100, a Flat Rate of $5.50, and a total of $105.50

Finally, I was presented a bill for $105.50 at Page 3 of standard checkout. No tax.

Before clicking on the confirm order, I clicked on Shopping Cart and the item showed a price of $100 versus the $110 prior to logging in.

Logged out and went to the product again. The price shown was $110.

And, in further hopes of getting this bug fixed.....

I loaded EO 4.70 beta to the test site. It is the only mod.

EO reports that I do not have taxes set to Displa with Price yet the Configuration and DB say I do.

[lat9]

EO was probably complaining about the fact that you're displaying with taxes on the storefront but not in the admin, as it has for many many years now.

I'll grant that there's an issue here; how about you open the issue on GitHub? I'm kind of heads-down on another project at the current time.

[dbltoe]

EO or ZC?

[lat9]

It's a base Zen Cart issue.

[wilt]

have been looking at this and have found a couple of code issues that will be affecting this in the zen_get_tax_locations function
hoping to have a fix asap