"Undefined variable" warning in zen_build_keyword_where_clause function

[yesaul]

Happy New Year everyone

PHP 8 can generate "Undefined variable" and "Passing null to parameter" warnings in zen_build_keyword_where_clause function (functions_strings.php, line 211)

    function zen_build_keyword_where_clause($fields, $string, $startWithWhere = false)
   {
        global $db, $zco_notifier;

        $zco_notifier->notify('NOTIFY_BUILD_KEYWORD_SEARCH', '', $fields, $string);
        if (zen_parse_search_string(stripslashes($string), $search_keywords)) {
            $where_str = " AND (";
 
            ...

        }
        if (substr($where_str, -7) === '( ()  )') {
            return ' ';
        }
        return $where_str ?? ' ';
    }

My quick suggestion:

if (!empty($where_str) AND substr($where_str, -7) === '( ()  )') {
            return ' ';
        }

[mc12345678]

There's a number of ways to potentially address:
1. Pre-assign a default value, then change the final torn to just send the value of $where_str.
2. Add a test for emptiness or lack of setting before checking if made of empty parentheses. The return of this test to be whatever default or representation of being empty. Then remove the test against being set to just return the $where_str value.
3. Put the test of the empty parentheses inside the if statement that appears to generate that result. And apply variations of the above.

But, the solution adopted is/was in this pull request: https://github.com/zencart/zencart/pull/5747/files