Code in default_filter.php

[yesaul]

Sorry, if I do understand something wrong, but this code does not seem correct, IMHO:

// Legacy $_GET['sort'] which was used for sort-by-clicking-column-heading
if (isset($column_list) && !empty($_GET['sort'])) {
    if (!isset($_GET['sort']) && PRODUCT_LISTING_DEFAULT_SORT_ORDER !== '') {
        $_GET['sort'] = PRODUCT_LISTING_DEFAULT_SORT_ORDER;
    }
...
}

(Lines 93>> in new default_filter.php for v2.0.0)

[yesaul]

// Legacy $_GET['sort'] which was used for sort-by-clicking-column-heading
if (!isset($_GET['sort']) && PRODUCT_LISTING_DEFAULT_SORT_ORDER !== '') {
    $_GET['sort'] = PRODUCT_LISTING_DEFAULT_SORT_ORDER;
}
if (isset($column_list) && !empty($_GET['sort'])) {
...
}

[lat9]

@yesaul, what issue are you experiencing? With which template?

[yesaul]

@yesaul, what issue are you experiencing? With which template?

I use my own template, where "sort-by-clicking-column-heading" is (still) in use

But this does actually no matter, as code quoted in my first message seems meaningless anyway

I suggest I am not only one why needs this legacy code, and as it was added to new version, it should be correct, shouldn't it ? (or removed...)


My site