Results 1 to 5 of 5
  1. #1
    Join Date
    Jan 2005
    Location
    USA, St. Louis
    Posts
    3,719
    Plugin Contributions
    9

    Default Metatags on manufacturers pages? Bug, or am I misunderstanding?

    It seems like, from the modules/meta_tags.php file that there is supposed to be custom metatags using the manufacturers name, yet its just using the basic metatags for the site. If you go to any person's zen cart that is using the manufacturers sidebox you'll see what I mean.

    This is the section of code that leads me to believe that zen cart is supposed to do this (around line 97):
    Code:
        } elseif ($category_depth == 'products') {
    	    if (isset($_GET['manufacturers_id'])) {
            $sql = "select manufacturers_name from " . TABLE_MANUFACTURERS . " where manufacturers_id = '" . (int)$_GET['manufacturers_id'] . "'";
            $manufacturer_metatags = $db->Execute($sql);
            if ($manufacturer_metatags->EOF) {
              $meta_tags_over_ride = true;
            } else {
              define('META_TAG_TITLE', $manufacturer_metatags->fields['manufacturers_name'] . PRIMARY_SECTION . TITLE . TAGLINE);
              define('META_TAG_DESCRIPTION', TITLE . PRIMARY_SECTION . $manufacturer_metatags->fields['manufacturers_name'] . SECONDARY_SECTION . KEYWORDS);
              define('META_TAG_KEYWORDS', KEYWORDS . ' ' . $manufacturer_metatags->fields['manufacturers_name']);
            } // EOF
    I'd like the manufacturers pages to have the manufacturers name in the title. Anyone know how I can make this happen?

    Thanks!

  2. #2
    Join Date
    Sep 2003
    Location
    Ohio
    Posts
    64,696
    Plugin Contributions
    6

    Default Re: Metatags on manufacturers pages? Bug, or am I misunderstanding?

    well heck ... click the manufacturers' sidebox ... nope ... click the manufactuers' dropdown ... nope ...

    Betcha you want me to tidy all that code up eh? How hard can it be?

    Thanks for the update ...
    Linda McGrath
    If you have to think ... you haven't been zenned ...

    Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!

    Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today: v1.5.1]
    Officially PayPal-Certified! Just click here

    Try our Zen Cart Recommended Services - Hosting, Payment and more ...

  3. #3
    Join Date
    Jan 2005
    Location
    USA, St. Louis
    Posts
    3,719
    Plugin Contributions
    9

    Default Re: Metatags on manufacturers pages? Bug, or am I misunderstanding?

    Quote Originally Posted by Ajeh
    well heck ... click the manufacturers' sidebox ... nope ... click the manufactuers' dropdown ... nope ...

    Betcha you want me to tidy all that code up eh? How hard can it be?

    Thanks for the update ...
    Thanks for the reply Ajeh...

    But do you mean you plan on fixing that bit of code, or just clean it out, as a non-viable option?

    I'm just curious if there is some typo or small change that could make it work... I'd really appreciate that feature.

    Thanks!

  4. #4
    Join Date
    Sep 2003
    Location
    Ohio
    Posts
    64,696
    Plugin Contributions
    6

    Default Re: Metatags on manufacturers pages? Bug, or am I misunderstanding?

    Actually it will be best to wait until the next upcoming bug fix ...

    It took quite a few extra little tweaks and twists as the manufacturers_id is defined by 2 values depending on how you display the products_listing ... and at what level in the Cats etc.

    It was lots of fun ...

    But ... it appears to work much better now ...
    Linda McGrath
    If you have to think ... you haven't been zenned ...

    Did YOU buy the Zen Cart Team a cup of coffee and a donut today? Just click here to support the Zen Cart Team!!

    Are you using the latest? Perhaps you've a problem that's fixed in the latest version: [Upgrade today: v1.5.1]
    Officially PayPal-Certified! Just click here

    Try our Zen Cart Recommended Services - Hosting, Payment and more ...

  5. #5
    Join Date
    Jan 2005
    Location
    USA, St. Louis
    Posts
    3,719
    Plugin Contributions
    9

    Default Re: Metatags on manufacturers pages? Bug, or am I misunderstanding?

    Quote Originally Posted by Ajeh
    Actually it will be best to wait until the next upcoming bug fix ...

    It took quite a few extra little tweaks and twists as the manufacturers_id is defined by 2 values depending on how you display the products_listing ... and at what level in the Cats etc.

    It was lots of fun ...

    But ... it appears to work much better now ...
    Wait? You want me to wait?

    Oh, OK

    Patience was never a virtue of mine.

 

 

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •