[Done v1.3.8] No details in HTML email footers

[Noutje]

I use the new version 1.3.7 and allways my email was set to txt format.
Now i changed it in configuration to sent emails in MIME html format. It works OK but there are no payment details in the MIME html format when moneyorder payment module is used.

It seems that only the MODULE_PAYMENT_MONEYORDER_TEXT_TITLE is being sent to the customer in MIME html format but not the:
MODULE_PAYMENT_MONEYORDER_TEXT_DESCRIPTION
and the
MODULE_PAYMENT_MONEYORDER_TEXT_EMAIL_FOOTER.
that contain the payment details.

Seems like something is missing in the includes/classes/orders.php

When i change the settings back to only txt emails this information is being sent...

[DrByte]

Aha ... a bug ...

/includes/classes/order.php
approx line 956 says this:

    $html_msg['PAYMENT_METHOD_FOOTER'] = (is_object($GLOBALS[$_SESSION['payment']] && $GLOBALS[$payment_class]->email_footer != '') ? nl2br($GLOBALS[$payment_class]->email_footer) : $this->info['cc_type'] );

there is a placement problem with one of the ) marks, and it should say this:

    $html_msg['PAYMENT_METHOD_FOOTER'] = (is_object($GLOBALS[$_SESSION['payment']]) && $GLOBALS[$payment_class]->email_footer != '') ? nl2br($GLOBALS[$payment_class]->email_footer) : $this->info['cc_type'];

[tcustomgolf]

Hey Doc, I didn't have the "n12br" (which is around the middle of your code) in my 1.3.7 classes/orders.php. I noticed it is in both of your code statements. I am assuming it should be there for a line break?

[DrByte]

nl2br() means "new line to <br>" ... it converts new-line characters to <br> tags, making suitable for HTML content

[tcustomgolf]

Right, I just hadn't seen it in the original line of my code, but it was in yours. Just making sure it was okay to include since I didn't have it in before.

[all4coffee]

Aha ... a bug ...

/includes/classes/order.php
approx line 956 says this:

    $html_msg['PAYMENT_METHOD_FOOTER'] = (is_object($GLOBALS[$_SESSION['payment']] && $GLOBALS[$payment_class]->email_footer != '') ? nl2br($GLOBALS[$payment_class]->email_footer) : $this->info['cc_type'] );

there is a placement problem with one of the ) marks, and it should say this:

    $html_msg['PAYMENT_METHOD_FOOTER'] = (is_object($GLOBALS[$_SESSION['payment']]) && $GLOBALS[$payment_class]->email_footer != '') ? nl2br($GLOBALS[$payment_class]->email_footer) : $this->info['cc_type'];

I had the same problem - Thank you Dr. Byte! Works great!

I just noticed that when customers purchase the item which is out of stock (I did allow it in admin settings) they get the note "Products marked with *** are out of stock. Items not in stock will be placed on backorder." This information however does not appear on their (and mine) confirmation e-mails. Is there a way to rectify this? As the store owner I would find it very useful to right away be alerted that the item purchased is the backorder item and the lack of this notification might be misleading to some customers (they might think that the items are already in stock).