MSRP contrib

[jonkip]

In trying the MSRP display, the file at
includes/functions/functions_price.php

is showing an error, and the page is empty

the logs show that it's an Unexpected end of file error

I'm not sure what the issue is, and if anyone has a working copy of that file I'd love to take a look at it...

the file I downloaded has an error someplace.... I'll keep looking... thanks for any help

zen cart version 1.5.1 latest version of MSRP display mod

[Jonathan Grant]

In trying the MSRP display, the file at
includes/functions/functions_price.php

is showing an error, and the page is empty

the logs show that it's an Unexpected end of file error

I'm not sure what the issue is, and if anyone has a working copy of that file I'd love to take a look at it...

the file I downloaded has an error someplace.... I'll keep looking... thanks for any help

zen cart version 1.5.1 latest version of MSRP display mod

same here...anyone know what the issue is?

log says:

[29-Jan-2015 15:01:31 America/Chicago] PHP Parse error: syntax error, unexpected end of file in /root/includes/functions/functions_prices.php on line 1408

[Design75]

same here...anyone know what the issue is?

log says:

[29-Jan-2015 15:01:31 America/Chicago] PHP Parse error: syntax error, unexpected end of file in /root/includes/functions/functions_prices.php on line 1408

I think I found the error. There is a closing bracket missing.
find

 }}else{
 $final_display_price = $show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount;
 }
 }
 
 // end modifications ================= 

and add a "}"

 }}else{
 $final_display_price = $show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount;
 }
 }
  }
 // end modifications ================= 

[DrByte]

Design75 is right. Same thing was reported and a fix posted just a couple posts earlier: http://www.zen-cart.com/showthread.p...69#post1243869

[Design75]

I posted an updated version in the downloads

[Louis]

I posted an updated version in the downloads

Hi, the latest update is missing the following just before the closing bracket in functions_prices.php around line 330.

    return $final_display_price . $free_tag . $call_tag; 

Without the "Return" call no prices are being displayed. Could you please update the contribution accordingly and re-upload.

BTW, thank you for making this available to the community and for your time and effort in maintaining this plugin.

[Louis]

I have noticed another issue with this plugin which has to do with the pricing display.

If your store is setup to show prices with VAT (tax) included the plugin will display the saving incorrectly:

Retail Price: R3,990.00
You save: R526.32 (15%)
Our Price: R3,390.00

The store is setup to add a standard 14% VAT to all prices and the 526.32 is the saving excluding the 14% VAT.

This should read:

Retail Price: R3,990.00
You save: R600.00 (15%)
Our Price: R3,390.00

Anybody else having the same issue?

[Louis]

Sorry folks, I tried to edit the previous post but was too late.

I made the following changes and it seems to work for my specific requirements. Hope this is useful to someone else as well.

In functions_prices.php find

        $final_display_price = '<span class="smalltext1"><s>' . TEXT_PRODUCT_MSRP . $currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</s></span><br><span class="save">' . TEXT_PRODUCT_SAVE . $currencies->display_price($save, '') . '&nbsp;&nbsp;(' . number_format((($display_msrp_price - $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)' . '</span><br><span class="norm">' . TEXT_PRODUCT_OUR . $show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount . '</span>'; 

and replace with

        $final_display_price = '<span class="smalltext1"><s>' . TEXT_PRODUCT_MSRP . $currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '</s></span><br><span class="save">' . TEXT_PRODUCT_SAVE . $currencies->display_price($save, zen_get_tax_rate($product_check->fields['products_tax_class_id'])) . '&nbsp;&nbsp;(' . number_format((($display_msrp_price - $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)' . '</span><br><span class="norm">' . TEXT_PRODUCT_OUR . $show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount . '</span>'; 

The discount is now displaying with the VAT included.

[frank18]

I have submitted an updated version for ZC 1.5.4 - it should be available for download in a few days.

[SilverHD]

frank18:

Thanks for the heads up and the contribution. I will be looking for it!

Silver