[Done v2.0.0] tpl_account_default.php HTML Error

[dweingart]

Small HTML error in tpl_account_default.php in the #prevOrders table. The cell widths look like this:

<tr>
<td width="70px">
<td width="30px">
<td>
<td width="70px">
<td width="70px" align="right">
<td align="right">
</tr>

The width attributes shouldn't contain the string "px".

I did a search and couldn't find this mentioned anywhere else.

-dave

[froyse]

Thanks for pointing that out. I'm using Zen Cart 1.3.0.1 and found a programming error on this same page that causes the HTML layout to break depending which options are active in the Email Notifications section.

<?php
  if (SHOW_NEWSLETTER_UNSUBSCRIBE_LINK !='false' or CUSTOMERS_PRODUCTS_NOTIFICATION_STATUS !='0') {
?>

<h2><?php echo EMAIL_NOTIFICATIONS_TITLE; ?></h2>

<?php
  if (SHOW_NEWSLETTER_UNSUBSCRIBE_LINK=='true') {
?>

<ul id="myAccountNotify" class="list">

<li><?php echo ' <a href="' . zen_href_link(FILENAME_ACCOUNT_NEWSLETTERS, '', 'SSL') . '">' . EMAIL_NOTIFICATIONS_NEWSLETTERS . '</a>'; ?></li>

<?php } //endif newsletter unsubscribe ?>

<?php
  if (CUSTOMERS_PRODUCTS_NOTIFICATION_STATUS == '1') {
?>

<li><?php echo ' <a href="' . zen_href_link(FILENAME_ACCOUNT_NOTIFICATIONS, '', 'SSL') . '">' . EMAIL_NOTIFICATIONS_PRODUCTS . '</a>'; ?></li>

</ul>

<?php } //endif product notification ?>

<?php } // endif don't show unsubscribe or notification ?>

should be

<?php
  if (SHOW_NEWSLETTER_UNSUBSCRIBE_LINK !='false' or CUSTOMERS_PRODUCTS_NOTIFICATION_STATUS !='0') {
?>

<h2><?php echo EMAIL_NOTIFICATIONS_TITLE; ?></h2>

<ul id="myAccountNotify" class="list">

<?php
  if (SHOW_NEWSLETTER_UNSUBSCRIBE_LINK=='true') {
?>

<li><?php echo ' <a href="' . zen_href_link(FILENAME_ACCOUNT_NEWSLETTERS, '', 'SSL') . '">' . EMAIL_NOTIFICATIONS_NEWSLETTERS . '</a>'; ?></li>

<?php } //endif newsletter unsubscribe ?>

<?php
  if (CUSTOMERS_PRODUCTS_NOTIFICATION_STATUS == '1') {
?>

<li><?php echo ' <a href="' . zen_href_link(FILENAME_ACCOUNT_NOTIFICATIONS, '', 'SSL') . '">' . EMAIL_NOTIFICATIONS_PRODUCTS . '</a>'; ?></li>

<?php } //endif product notification ?>

</ul>

<?php } // endif don't show unsubscribe or notification ?>

The enclosing unordered list tags should be placed in the level of the first conditional statement, not with the individual list item conditionals. Otherwise, if only one of the two individual conditions are true, the UL will be missing the opening or closing tag.

[DrByte]

The issue reported above for v1.3.0.x has already been implemented in v1.3.5. Note that the currently-released version is v1.3.7.

[afo]

The issue reported above for v1.3.0.x has already been implemented in v1.3.5. Note that the currently-released version is v1.3.7.

You're freaking me out, Dr. Byte. You've marked this thread "Done 1.3.8".

[DrByte]

Small HTML error in tpl_account_default.php in the #prevOrders table. The cell widths look like this:

<tr>
<td width="70px">
<td width="30px">
<td>
<td width="70px">
<td width="70px" align="right">
<td align="right">
</tr>

The width attributes shouldn't contain the string "px".

I did a search and couldn't find this mentioned anywhere else.

-dave

You're freaking me out, Dr. Byte. You've marked this thread "Done 1.3.8".

Oops ... actually, the changes to this template for cell-width are addressed in v1.4

[afo]

Oops ... actually, the changes to this template for cell-width are addressed in v1.4

Ah... ok... I'm not having a great day at work and seeing a number higher than the latest release confused me... not difficult today... off to do more debugging.