no shipping available after login

[Ajeh]

Is this an upgrade?

What version was this?

How did you do the upgrade?

[moktar]

Is this an upgrade?

What version was this?

How did you do the upgrade?

No, clean install from 1.3.7 zip

I suspect there is some code to be reviewed in includes\classes\shopping_cart.php

at line 670, there is this code in the loop for all attributes:

 
          $adjust_downloads ++;

Then this var is used around line 725 to alter free_shipping_price and free_shipping_item, BUT ONLY IF $adjust_downloads equals 1. That means the order of the option has an influence on the calculation. I don't understand if there is a good reason for this. I don't know if you are a zen cart code guru, but my guess is there is something to fix here. It looks like temporary debugging code that has not been cleaned. Even indentation is broken:

 
// adjust for downloads
// adjust products price
  $check_attribute = $attribute_price->fields['products_attributes_id'];
  $sql = "select *
                    from " . TABLE_PRODUCTS_ATTRIBUTES_DOWNLOAD . "
                    where products_attributes_id = '" . $check_attribute . "'";
  $check_download = $db->Execute($sql);
  if ($check_download->RecordCount()) {
// do not count download as free when set to product/download combo
    if ($adjust_downloads == 1 and $product->fields['product_is_always_free_shipping'] != 2) {
      $this->free_shipping_price += zen_add_tax($products_price, $products_tax) * $qty;
      $this->free_shipping_item += $qty;
    }
// adjust for attributes price
    $this->free_shipping_price += $qty * zen_add_tax( ($new_attributes_price), $products_tax);
//die('I SEE B ' . $this->free_shipping_price);
  }
//  echo 'I SEE ' . $this->total . ' vs ' . $this->free_shipping_price . ' items: ' . $this->free_shipping_item. '<br>';

Could someone (with a good understanding of zen cart internals) have a look on this code and see if it really does what was intended ?

Thank you.

[Ajeh]

The Downloads are managed based on being a normal Product ...

The are NOT Virtual and they are NOT Always Free Shipping ...

When a Product is both a Download and a Physical Product you should mark it as Special Combo ...

Your's is setup as Download or Download with CD ...

The better way to handle that is to make it so the Download does not have weight and the CD does have weight ...

I think you have weight on the Product itself ...

[moktar]

The Downloads are managed based on being a normal Product ...

The are NOT Virtual and they are NOT Always Free Shipping ...

I want the download to be always available, even for people who order the CD.

When a Product is both a Download and a Physical Product you should mark it as Special Combo ...

Why ? I understand (and tested) that this option only forces the shipping address and method selection for orders with no weight. I don't need to force the shipping selection if there is nothing to ship.

Your's is setup as Download or Download with CD ...

The better way to handle that is to make it so the Download does not have weight and the CD does have weight ...

I think you have weight on the Product itself ...

That is exactly what I did (the product has no weight and the attribute has).

From my previous post, we can see that the position of the attribute in the list is crucial for the calculation and this is probably the issue to check by a zen cart programmer.

Now I found out there is no problem when the CD-ROM option is the first attribute. I will live with that for now (and write it somewhere in red that attributes must be sorted).

Nevertheless, this is probably the bug to fix: the shipping part of the checkout for a weightless product will only be triggered if its attribute with weight is the first one.

[Ajeh]

I am the Zen Cart coder for this ...

I will have to see if you are yet another exception to the rule ...

There is a special setting for Combo on a Product where a Product is both a download and a physical product ...

There is a setting where the Product can be either a Download or a Physical Product ...

There is a setting where the Product can be a Download only ...

I have to see if you just have a setting incorrect on the weights, attribute settings, etc. ...