Dynamic Price Updater

[swguy]

Nicely done. An extremely skillful application of DOM traversal. But there are a couple of outstanding issues:

- sales and specials seem to break it.
- sideboxes with radio buttons seem to break it.

I just skimmed the thread quickly and I apologize if someone else has already mentioned these items.

Scott

PS> I thought the use of innerHTML was unsafe in FF and friends, but it seems to work in my FC4/FF 1.5 and Win/FF 2, so there you are.

[Chrome]

Hi

Sorry for the lateness of my reply

First off thanks Chumly and Scott for your comments, which I'll deal with in order

Chumly: Do you have some links to pages that are failing? I know why your first problem is happening but the Updater should certainly be able to handle multiple instances of, say, a radio box

Scott

1st issue: Yeah, basically this is because the base price 'finder' is inefficient... I'm working on a way round this (there is another way but I really don't want this mod to be affecting other ZC files)

2nd issue: I have noticed this but it seems to be a bit spurious... After reading your post it occurred to me that I could probably avoid this by narrowing the scope of the traversal... Testing ahoy

As for the innerHTML issue: There is a small comment near the bottom of the script that admits that innerHTML is cheating ... Essentially I think innerHTML is a Microsoft creation... Issues arise in standards compliant browsers when the innerHTML applied contains HTML which needs to be accessed using DOM methods... IE will parse and format the contents of innerHTML and place them into the DOM tree whereas FF et al will not

Dan

[allusiv]

Chrome: Do you have any interest in updating this module / writing a new module to pull from the backend instead of visual identifiers?

Either way, thanks for a great mod. It has been a lot of help for me and my projects.

[blakems]

This is great. I do have a bug I think. I keep getting a price = $NaN what would that be from. I am using some larger numbers so I don 't know if that effects it. Thanks for the help. Here is an example of where I am using it . http://se2labs.bluesunhosting.com/ca...ecff22e082eabe

[Chrome]

Hi

Allusiv: Yes I do plan to use vars handed from the back-end rather than relying on the 'page reading' method, but only for certain values... Not sure which yet and also not quite sure how lol... I think the base price and the attribute actuators are the values I really need (as Ajeh has pointed out the attributes can be sneaky and the page may not provide a stable visual reference as to what, exactly, they are doing)

blakems: I know what is wrong with your site (nice looking by the way): The comma in the price... The system looks for numeric values only separated by a decimal point; I completely forgot that prices could go so high that a comma will be included... D'oh!

I'll get that fixed and issue an update... Watch this space!

blakems I will note that you have included the ZenID string in your URL... Always remove that bit! It can be [potentially] used to steal a session or some other XSS exploit... Best to be on the safe side

Thanks all for the great feedback

Dan

[Chrome]

Hi

I've released an updated version of the Updater at the usual link (will include it at the end of this post)

Commas should now pose no problem for the base price reader... I hope

I've also including a debug message system... If there any problems or issues with the Updater open the file in your favourite editor and find the following line:

var _debug = false;

Change the false to true and each time the Updater does something it will show in the debug message list below the product description (and any attributes)... To clear the list click on the debug message box title

This should help track down what's going on without having to insert alert() calls throughout the code

You can see the Updater in debug mode here: http://chrome.me.uk/shopdev/index.ph...products_id=36

Dan

http://chrome.me.uk/PriceUpdater.zip

[blakems]

Thanks chrome, I will update the code and let you know how it goes.

Also, thanks for the tip on the session ID—I wish it wasn't stored in the URI

[blakems]

That does work with the update. Is there a way to add the commas back into the numbers—make them look pretty again?

[Chrome]

Hi

Glad that worked... As requested the commas are back

New file at the same link (above)

Dan

[jmacdoug]

Can you get this working for radio buttons yet? Take a look at why I need it... http://www.printsxpress.com/index.ph...&products_id=1

My different print sizes would work best if in radio form.