[Done v1.3.9] Problem with customer's date of birth in admin

[sanji]

I noticed that if, in Configuration / Minimum Values the Date of Birth parameter is set to 0, then there is an issue when you try to change the date of birth of a customer in the admin part : after you submit your changes, no error message will be displayed by the date will be set to 0001-01-01...

Example (verified on my 1.3.8a cart and on a fresh install) :

Set Configuration / Minimum Values, Date of Birth = 0
Go to admin/customers.php
Select any profile, click on Edit
Change the Date of Birth to anything you want, or even don't change it at all
Submit the changes
Click again on Edit -> the date of birth has disappeared.

I think the problem comes from admin/customers.php file, where:

        if (ACCOUNT_DOB == 'true') {
          if (ENTRY_DOB_MIN_LENGTH >0) {
            if (checkdate(substr(zen_date_raw($customers_dob), 4, 2), substr(zen_date_raw($customers_dob), 6, 2), substr(zen_date_raw($customers_dob), 0, 4))) {
              $entry_date_of_birth_error = false;
            } else {
              $error = true;
              $entry_date_of_birth_error = true;
            }
          } else {
            $customers_dob = '0001-01-01 00:00:00';
          }
        }

If ENTRY_DOB_MIN_LENGTH = 0, the date of birth is automatically set to 0001-01-01 00:00:00


sanji

[DrByte]

        if (ACCOUNT_DOB == 'true') {
          if (ENTRY_DOB_MIN_LENGTH >0) {
            if (checkdate(substr(zen_date_raw($customers_dob), 4, 2), substr(zen_date_raw($customers_dob), 6, 2), substr(zen_date_raw($customers_dob), 0, 4))) {
              $entry_date_of_birth_error = false;
            } else {
              $error = true;
              $entry_date_of_birth_error = true;
            }
          } else {
            $customers_dob = '0001-01-01 00:00:00';
          }
        }

Yes -- rearrange the highlighted lines, as shown:

        if (ACCOUNT_DOB == 'true') {
          if (ENTRY_DOB_MIN_LENGTH >0) {
            if (checkdate(substr(zen_date_raw($customers_dob), 4, 2), substr(zen_date_raw($customers_dob), 6, 2), substr(zen_date_raw($customers_dob), 0, 4))) {
              $entry_date_of_birth_error = false;
            } else {
              $error = true;
              $entry_date_of_birth_error = true;
            }
          }
        } else {
          $customers_dob = '0001-01-01 00:00:00';
        }

And, then if you want the DOB to be optional, set the Minimum Value for DOB to blank instead of 0 (otherwise the admin will pop up an alert saying it's not filled in).

[sanji]

Thanks DrByte ;)

sanji