Reward Points system...

[RodG]

As $_REQUEST is supposed to return all the $_POSTs I'm surprised that it didn't work. Any idea what the customers server settings were that affected it?

Alas, no I don't.

What I do know is that it is one of the few sites I've worked on that that uses FreeBSD, so that may be relevent.

I also know that *some* $_REQUEST variables are available.

These 3 appear to be consistant:
_REQUEST["_csuid"]
_REQUEST["zenAdminID"] (only when logged in as admin)
_REQUEST["zenid"]

I've no idea what the _csuid is.

Other possible useful info....
----------------------
Server OS: FreeBSD 4.10-RELEASE
Server Up Time: 1:30AM up 815 days,
HTTP Server: Apache/1.3.41 (Unix) FrontPage/5.0.2.2635 mod_ssl/2.8.31 OpenSSL/0.9.7m
-----------------------

Does that give any further clues?

Cheers
Rod

[thepollywog]

Andrew,

Are you the Andrew Moore who designed the rewards module? If so, thank you!

I have it installed and mostly working. I had trouble with points 4 and 4.1 of your readme:

"4. Switch on the 'Shopping Cart with Rewards' sidebox using Admin->Tools->Layout Box Controller

4.1. There is also a "Reward Points" sidebox which displays points in cart and points earned (if logged in)"

These do not appear in Admin->Tools->Layout Box Controller for me to check them off.

Could you help?

Dennis

[achachet]

Hi Andrew

First of all thank you very much for this very useful mod.

I have quite an issue with it, though: ZC computes VAT on the subtotal WITHOUT the discount!

Say I have a 10% tax rate in my country.

The customer places an order for 1000 € + 100 VAT = 1100.
Now he redeems 50€ worth of points.
The order appears as follows: 1000€ - 50 +100 VAT = 1050.
Unfortunately that's wrong.

His order should be :

(1000-50) + 95 VAT = 1045

because his pre-vat total is not 1000 but 950.

Despite the difference is very small as amounts are concerned, it poses a great problem in an accounting and fiscal perspective: the final bill does not have the right amount of tax displayed!

The solution is to reduce the '$value' returned by ot_tax.
Instead of returning $value, it should return:
$value - $points_worth * ($value / $order->info['subtotal']);

in my example : instead of 100 it returns : 100 - 50*(100/1000)=95

$value/$order->info['subtotal'] is used as a way to compute average tax rate on the order (you can have a mix of products with different tax rates)

I did change the ot_tax module (in a very dirty way, you might want to clean it a bit) to reflect these changes, feel free to contact me if I can help to update the module.

Warm regards,

Thomas

PS: since I do B2B, my redeem is applied before tax. If a shop sells to individuals, the issue would be the same, but the calculation would be different. In other words, you need to ask the administrator if the value of the points redeemed is pre- or post- VAT.