[Done v1.3.9] Solo cards with Website Payments pro

[flobster]

There is a problem with accepting Solo cards in Paypal website payments pro.

Why i beleive this is a bug:
When you process payments the bank declines SOLO cards because they do not get the correct information to process it correctly

When you have enabled ppwpp and selected SOLO card in configuration > Credit Cards to 1 (and any other cards you require)

When you goto checkout and want to pay via a SOLO card the checkout process will not allow you to enter details which are required to process your payment, it will not allow Issue number or Cvv -
I called the bank and they tell me they received the issue number as 00 - obviously i couldn't enter this so the checkout sent 00 because no entry was made.

The fields which you are allowed to enter are
Card number.
Start Date.
Expiry date.

for the card to be processed correctly the bank needs (the same as a Maestro card really)
Card number
Issue number
Expiry date
Cvv number (on back of card)

they do not need the start date (this is NOT printed on a SOLO card)

--
Ok so how i fixed this:

Opened up paypalwpp.php and paypalsp.php in inclues/modules/payment

            'if (value == "Switch" || value == "Solo") {' .
            '    document.checkout_payment.paypalwpp_cc_issue_month.disabled = false;' .
            '    document.checkout_payment.paypalwpp_cc_issue_year.disabled = false;' .
            '    document.checkout_payment.paypalwpp_cc_checkcode.disabled = true;' .
            '    if (document.checkout_payment.paypalwpp_cc_issuenumber) document.checkout_payment.paypalwpp_cc_issuenumber.disabled = true;' .

to

            '    document.checkout_payment.paypalwpp_cc_issue_month.disabled = true;' .
            '    document.checkout_payment.paypalwpp_cc_issue_year.disabled = true;' .
            '    document.checkout_payment.paypalwpp_cc_checkcode.disabled = false;' .
            '    if (document.checkout_payment.paypalwpp_cc_issuenumber) document.checkout_payment.paypalwpp_cc_issuenumber.disabled = false;' .

This will allow you to enter the card info into the fields which were blocked before the edit.

I also opened paypaldp.php in /includes/languages/english/modules/payment
and changed a couple of lines (not essential but nice to do they were

  define('MODULE_PAYMENT_PAYPALDP_TEXT_CREDIT_CARD_MAESTRO_ISSUENUMBER', 'Maestro Issue No.:');
 
to
 
  define('MODULE_PAYMENT_PAYPALDP_TEXT_CREDIT_CARD_MAESTRO_ISSUENUMBER', 'Issue No:');

This is in reference to the problem i had here
http://www.zen-cart.com/forum/showth...666#post520666


I hope that helps and maybe you can make a change for the next release.

Regards

Rob

[DrByte]

The code that you recommend changing affects both Switch and Solo.
Are you saying that the rules have changed?
Are you saying that *both* switch and solo need these changes?

[flobster]

Well switch is not really used anymore, Switch cards have been replaced by Maestro cards.

From memory of the old switch card i am sure they had a issue number on them and no start date (all of the banks have changed to Maestro as far as i am aware)

As far as i am aware no rules have changed around it, switch isno longer around at all as mastercard purchased switch and merged it with their Maestro cards

[DrByte]

Will research. Thanks for the heads-up.

[flobster]

No Problem

[DrByte]

Okay, so given that Switch has been swallowed up by Maestro and therefore Switch cards should be treated the same as Maestro cards, wouldn't it make sense instead to change this:

            'if (value == "Switch" || value == "Solo") {' .
            '    document.checkout_payment.paypalwpp_cc_issue_month.disabled = false;' .
            '    document.checkout_payment.paypalwpp_cc_issue_year.disabled = false;' .
            '    document.checkout_payment.paypalwpp_cc_checkcode.disabled = true;' .
            '    if (document.checkout_payment.paypalwpp_cc_issuenumber) document.checkout_payment.paypalwpp_cc_issuenumber.disabled = true;' .
            '} else if (value == "Maestro") {' .
            '    document.checkout_payment.paypalwpp_cc_issuenumber.disabled = false;' .
            '    if (document.checkout_payment.paypalwpp_cc_issue_month) document.checkout_payment.paypalwpp_cc_issue_month.disabled = true;' .
            '    if (document.checkout_payment.paypalwpp_cc_issue_year) document.checkout_payment.paypalwpp_cc_issue_year.disabled = true;' .
            '    document.checkout_payment.paypalwpp_cc_checkcode.disabled = false;' .
            '} else {' .

            'if (value == "Solo") {' .
            '    document.checkout_payment.paypalwpp_cc_issue_month.disabled = false;' .
            '    document.checkout_payment.paypalwpp_cc_issue_year.disabled = false;' .
            '    document.checkout_payment.paypalwpp_cc_checkcode.disabled = true;' .
            '    if (document.checkout_payment.paypalwpp_cc_issuenumber) document.checkout_payment.paypalwpp_cc_issuenumber.disabled = true;' .
            '} else if (value == "Switch" || value == "Maestro") {' .
            '    document.checkout_payment.paypalwpp_cc_issuenumber.disabled = false;' .
            '    if (document.checkout_payment.paypalwpp_cc_issue_month) document.checkout_payment.paypalwpp_cc_issue_month.disabled = true;' .
            '    if (document.checkout_payment.paypalwpp_cc_issue_year) document.checkout_payment.paypalwpp_cc_issue_year.disabled = true;' .
            '    document.checkout_payment.paypalwpp_cc_checkcode.disabled = false;' .
            '} else {' .

and also change from this:

    if (MODULE_PAYMENT_PAYPALDP_MODULE_MODE == 'Payflow-UK' && (CC_ENABLED_SOLO=='1' || CC_ENABLED_SWITCH=='1')) {
      // add extra fields for Switch/Solo cards
      for ($i = $today['year'] - 10; $i <= $today['year']; $i++) {
        $issue_year[] = array('id' => strftime('%y',mktime(0,0,0,1,1,$i)), 'text' => strftime('%Y',mktime(0,0,0,1,1,$i)));
      }
      array_splice($selection['fields'], 4, 0,
                   array(array('title' => MODULE_PAYMENT_PAYPALDP_TEXT_CREDIT_CARD_ISSUE,
                               'field' => zen_draw_pull_down_menu('paypalwpp_cc_issue_month', $expires_month, '', 'id="'.$this->code.'-cc-issue-month"' . $onFocus ) . '&nbsp;' . zen_draw_pull_down_menu('paypalwpp_cc_issue_year', $issue_year, '', 'id="'.$this->code.'-cc-issue-year"' . $onFocus),
                               'tag' => $this->code.'-cc-issue-month')));
    }
    if (MODULE_PAYMENT_PAYPALDP_MODULE_MODE == 'Payflow-UK' && CC_ENABLED_MAESTRO=='1') {
      // add extra field for Maestro cards
      array_splice($selection['fields'], 4, 0,
                   array(array('title' => MODULE_PAYMENT_PAYPALDP_TEXT_CREDIT_CARD_MAESTRO_ISSUENUMBER,
                               'field' => zen_draw_input_field('paypalwpp_cc_issuenumber', $maestronum, '', 'id="'.$this->code.'-cc-issuenumber"' . $onFocus ),
                               'tag' => $this->code.'-cc-issuenumber')));
    }

to this:

    if (MODULE_PAYMENT_PAYPALDP_MODULE_MODE == 'Payflow-UK' && CC_ENABLED_SOLO=='1' ) {
      // add extra fields for Switch/Solo cards
      for ($i = $today['year'] - 10; $i <= $today['year']; $i++) {
        $issue_year[] = array('id' => strftime('%y',mktime(0,0,0,1,1,$i)), 'text' => strftime('%Y',mktime(0,0,0,1,1,$i)));
      }
      array_splice($selection['fields'], 4, 0,
                   array(array('title' => MODULE_PAYMENT_PAYPALDP_TEXT_CREDIT_CARD_ISSUE,
                               'field' => zen_draw_pull_down_menu('paypalwpp_cc_issue_month', $expires_month, '', 'id="'.$this->code.'-cc-issue-month"' . $onFocus ) . '&nbsp;' . zen_draw_pull_down_menu('paypalwpp_cc_issue_year', $issue_year, '', 'id="'.$this->code.'-cc-issue-year"' . $onFocus),
                               'tag' => $this->code.'-cc-issue-month')));
    }
    if (MODULE_PAYMENT_PAYPALDP_MODULE_MODE == 'Payflow-UK' && (CC_ENABLED_MAESTRO=='1' || CC_ENABLED_SWITCH=='1')) {
      // add extra field for Maestro cards
      array_splice($selection['fields'], 4, 0,
                   array(array('title' => MODULE_PAYMENT_PAYPALDP_TEXT_CREDIT_CARD_MAESTRO_ISSUENUMBER,
                               'field' => zen_draw_input_field('paypalwpp_cc_issuenumber', $maestronum, '', 'id="'.$this->code.'-cc-issuenumber"' . $onFocus ),
                               'tag' => $this->code.'-cc-issuenumber')));
    }

... or am I missing something else?

[flobster]

Hi Dr B

I will change my files and see how the changes you suggested work out later on tonight, but looking at the code it looks as if the solo settings have not changed,

- it doesnt look like it is going to ask for an issue number,
- it also looks like it is is going to ask for a start date from the card, (which is not present on the card)
- it doesnt look like it will ask for the CVV number either on SOLO.

but i may be wrong reader the code so i will change my files and have a test of it later on.

Regards

Rob

[flobster]

I made the changes,

Switch and Maestro working fine, but Solo is not it still has the same options as it originally had as i suggested above.

Rob

[DrByte]

Okay, I 'get' that Switch has been swallowed up by Maestro.

Now, when and why has Solo changed how they operate?

[flobster]

I dont think they have changed the way they operate.

SOLO cards have always had issues numbers printed on them, always had CVV numbers and have not had start dates printed on them.

to authorise the card the bank requires a valid issue number and a valid cvv number, (they do not need a start date)

when i processed a transaction with the standard details that the form allows the bank declined it because the form sent a issue number of 00 and no cvv check number (i called them to check)

when i processed a transaction with the edits i made to the file to allow a issue number and a cvv to be entered the bank authorised the card and made the payment. (again i called the bank and they confirmed they got the 01 issue number transmitted to them)

Rob