[Fixed v1.5.1] PayPal WPP Processor Decline Fails to Show Error Message

24 Jul 2012, 8:36 PM

#1

Totally Zenned

Join Date:: Apr 2007
Location:: Vancouver, Canada
Posts:: 1,571
Plugin Contributions:: 60

[Fixed v1.5.1] PayPal WPP Processor Decline Fails to Show Error Message

Unless one of the debug options other than OFF are selected in PayPal Website Payments Pro, the $messageStack will not be outputted as described here:

http://www.zen-cart.com/showthread.php?184795-PayPal-Payment-Pro-no-Decline-error-quot&p=1140253#post1140253

I haven't verified if this is also the case with PayPal Express Checkout and Website Payments Standard, but you may want to check your code there as well.

Free and Premium Plugins Developed by Numinix

24 Jul 2012, 11:26 PM

#2

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,511
Plugin Contributions:: 176

Re: [Fixed v1.5.1] PayPal WPP Processor Decline Fails to Show Error Message

numinix:

This is coming from line 1853:
$detailedMessage = ($errorText == MODULE_PAYMENT_PAYPALDP_INVALID_RESPONSE || $errorText == MODULE_PAYMENT_PAYPALDP_TEXT_DECLINED || $this->enableDebugging || $response['CURL_ERRORS'] != '' || $this->emailAlerts) ? (isset($response['RESULT']) && $response['RESULT'] != 0 ? MODULE_PAYMENT_PAYPALDP_CANNOT_BE_COMPLETED . ' (' . $errorNum . ')' : $errorNum) . ' ' . urldecode(' ' . $response['L_SHORTMESSAGE0'] . ' - ' . $response['L_LONGMESSAGE0'] . ' ' . $response['CURL_ERRORS']) : '';
Thanks for the detailed report.
I haven't done any regression testing on this yet, but it appears that replacing $this->enableDebugging with $this->enableDebugging || (int)trim($errorNum) > 0 appears to solve the specific problem stated.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

24 Jul 2012, 11:29 PM

#3

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,511
Plugin Contributions:: 176

Re: [Fixed v1.5.1] PayPal WPP Processor Decline Fails to Show Error Message

Response posted in the thread quoted.

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

1 Aug 2012, 9:32 PM

#4

numinix

Totally Zenned

Join Date:: Apr 2007
Location:: Vancouver, Canada
Posts:: 1,571
Plugin Contributions:: 60

Re: [Fixed v1.5.1] PayPal WPP Processor Decline Fails to Show Error Message

Yes that will work.

Free and Premium Plugins Developed by Numinix

19 Sep 2012, 2:36 AM

#5

drbyte

Sensei

Join Date:: Jan 2004
Posts:: 63,511
Plugin Contributions:: 176

Re: [Fixed v1.5.1] PayPal WPP Processor Decline Fails to Show Error Message

Fixed in v1.5.1

.
Zen Cart - putting the dream of business ownership within reach of anyone!
Donate to: DrByte directly or to the Zen Cart team as a whole

Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.