Westminster New

[wtashby]

Here's what was in the file myDEBUG-20200828-141911-264968-deprecated.log

[28-Aug-2020 14:19:11 America/New_York] Request URI: /, IP address: 24.88.122.223
#1 each() called at [/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_languages_header.php:15]
#2 require(/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_languages_header.php) called at [/home/theatcom/flowertownengravable.gifts/includes/modules/sideboxes/languages_header.php:22]
#3 require(/home/theatcom/flowertownengravable.gifts/includes/modules/sideboxes/languages_header.php) called at [/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_header.php:73]
#4 require(/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_header.php) called at [/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_main_page.php:145]
#5 require(/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_main_page.php) called at [/home/theatcom/flowertownengravable.gifts/index.php:94]
--> PHP Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_languages_header.php on line 15.

[28-Aug-2020 14:19:11 America/New_York] PHP Parse error: syntax error, unexpected '$content' (T_VARIABLE) in /home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_whats_new.php on line 11

[28-Aug-2020 14:19:11 America/New_York] Request URI: /, IP address: 24.88.122.223
--> PHP Parse error: syntax error, unexpected '$content' (T_VARIABLE) in /home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_whats_new.php on line 11.

[dbltoe]

Try this one.

<?php/**
 * Side Box Template
 *
 * @package templateSystem
 * @copyright Copyright 2003-2011 Zen Cart Development Team
 * @copyright Portions Copyright 2003 osCommerce
 * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
 * @version $Id: tpl_whats_new.php 18698 2011-05-04 14:50:06Z wilt $
 * Modified by Picaflor Azul (Picaflor-Azul.com) Westminster New v2.0
 */
  $content = "";
  $content .= '<div class="sideBoxContent centeredContent">';
  $whats_new_box_counter = 0;
  while (!$random_whats_new_sidebox_product->EOF) {
    $whats_new_box_counter++;
    $whats_new_price = zen_get_products_display_price($random_whats_new_sidebox_product->fields['products_id']);
    $content .= "\n" . '  <div class="sideBoxContentItem">';
    $content .= '<div class="box-title"><a href="' . zen_href_link(zen_get_info_page($random_whats_new_sidebox_product->fields['products_id']), 'cPath=' . zen_get_generated_category_path_rev($random_whats_new_sidebox_product->fields['master_categories_id']) . '&products_id=' . $random_whats_new_sidebox_product->fields['products_id']) . '">' . zen_image(DIR_WS_IMAGES . $random_whats_new_sidebox_product->fields['products_image'], $random_whats_new_sidebox_product->fields['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT);
    $content .= '<br />' . $random_whats_new_sidebox_product->fields['products_name'] . '</a></div>';
    $content .= '<div class="box-price">' . $whats_new_price . '</div>';
    $content .= '</div>';
    $random_whats_new_sidebox_product->MoveNextRandom();
  }
  $content .= '</div>' . "\n";

[wtashby]

No good. Still blank on the bottom half.

[dbltoe]

Revert to original for now but, did the newest debug show a different problem?

[wtashby]

Error logs with all original sidebox files

myDEBUG-20200828-173108-562828-deprecated.log

[28-Aug-2020 17:31:08 America/New_York] Request URI: /, IP address: 24.88.122.223
#1 each() called at [/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_languages_header.php:15]
#2 require(/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_languages_header.php) called at [/home/theatcom/flowertownengravable.gifts/includes/modules/sideboxes/languages_header.php:22]
#3 require(/home/theatcom/flowertownengravable.gifts/includes/modules/sideboxes/languages_header.php) called at [/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_header.php:73]
#4 require(/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_header.php) called at [/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_main_page.php:145]
#5 require(/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_main_page.php) called at [/home/theatcom/flowertownengravable.gifts/index.php:94]
--> PHP Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_languages_header.php on line 15.

myDEBUG-20200828-173108-562828-warning.log

[28-Aug-2020 17:31:08 America/New_York] Request URI: /, IP address: 24.88.122.223
#1 each() called at [/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_languages_header.php:15]
#2 require(/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_languages_header.php) called at [/home/theatcom/flowertownengravable.gifts/includes/modules/sideboxes/languages_header.php:22]
#3 require(/home/theatcom/flowertownengravable.gifts/includes/modules/sideboxes/languages_header.php) called at [/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_header.php:73]
#4 require(/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_header.php) called at [/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_main_page.php:145]
#5 require(/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_main_page.php) called at [/home/theatcom/flowertownengravable.gifts/index.php:94]
--> PHP Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_languages_header.php on line 15.

And this log after uploading the last fix you sent:

myDEBUG-20200828-173544-187299-deprecated.log

[28-Aug-2020 17:35:44 America/New_York] Request URI: /, IP address: 24.88.122.223
#1 each() called at [/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_languages_header.php:15]
#2 require(/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_languages_header.php) called at [/home/theatcom/flowertownengravable.gifts/includes/modules/sideboxes/languages_header.php:22]
#3 require(/home/theatcom/flowertownengravable.gifts/includes/modules/sideboxes/languages_header.php) called at [/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_header.php:73]
#4 require(/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_header.php) called at [/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_main_page.php:145]
#5 require(/home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/common/tpl_main_page.php) called at [/home/theatcom/flowertownengravable.gifts/index.php:94]
--> PHP Deprecated: The each() function is deprecated. This message will be suppressed on further calls in /home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_languages_header.php on line 15.

[28-Aug-2020 17:35:44 America/New_York] PHP Parse error: syntax error, unexpected '$content' (T_VARIABLE) in /home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_whats_new.php on line 11

[28-Aug-2020 17:35:44 America/New_York] Request URI: /, IP address: 24.88.122.223
--> PHP Parse error: syntax error, unexpected '$content' (T_VARIABLE) in /home/theatcom/flowertownengravable.gifts/includes/templates/westminster_new/sideboxes/tpl_whats_new.php on line 11.

[dbltoe]

Well, that trial was based on the featured text that you posted earlier. At least it had the info properly nested. Since you don't use the featured side box, we don't know if it is correct.

Perhaps someone can correct any error I might have made. It's lost in my trifocals right now.

[wtashby]

Well, that trial was based on the featured text that you posted earlier. At least it had the info properly nested. Since you don't use the featured side box, we don't know if it is correct.

Perhaps someone can correct any error I might have made. It's lost in my trifocals right now.

I really do appreciate all the time and effort you've put into trying to help with this. Tell me though, what exactly are the nested errors doing? Is it causing something to happen or not happen that I"m not seeing? Is it something Google will frown upon?

Tom

[dbltoe]

There are certain things you're not allowed to do in CSS and HTML. Some of them are recognizable by "smarter" browsers and the browsers work around them. When you "mess up the nest" no one sits well and all sorts of weird things are "hatched."
Attachment 19170

Yours should be

<div>
  <a>
    <img />
  </a>
</div>

Notice why they call it nested. But it's

  <a>
    <img />
<div>
  </a>
</div>

The browser is smart enough to figure out what's wrong BUT, you'll note that it will not look at further errors. Since this is on every desktop-generated page, it can be catastrophic on any desktop page.

[wtashby]

Will this work? I just moved the </a>

$content = "";
$content .= '<div class="sideBoxContent centeredContent">';
$whats_new_box_counter = 0;
while (!$random_whats_new_sidebox_product->EOF) {
$whats_new_box_counter++;
$whats_new_price = zen_get_products_display_price($random_whats_new_sidebox_product->fields['products_id']);
$content .= "\n" . ' <div class="sideBoxContentItem">';
$content .= '<a href="' . zen_href_link(zen_get_info_page($random_whats_new_sidebox_product->fields['products_id']), 'cPath=' . zen_get_generated_category_path_rev($random_whats_new_sidebox_product->fields['master_categories_id']) . '&products_id=' . $random_whats_new_sidebox_product->fields['products_id']) . '">' . zen_image(DIR_WS_IMAGES . $random_whats_new_sidebox_product->fields['products_image'], $random_whats_new_sidebox_product->fields['products_name'], SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT);</a>
$content .= '<div class="box-title">' . $random_whats_new_sidebox_product->fields['products_name'] . '</div>';
$content .= '<div class="box-price">' . $whats_new_price . '</div>';
$content .= '</div>';
$random_whats_new_sidebox_product->MoveNextRandom();
}
$content .= '</div>' . "\n";

[wtashby]

No, never mind, that didn't work. Did the same thing your fix did.