Spurious HTML code in admin

[Pauls]

Using version 1.3.02 ZC
Hi everyone, I am trying to determine where these odd bits of code are being generated from. I have highlighted with red rectangle.


I have installed previously the mods 'sales reports' 'google froogle' and 'easy populate' - I have compared the 'orders.php' file, and found an anomoly, not sure if it is relevant but I am sure someone here can tell me.

This code is in my current orders.php

$html_msg['EMAIL_TEXT_STATUS_COMMENTS'] = $notify_comments;

which differs from this code from an untouched 1.3.02 orders.php

 $html_msg['EMAIL_TEXT_STATUS_COMMENTS'] = nl2br($notify_comments);

what does the difference between those pieces of code do?

If the above has nothing to do with my rogue HTML, could you help point me in the right direction to other files that may be relevant?

Many thanks for your time and help.

[DrByte]

It would seem to me that this comes from rogue content in your worldpay payment module's language file. Perhaps there is some sort of table content therein which is getting stored in the order as part of the name of the payment module, rather than merely using the name of the module for display.

[Pauls]

That is exactly what is happening DrByte, I had a worldpay image that was clickable in the checkout part of the process. It looks like this is where the HTML may be coming from, however I am trying to keep the method of the image, but not sure I can.

[Pauls]

I have now reverted back to the default worldpay.php settings, which is a shame as it was good to be able to use a proper world pay image at the selection stage. ( I am able to do this with the PayPal module without adverse affect, I will show the codes that I tried.

Here is the WorldPay module with image

  define('MODULE_PAYMENT_WORLDPAY_TEXT_CATALOG_TITLE', '<img src="includes/templates/template_default/buttons/english/worldp.gif" align="middle" alt="Select to pay via WorldPay">');
  define('MODULE_PAYMENT_WORLDPAY_TEXT_ADMIN_TITLE', 'WorldPay Payment Gateway');
  define('MODULE_PAYMENT_WORLDPAY_TEXT_DESCRIPTION', 'Worldpay Payment Module');
  define('MODULE_PAYMENT_WORLDPAY_TEXT_ERROR_MESSAGE', 'Your transaction has been cancelled or declined.  Please try again');
  define('MODULE_PAYMENT_WORLDPAY_TEXT_TITLE', 'Credit Card via WorldPay');

?>

that works fine but causes all kinds of grief in the admin part of the shop, not only to the default menu, but also to the contributions, in particular 'Sales Report' and 'Super Orders'.

Here is the code for PayPal doing the same thing, only without affecting the admin aspect of ZC

  define('MODULE_PAYMENT_PAYPAL_TEXT_ADMIN_TITLE', 'Paypal IPN');
  define('MODULE_PAYMENT_PAYPAL_TEXT_CATALOG_TITLE', '<img src="includes/templates/template_default/buttons/english/buywithpaypal.gif" align="middle" alt="Make selection to pay via PayPal">');

There must be a difference the way the two php pages relay the info back to the zc as I have only modded the same define in each case. Anyway if it can't be done it can't be done, was worth a try :)

PS if anyone is wondering why I am posting this at 5.00am in the morning, it's because my eldest just crawled in and woke us all up, now I can't get back to sleep so did this and had a cup of coffee ... getting tired again now, so job done