Is this a correct code change for PHP 5.3?

File has

Quote:

---

$value = ereg_replace("[\r\n\t ]+",' ',$value);

---

Changed to

Quote:

---

$value = preg_replace("/[\r\n\t ]+/",' ',$value);

---

Am I on the right track?
Not getting any errors, but wanted to check before submitting a change to a mod.

It looks correct to me.

See my blog post from last week: http://www.zen-cart.com/entry.php?2-...use-on-PHP-5-3

Yep, saw the blog when it was posted but the example was a little different. Was having no errors in testing but thought I'd throw it out before posting the change.

Great info DrByte!
THANX

And thanx to Glenn for taking a look.

Another check to verify I'm reading correctly....

Quote:

---

split('|'),0,{})

---

in .js would become

Quote:

---

explode('|'),0,{})

---

Or am I in the wrong ballpark?

If that's truly javascript and not PHP then there probably is no need to change it.

It's at the end of a compressed .js file so I'm not really able to tell. I'll defer to no change for now.
THANX again.

If it's a .js file then it's javascript, not PHP so no worries about PHP5.3 for that one.