Invoice.PHP 156 vs 154

Is there any downside to using the v154 invoice.php in v156? that is going to or might cause an OOPS down the road? Or security issue?

While the 156c version looks nice on the screen and I'm sure someone took a lot of time and trouble to change the format, but it takes twice the amount of space on the printed page. A 3/4 page invoice now takes 2 sheets of paper, so I have replaced the 156 invoice.php with 154 invoice.php but don't want to leave it there if it is going to cause headache in the future.

While it is not within my wheelhouse to begin editing the invoice appearance, that is one thing our customers complain about is being so cluttered with information that is needless or useless to them. An example being their name and address printed 3 times on the page and 4 columns of prices.

Thanks,

I don't see a difference. Did you customize 1.5.4? Perhaps tweak the print styles?

PS> I have never been wild about 4 columns of prices either. Maybe we can make that switchable in the future.

Quote:

---

Originally Posted by swguy

I don't see a difference. Did you customize 1.5.4? Perhaps tweak the print styles?

---

No edits on my part. There is a huge difference in the files from the 154 distribution and the 156 distribution. Printing a single line product may not be significant. A product with 2 or more attributes is a huge difference. 156 puts a blank line after each product and draws a line between products.

In 154, 2 products with 2 attributes each, prints in the same amount of paper as a single product with 2 attributes in 156 invoice.php

I don't think the forum will allow me to attach the 2 distribution files so that you don't have to go find them.

Quote:

---

Originally Posted by swguy

PS> I have never been wild about 4 columns of prices either. Maybe we can make that switchable in the future.

---

Some might need to see CUSTOMER, SOLD TO and SHIP TO but in our small world, the paper used to just print the CUSTOMER when it is duplicated, in most cases, twice below it.

Having all admins capable of logging in is more important to remedy than an inch of paper.

Quote:

---

CUSTOMER, SOLD TO and SHIP TO

---

The CUSTOMER portion in both 1.5.4 and 1.5.6c is only shown when either of two conditions are met. If billing name and delivery name are different or the billing street address and delivery street address are different

Code:

---

$show_customer = false;
if ($order->billing['name'] != $order->delivery['name']) {
  $show_customer = true;
}
if ($order->billing['street_address'] != $order->delivery['street_address']) {
  $show_customer = true;
}

---

I played with the invoice in developer tools in the browser and most of the extra spacing you are seeing in the 1.5.6c version is padding or margin-bottom. So you could play around to figure out which paddings/margins you need to set to 0 to collapse the line items in the invoice to make it fit better when printing and put those rules in the admin/includes/stylesheet_print.css to only apply those adjustments for the print job.

Quote:

---

Originally Posted by barco57

The CUSTOMER portion in both 1.5.4 and 1.5.6c is only shown when either of two conditions are met. If billing name and delivery name are different or the billing street address and delivery street address are different

Code:

---

$show_customer = false;
if ($order->billing['name'] != $order->delivery['name']) {
  $show_customer = true;
}
if ($order->billing['street_address'] != $order->delivery['street_address']) {
  $show_customer = true;
}

---

---

TNX Mike, I'll have a look... probably after I get all the admin logins resolved.

My first example is an order where Customer and Sold to names and addresses are identical. Ship to is effectively identical but has the word street spelled out for the shipto and abbreviated for the Customer and Sold to. All 3 are on the printed page.

Thank you for the references to areas to 'play with'. That is very helpful for a non-coder, like me.

Quote:

---

Originally Posted by RixStix

Ship to is effectively identical but has the word street spelled out for the shipto and abbreviated for the Customer and Sold to. All 3 are on the printed page.

---

"effectively identical" and "actually identical" are different things and would satisfy the if and setting $show_customer = true

TNX. I understand after you explained the logic.