[Done v1.3.8] Email footer of payment modules not working in HTML email

The data put into the $email_footer variable by payment modules never gets into the final HTML email that is sent to the customer if they have their email pref set to HTML. If they use the Plain text option the footer appears in the email as it should.

I have traced the problem down to line 956 in includes/classes/order.php line. The line currently reads as follows:

Code:

---

$html_msg['PAYMENT_METHOD_FOOTER'] = (is_object($GLOBALS[$_SESSION['payment']] && $GLOBALS[$payment_class]->email_footer != '') ? $GLOBALS[$payment_class]->email_footer : $this->info['cc_type'] );

---

I have changed the line as follows:

Code:

---

$html_msg['PAYMENT_METHOD_FOOTER'] = (is_object($GLOBALS[$_SESSION['payment']]) && $GLOBALS[$payment_class]->email_footer != '' ? $GLOBALS[$payment_class]->email_footer : $this->info['cc_type'] );

---

Notice that the end bracket for the call to is_object has moved.

After making this change the extra info now appears in the HTML emails.

The problem only seems to have starter since 1.3.7 as I never had problems with 1.3.6.

Could someone please confirm if this is how the code was intended to look?

Thanks.

Correct.
Similar discussion here:
http://www.zen-cart.com/forum/showth...535#post317535

Fix is included in the upcoming v1.3.8

Thanks DrByte. Sorry for posting it again but that thread didn't come up in my search results before I posted.

No worries. It was a tough one to find, wasn't it. Not just the post, but the fix to the syntax error too :blush: