Printable View
@lat9Quote:
Originally Posted by lat9
I made an upgrade from bootstrap 3.4.0.
I already tried the reset. No change. I also checked the database and there are no irregularities in the entry for the information sidebox.
I do not want to make a fresh install, because I already applied a lot of my modifications.
OK, I found the error.
For an unknown reason the rights to the folder includes/modules/sideboxes/bootstrap was set to 744 (rwxr--r--). Changing to 755 (rwxr-xr-x) solved the problem.
Sorry for wasting your time with this stupid error.
Thanks for reporting back what the issue was! That wasn't a waste of my time and it lets me and others to make sure that the permissions for any newly-added sub-directories need to be verified.Quote:
Originally Posted by todoonada
ZCA Bootstrap Template - Version: v3.5.0 returns empty entries in Change the Shipping Address at check out.
I've installed this template in Zen-cart version 1.5.7d.
Attachment 20184
Dang it! Change line 51 of /includes/templates/{template_name}/templates/tpl_modules_checkout_address_book.php fromQuote:
Originally Posted by icemint
toCode:$address_details = (zen_get_zcversion() >= '1.5.8') ? $address['address'] : $address->fields;
That'll be corrected in v3.5.1 of the template; thanks for the report.Code:$address_details = (zen_get_zcversion() >= '1.5.8') ? $address['address'] : $address;
GitHub issue: https://github.com/lat9/ZCA-Bootstra...ate/issues/190
I am using a new install of ZC 1.5.8 - PHP 8.1
I added Easy Populate 4.0
Then I added ZCA Bootstrap Template 3.5 plugin
Server info is below.
I made the change to fix the blank page problem for Easy Populate and uploaded products.
Added the Bootstrap template and changed colors and other settings.
At some point I lost the Search box in the very top header. I have a magnifying glass icon but no text box next to it.
Then I tried to use "Products to Categories" in Admin under Catalog and I get a blank page.
I'm also noticing that it seems to take a long time for pages in Admin to load - I have broadband so it isn't my connection.
cPanel Version 102.0 (build 26)
Apache Version 2.4.55
PHP Version 8.1.14
MySQL Version 5.7.23-23
Architecture x86_64
Operating System linux
Perl Version 5.16.3
Kernel Version 4.19.150-76.ELK.el7.x86_64
The bootstrap template doesn't use a search-box next to the icon, you click on the icon and a 'modal' form pops up to enable the search keywords' entry.
For the admin issue, you can install the "Display Logs" plugin that comes with zc158 (Modules :: Plugins) and that will let you see the debug-logs that were generated during the admin access. Please note that that's a separate issue and should be 'reported' on the forums with a brand-new post. If you include the contents of that admin log, be sure to xxx-out the name of your admin directory for security.
Which forum should I use for the 'products to categories' blank page issue? I'm uncertain as to which installation is causing it.Quote:
Originally Posted by lat9
This is the debug log
[21-Jan-2023 18:57:16 America/Boise] PHP Fatal error: Allowed memory size of 536870912 bytes exhausted (tried to allocate 20480 bytes) in /includes/functions/functions_categories.php on line 860
[21-Jan-2023 18:57:16 America/Boise] Request URI: /*****/index.php?cmd=products_to_categories, IP address: 138.84.230.249
--> PHP Fatal error: Allowed memory size of 536870912 bytes exhausted (tried to allocate 20480 bytes) in /includes/functions/functions_categories.php on line 860.
I'll suggest the "General Questions" thread.Quote:
Originally Posted by Barbie
Hi,
I hope I am in the right area to post this question.
I am working on upgrading my cart and everything is going smoothly, the only thing that is driving me slightly mad is the shopping cart update icon Fontawesome now shows up as the button_update_cart.png image.
If I switch back to responsive classic its still the .png image that is showing.
All my other Fontawesome graphics are showing just fine, just not this one.
On zc157d and Bootstrap 3.1.2 the cart update button (fas fa-sync-alt) shows up perfectly and enhanced with css styling.
Is there anyway to get the css button instead of the image.
I have zc158 installed
Bootstrap 4 template
PhP 7.4
Crud, something in the base shopping-cart rendering of that update image changed between zc157 and zc158. The bootstrap template tries to change that image to an FA icon, but somethings' gone amiss.
GitHub tracking issue: https://github.com/lat9/ZCA-Bootstra...ate/issues/192
While you're waiting for v3.5.1 of the template to be released, you can edit /includes/modules/pages/shopping_cart/header_php_shopping_cart_zca_bootstrap.php, changing this sectionQuote:
Originally Posted by lat9
to readCode:for ($i = 0, $n = count($productArray); $i < $n; $i++) {
$productArray[$i]['buttonUpdate'] = preg_replace(
'/(<input type="image".*?\?>)(.*)/', '<button type="submit" class="btn" aria-label="' . ICON_UPDATE_ALT . '" title="' . ICON_UPDATE_ALT . '"><i aria-hidden="true" class="fas fa-sync-alt"></i></button>$2',
$productArray[$i]['buttonUpdate']
);
}
The underlying issue is that zc158 now renders that input without the /> at the end, just a >.Code:for ($i = 0, $n = count($productArray); $i < $n; $i++) {
$productArray[$i]['buttonUpdate'] = preg_replace(
'/(<input type="image".*?\/?>)(.*)/', '<button type="submit" class="btn" aria-label="' . ICON_UPDATE_ALT . '" title="' . ICON_UPDATE_ALT . '"><i aria-hidden="true" class="fas fa-sync-alt"></i></button>$2',
$productArray[$i]['buttonUpdate']
);
}
Thanks Lat9 your solution has restored my sanity, it works a charm. :D
I spent yesterday concentrating on includes/templates/MY_Template/templates/tpl_shopping_cart_default.php, wrongly thinking it must have been the problem.
:cheers:
Hi,
I have found just one more thing, the sold out gif image appears on the products listing and product info pages instead of css.
This only occurs on On zc158 and Bootstrap 4 and didn't occur on zc157d.
To over come this I have modified the following file includes/functions/functions_general.php. and reverted the code to a previous level as below.
I changed this code.
With code from previous version.Code:case ($button_check->fields['products_quantity'] <= 0 and SHOW_PRODUCTS_SOLD_OUT_IMAGE == '1'):
global $template;
$image = BUTTON_IMAGE_SOLD_OUT;
$alt = BUTTON_SOLD_OUT_ALT;
$return_button = '<span class="text-center">' . zen_image($template->get_template_dir($image, DIR_WS_TEMPLATE, $current_page_base, 'buttons/' . $_SESSION['language'] . '/') . $image, $alt, '', '', '') . '</span>';
$zco_notifier->notify('NOTIFY_ZEN_SOLD_OUT_IMAGE', array_merge($button_check->fields, ['products_id' => (int)$product_id]), $return_button);
break;
Don't know weather this is any good, but it works.Code:case ($button_check->fields['products_quantity'] <= 0 and SHOW_PRODUCTS_SOLD_OUT_IMAGE == '1'):
if ($_GET['main_page'] == zen_get_info_page($product_id)) {
$return_button = zen_image_button(BUTTON_IMAGE_SOLD_OUT, BUTTON_SOLD_OUT_ALT);
} else {
$return_button = zen_image_button(BUTTON_IMAGE_SOLD_OUT_SMALL, BUTTON_SOLD_OUT_SMALL_ALT);
}
break;
I'll be updating the template to recognize that new notification for zc158+ and "do the right thing".Quote:
Originally Posted by Valencia
See this GitHub issue for tracking: https://github.com/lat9/ZCA-Bootstra...ate/issues/196
Zencart version 1.58 (Fresh Install)
Template: Bootstrap (cloned)
PHP: 7.4
I think I fixed my issue with paypal pro by grabbing some code on github for paypaldp. However, I still have issues with not being able to pay using a credit card. When I click the CONTINUE button nothing happens.template thinking maybe it may be something with bootstrap. I still get the same issue.
The logs give this message. I have searched on and off this forum and can't find what the problem is.
[24-Jan-2023 01:56:02 America/New_York] Request URI: /xxxxx/ajax.php?act=ajaxPayment&method=prepareConfirmation, IP address: xxx.xxx.xxx.xxx
#1 require_once() called at [/home/xxxxx/public_html/xxxxx/includes/classes/ajax/zcAjaxPayment.php:158]
#2 zcAjaxPayment->prepareConfirmation() called at [/home/xxxxx/public_html/xxxxx/ajax.php:85]
--> PHP Warning: require_once(/home/xxxxx/public_html/xxxxx/includes/languages/english.php): failed to open stream: No such file or directory in /home/xxxxx/public_html/xxxxx/includes/classes/ajax/zcAjaxPayment.php on line 158.
[24-Jan-2023 01:56:02 America/New_York] PHP Fatal error: require_once(): Failed opening required '/home/xxxxx/public_html/xxxxx/includes/languages/english.php' (include_path='.:/opt/cpanel/ea-php74/root/usr/share/pear') in /home/xxxxx/public_html/xxxxx/includes/classes/ajax/zcAjaxPayment.php on line 158
That's a known issue with zc158, which will be corrected on the next release. See this GitHub 'commit' for the change-related details: https://github.com/zencart/zencart/c...a7a5d3d97f9e56Quote:
Originally Posted by printchic
I have already applied this fix but it still got the following message;Quote:
Originally Posted by lat9
"PHP Warning: require_once(/home/xxxxx/public_html/xxxxx/includes/languages/english.php): failed to open stream: No such file or directory in /home/xxxxx/public_html/xxxxx/includes/classes/ajax/zcAjaxPayment.php on line 158."
When I go to that directory "english.php" doesn't exist. Instead it's now called "lang.english.php" however the code is looking for "english.php".
FIX:
I added 'lang.' to the code and it works. I can now click the CONTINUE button when paying by credit card and it takes me to the next page to verify my order details".
The code now looks like this:PHP Code:require_once(zen_get_file_directory(DIR_FS_CATALOG . DIR_WS_LANGUAGES, 'lang.' . $_SESSION['language'].'.php', 'false'));
Is there a way to get a sidebox to show in mobile view?
When using a sidebox for banners for announcements (away/shipping delays etc) it's all fine in desktop view but missing in mobile view.
If not possible is there a way for a wide-banner at the top of the page to not be hidden by the navigation bar? It displays under the footer fine in both desktop and mobile view but is hidden at the top.
Thanks.
Appreciate the report; that wide-banner at the top of each page has been obfuscated by the navigation bar forever!Quote:
Originally Posted by gsh68
GitHub tracking issue: https://github.com/lat9/ZCA-Bootstra...ate/issues/200
v3.5.1 of the ZCA Bootstrap template is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2191
This release contains changes associated with the following GitHub issues:
#188: Remove redundant code from the products_listing module.
#190: Legacy checkout, customer's existing addresses not displayed when changing shipping/billing address.
#192: Use FA glyph instead of image-icon for the update-icon on the shopping_cart page.
#193: Correct non-display of product-delete checkboxes on the shopping_cart page.
#194: Correct display position of product-delete icons/checkboxes on small viewports.
#195: Correct HTML validation error on the shipping-estimator display.
#196: Correct 'sold-outimages displaying as images instead of buttons on zc158. #198: Use zc158 method to ensure T&C checkbox is ticked oncheckout_payment` page.
#200: Correct location of 'Header Position 1' banners, they were overlaid by the navbar.
#201: Correct display of carousel banners' previous/next icons and indicators.
Apparently not yet. I asked a similar question last December about converting a sidebox into a centrebox and viceversa and was advised that such a thing had to be developed. Since then I have not had the time to follow up.Quote:
Originally Posted by gsh68
https://www.zen-cart.com/showthread....61#post1392261
1.5.8 from git
PHP 8.0
Latest bootstrap from git
Partial blank page
Code:[10-Feb-2023 01:53:46 UTC] Request URI: /index.php?main_page=index, IP address: 177.216.199.186, Language id 1#1 require(/includes/templates/frammerdibble/sideboxes/tpl_best_sellers.php) called at [/includes/modules/sideboxes/best_sellers.php:55]
#2 include(/includes/modules/sideboxes/best_sellers.php) called at [/includes/modules/column_right.php:30]
#3 require(/includes/modules/column_right.php) called at [/includes/templates/frammerdibble/common/tpl_main_page.php:250]
#4 require(/includes/templates/frammerdibble/common/tpl_main_page.php) called at [/index.php:94]
--> PHP Warning: Undefined variable $bestsellers_list in /includes/templates/frammerdibble/sideboxes/tpl_best_sellers.php on line 14.
[10-Feb-2023 01:53:46 UTC] PHP Fatal error: Uncaught TypeError: sizeof(): Argument #1 ($value) must be of type Countable|array, null given in /includes/templates/frammerdibble/sideboxes/tpl_best_sellers.php:14
Stack trace:
#0 /includes/modules/sideboxes/best_sellers.php(55): require()
#1 /includes/modules/column_right.php(30): include('/home/frammer...')
#2 /includes/templates/frammerdibble/common/tpl_main_page.php(250): require('/home/frammer...')
#3 /index.php(94): require('/home/frammer...')
#4 {main}
thrown in /includes/templates/frammerdibble/sideboxes/tpl_best_sellers.php on line 14
[10-Feb-2023 01:53:46 UTC] Request URI: /index.php?main_page=index, IP address: 216.177.186.199
--> PHP Fatal error: Uncaught TypeError: sizeof(): Argument #1 ($value) must be of type Countable|array, null given in /includes/templates/frammerdibble/sideboxes/tpl_best_sellers.php:14
Stack trace:
#0 /includes/modules/sideboxes/best_sellers.php(55): require()
#1 /includes/modules/column_right.php(30): include('/home/frammer...')
#2 /includes/templates/frammerdibble/common/tpl_main_page.php(250): require('/home/frammer...')
#3 /index.php(94): require('/home/frammer...')
#4 {main}
thrown in /includes/templates/frammerdibble/sideboxes/tpl_best_sellers.php on line 14.
v3.5.1 of the template no longer covers the top (Header Position 1) banner by the navigation bar.Quote:
Originally Posted by gsh68
What's the site's setting for Minimum Values :: Best Sellers and Maximum Values :: Best Sellers for Box?Quote:
Originally Posted by dbltoe
FWIW, I'm guessing that the Responsive Classic template's going to do the same thing.
The thing with converting a sidebox to a centrebox is that a centrebox-rendering script (/includes/templates/bootstrap/centerboxes) would need to be supplied. That's why @swguy indicated that custom-coding would be needed.Quote:
Originally Posted by dw08gm
What could be done by the base template is to include all active sideboxes in the mobile dropdown menu.
I'm thinking that two new headings' texts (one for the left-sidebox and one for the right-sidebox) would be supplied in the base Bootstrap language file. All active sideboxes in each (other than the information and more_information ones, which stand on their own) would be displayed in a drop-down menu under the associated heading.
If a site didn't want the sidebox to display on mobile, site-specific CSS could be used to hide the information (it'd still be there for Google/Bing to scrape, though).
Would that work as a partial solution?
I would like to see that, but am so tied up at the moment that I can do little more than read and occasionally comment on this matter. So from my side there is no hurry to begin any of this.Quote:
Originally Posted by lat9
I was thinking of a CSS solution using display:none with screen width or other media parameters, but irked at the possibility that perhaps two boxes or the same information could be sent when only one lot should.
Cheers
Yes on the Responsive ClassicQuote:
Originally Posted by lat9
Settings are 0 and 10 respectively.
It's a base Zen Cart issue; see https://github.com/zencart/zencart/issues/5596 for details.Quote:
Originally Posted by dbltoe
Setting the minimum to 1 makes it all better.:yes:
Setting the minimum value to 1 is a work-around.Quote:
Originally Posted by dbltoe
tru dat
Still trying to find what overrides the initial database setting of 1.
Bootstrap 3.5.1
In shopping cart the checkboxes for deleting products are not well aligned.
Attachment 20209
Ifin class .form-check-input in file _forms.scss is deactivated, it looks correctly.Code:position:absolute;
This is a file loaded from bootstrap. So I am looking for a method to display the checkbox correctly and not messing up any other elements.
Darn it. I had an additional plugin installed when testing that expanded the height of the shopping-cart table's rows.Quote:
Originally Posted by todoonada
GitHub tracking issue: https://github.com/lat9/ZCA-Bootstra...ate/issues/203
Update's on GitHub, see this (https://github.com/lat9/ZCA-Bootstra...a71dca59dda5b0) link for changes required.
Thank you!Quote:
Originally Posted by lat9
Looks good now.
And thank you for the confirmation that the update corrected the issue!Quote:
Originally Posted by todoonada
Can't seem to remove the NOTIFICATIONS box on the product page. I've removed it everywhere else but there...ideas?
Attachment 20219
Fresh install: 1.5.8
Latest ZCA Bootstrap Template
That setting's in Configuration :: Bootstrap Template Settings :: Display the Notifications Box on Product Pages; set it to 0.Quote:
Originally Posted by jtlswan
Hi Lat, I think tpl_header.php is missing a <br> on line 165?
<?php
/**
* Common Template - tpl_header.php
*
* BOOTSTRAP v3.5.1
*
*
* @copyright Copyright 2003-2020 Zen Cart Development Team
* @copyright Portions Copyright 2003 osCommerce
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version $Id: DrByte 2020 May 19 Modified in v1.5.7 $
*/
?>
<!--bof-header logo and navigation display-->
<?php
// -----
// Quick return if the header's been disabled.
//
if (!empty($flag_disable_header)) {
return;
}
?>
<div id="headerWrapper" class="mt-5">
<!--bof-navigation display-->
<div id="navMainWrapper">
<div id="navMain">
<nav class="navbar fixed-top mx-3 navbar-expand-lg rounded-bottom" aria-label="<?php echo TEXT_HEADER_ARIA_LABEL_NAVBAR; ?>">
<button class="navbar-toggler" type="button" data-toggle="collapse" data-target="#navbarSupportedContent" aria-controls="navbarSupportedContent" aria-expanded="false" aria-label="Toggle navigation">
<i class="fas fa-bars"></i>
</button>
<div class="collapse navbar-collapse" id="navbarSupportedContent">
<ul class="navbar-nav mr-auto">
<?php
if (!$this_is_home_page) {
?>
<li class="nav-item">
<a class="nav-link" href="<?php echo zen_href_link(FILENAME_DEFAULT); ?>">
<i class="fas fa-home"></i> <?php echo HEADER_TITLE_CATALOG; ?>
</a>
</li>
<?php
}
if (zen_is_logged_in() && !zen_in_guest_checkout()) {
?>
<li class="nav-item">
<a class="nav-link" href="<?php echo zen_href_link(FILENAME_LOGOFF, '', 'SSL'); ?>"><?php echo HEADER_TITLE_LOGOFF; ?></a>
</li>
<li class="nav-item">
<a class="nav-link" href="<?php echo zen_href_link(FILENAME_ACCOUNT, '', 'SSL'); ?>"><?php echo HEADER_TITLE_MY_ACCOUNT; ?></a>
</li>
<?php
} else {
if (STORE_STATUS === '0') {
?>
<li class="nav-item">
<a class="nav-link" href="<?php echo zen_href_link(FILENAME_LOGIN, '', 'SSL'); ?>">
<i class="fas fa-sign-in-alt"></i> <?php echo HEADER_TITLE_LOGIN; ?>
</a>
</li>
<?php
}
}
if ($_SESSION['cart']->count_contents() > 0) {
?>
<li class="nav-item">
<!--<a class="nav-link" href="<?php echo zen_href_link(FILENAME_SHOPPING_CART, '', 'NONSSL'); ?>"><?php echo HEADER_TITLE_CART_CONTENTS; ?></a>
<!--aggiunge icona carrello su header con quantita-->
<a class="nav-link" href="<?php echo zen_href_link(FILENAME_SHOPPING_CART, '', 'NONSSL'); ?>"><?php echo '<i class="fas fa-shopping-cart"></i> ' ?><?php echo $_SESSION['cart']->count_contents(); ?> <?php echo HEADER_TITLE_CART_CONTENTS; ?></a>
</li>
<li class="nav-item">
<a class="nav-link" href="<?php echo zen_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL'); ?>"><?php echo HEADER_TITLE_CHECKOUT; ?></a>
</li>
<?php
}
require $template->get_template_dir('tpl_offcanvas_menu.php', DIR_WS_TEMPLATE, $current_page_base, 'common') . '/tpl_offcanvas_menu.php';
?>
</ul>
<?php
require DIR_WS_MODULES . zen_get_module_sidebox_directory('search_header.php');
?>
</div>
</nav>
</div>
</div>
<!--eof-navigation display-->
<?php
// -----
// Output the div that provides spacing under the navbar. It's set by
// tpl_main_page.php and might be an empty string if it's already been
// output in an active 'Header Position 1' banner.
//
echo $navbar_spacer;
?>
<!--bof-branding display-->
<div id="logoWrapper">
<div id="logo" class="row align-items-center px-3 pb-3">
<?php
$sales_text_class = (HEADER_SALES_TEXT !== '') ? 'col-sm-4' : 'col-sm-12';
?>
<div class="<?php echo $sales_text_class; ?>">
<a href="<?php echo zen_href_link(FILENAME_DEFAULT); ?>" aria-label="<?php echo TEXT_HEADER_ARIA_LABEL_LOGO; ?>">
<?php echo zen_image($template->get_template_dir(HEADER_LOGO_IMAGE, DIR_WS_TEMPLATE, $current_page_base, 'images') . '/' . HEADER_LOGO_IMAGE, HEADER_ALT_TEXT, HEADER_LOGO_WIDTH, HEADER_LOGO_HEIGHT); ?>
</a><br>
</div>
<?php
if ((SHOW_BANNERS_GROUP_SET2 !== '' && $banner = zen_banner_exists('dynamic', SHOW_BANNERS_GROUP_SET2)) || HEADER_SALES_TEXT !== '') {
?>
<div id="taglineWrapper" class="col-sm-6 text-center"> <!--col-sm-6 invece di col-sm-12-->
<?php
if (HEADER_SALES_TEXT !== '') {
?>
<div id="tagline" class="text-center"><?php echo HEADER_SALES_TEXT;?></div>
<?php
}
if (SHOW_BANNERS_GROUP_SET2 !== '' && $banner !== false) {
// -----
// Set variables used by the banner-carousel.
//
$find_banners = zen_build_banners_group(SHOW_BANNERS_GROUP_SET2);
$banner_group = 2;
?>
<div class="zca-banner bannerTwo rounded">
<?php
if (ZCA_ACTIVATE_BANNER_TWO_CAROUSEL === 'true') {
require $template->get_template_dir('tpl_zca_banner_carousel.php', DIR_WS_TEMPLATE, $current_page_base, 'common') . '/tpl_zca_banner_carousel.php';
} else {
echo zen_display_banner('static', $banner);
}
?>
</div>
<?php
}
?>
</div>
<?php
}
// no HEADER_SALES_TEXT or SHOW_BANNERS_GROUP_SET2
?>
</div>
</div>
<!--eof-branding display-->
<?php
// Display all header alerts via messageStack:
if ($messageStack->size('header') > 0) {
echo $messageStack->output('header');
}
if (isset($_GET['error_message']) && zen_not_null($_GET['error_message'])) {
echo zen_output_string_protected(urldecode($_GET['error_message']));
}
if (isset($_GET['info_message']) && zen_not_null($_GET['info_message'])) {
echo zen_output_string_protected($_GET['info_message']);
}
?>
<!--eof-header logo and navigation display-->
<!--bof-optional categories tabs navigation display-->
<?php require $template->get_template_dir('tpl_modules_categories_tabs.php', DIR_WS_TEMPLATE, $current_page_base, 'templates') . '/tpl_modules_categories_tabs.php'; ?>
<!--eof-optional categories tabs navigation display-->
<br>
<!--bof-header ezpage links-->
<?php
if (EZPAGES_STATUS_HEADER === '1' || (EZPAGES_STATUS_HEADER === '2' && zen_is_whitelisted_admin_ip())) {
require $template->get_template_dir('tpl_ezpages_bar_header.php', DIR_WS_TEMPLATE, $current_page_base, 'templates') . '/tpl_ezpages_bar_header.php';
}
?>
<!--eof-header ezpage links-->
</div>
I'm not seeing the need, whether with or without a top banner. A screenshot would help to show what you're seeing.
You are right Lat is better with pictures my English is weak, as you can see on the pictures the logo and the banner go down because the <br> is missing for me.Quote:
Originally Posted by lat9
Attachment 20222
Attachment 20223
Thanks for the picture, that issue is fixed in the forthcoming v3.5.2 of the template where I'd changed the heading structure to more properly display when the upper-header banners are included.
v3.5.2 of the Bootstrap template is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2191
This release contains changes associated with the following GitHub issues:
#203: Correct shopping-cart display when both icon and checkbox is rendered.
#206: Correct heading structure and add landscape for accessibility.
#209: Remove unneeded code from the admin's Tools :: ZCA Bootstrap Colors tool.
#210, #211: Updates to "ZCA Bootstrap Colors" and /css/stylesheet_zca_colors.php to make it easier to add/update colors now and in the future. Refer to the template's wiki (https://github.com/lat9/ZCA-Bootstrap-Template/wiki) for additional information.
#212: Updating/adding various color settings for the "ZCA Bootstrap Colors" tool.
#215: Remove unwanted bootstrap base color classes, so the the "ZCA Bootstrap Colors" control the sections.
#220: Coupon modal pop-up not displaying any text when there are no category-related restrictions.
#221: Correct 'run-on' sentence structure in coupon modal pop-up.
#222: zc158a no longer includes <strong> tags in 3-page checkout guidance language constants.
#223: Coupon modal pop-up creates PHP Warning when coupon has product-related restrictions.
#224: Use FA-5 classes for FA-icons (some were still using FA-4 'syntax').
#226: Correcting header-tag hierarchy and adding labels for accessibility.
#227: Correct notification name for coupon-link update.
Sorry...newbie guy/question here. Do I need to run the .sql file thats located in the /docs/bootstrap/uninstall/bootstrap_colors_uninstall.sql folder in the Install SQL Patches link on the admin site?Quote:
Originally Posted by lat9
Thank you,
JTLS
Looking at the bootstrap_colors_unstall.sql code (a new file for this version) it appears that this is to be used strictly to reset colors for your bootstrap when they get messed up and they do.:P
When we were testing for color contrast compatibility, the process of wiping out all colors and starting over was tedious to say the least. This file will help us a lot.
This file can quickly get rid of alll colors and your next trip to the admin will return all the default colors to their rightful place.
For Lat9, and developer look at this on tpl categories.php found on templates/sidebox I added title= why not get used to doing some SEO?
<?php
/**
* Side Box Template
*
* BOOTSTRAP v3.0.0
*
* @package templateSystem
* @copyright Copyright 2003-2018 Zen Cart Development Team
* @copyright Portions Copyright 2003 osCommerce
* @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
* @version $Id: Drbyte Sun Jan 7 21:28:50 2018 -0500 Modified in v1.5.6 $
*/
$content = '';
$content .= '<div id="' . str_replace('_', '-', $box_id . 'Content') . '" class="list-group-flush sideBoxContent">';
for ($i = 0, $j = count($box_categories_array); $i < $j; $i++) {
switch (true) {
// to make a specific category stand out define a new class in the stylesheet example: A.category-holiday
// uncomment the select below and set the cPath=3 to the cPath= your_categories_id
// many variations of this can be done
// case ($box_categories_array[$i]['path'] == 'cPath=3'):
// $new_style = 'category-holiday';
// break;
case ($box_categories_array[$i]['top'] == 'true'):
$new_style = 'sideboxCategory-top';
break;
case ($box_categories_array[$i]['has_sub_cat']):
$new_style = 'sideboxCategory-subs';
break;
default:
$new_style = 'sideboxCategory-products';
break;
}
if ($box_categories_array[$i]['has_sub_cat']) {
$box_categories_array[$i]['name'] .= CATEGORIES_SEPARATOR;
}
if (zen_get_product_types_to_category($box_categories_array[$i]['path']) == 3 or ($box_categories_array[$i]['top'] != 'true' and SHOW_CATEGORIES_SUBCATEGORIES_ALWAYS != 1)) {
// skip if this is for the document box (==3)
} else {
$content .= '<a class="list-group-item list-group-item-action d-flex justify-content-between align-items-center ' . $new_style . '" href="' . zen_href_link(FILENAME_DEFAULT, $box_categories_array[$i]['path']) . '" title="' . zen_href_link(FILENAME_DEFAULT, $box_categories_array[$i]['path']) . '">';
if ($box_categories_array[$i]['current']) {
if ($box_categories_array[$i]['has_sub_cat']) {
$content .= '<span class="sideboxCategory-subs-parent">' . $box_categories_array[$i]['name'] . '</span>';
} else {
$content .= '<span class="sideboxCategory-subs-selected">' . $box_categories_array[$i]['name'] . '</span>';
}
} else {
$content .= $box_categories_array[$i]['name'];
}
if (SHOW_COUNTS == 'true') {
if ((CATEGORIES_COUNT_ZERO == '1' and $box_categories_array[$i]['count'] == 0) or $box_categories_array[$i]['count'] >= 1) {
$content .= '<span class="badge badge-pill">' . CATEGORIES_COUNT_PREFIX . $box_categories_array[$i]['count'] . CATEGORIES_COUNT_SUFFIX . '</span>';
}
}
$content .= '</a>';
}
}
if (SHOW_CATEGORIES_BOX_SPECIALS == 'true' or SHOW_CATEGORIES_BOX_PRODUCTS_NEW == 'true' or SHOW_CATEGORIES_BOX_FEATURED_PRODUCTS == 'true' or SHOW_CATEGORIES_BOX_PRODUCTS_ALL == 'true') {
// display a separator between categories and links
// if (SHOW_CATEGORIES_SEPARATOR_LINK == '1') {
// $content .= '<hr id="catBoxDivider" />' . "\n";
// }
if (SHOW_CATEGORIES_BOX_SPECIALS == 'true') {
$show_this = $db->Execute("SELECT s.products_id FROM " . TABLE_SPECIALS . " s WHERE s.status= 1 LIMIT 1");
if (!$show_this->EOF) {
$content .= '<a class="list-group-item list-group-item-action list-group-item-secondary" href="' . zen_href_link(FILENAME_SPECIALS) . '" title="' . zen_href_link(FILENAME_SPECIALS) . '">' . CATEGORIES_BOX_HEADING_SPECIALS . '</a>';
}
}
if (SHOW_CATEGORIES_BOX_PRODUCTS_NEW == 'true') {
// display limits
// $display_limit = zen_get_products_new_timelimit();
$display_limit = zen_get_new_date_range();
$show_this = $db->Execute(
"SELECT p.products_id
FROM " . TABLE_PRODUCTS . " p
WHERE p.products_status = 1 " . $display_limit . " LIMIT 1"
);
if (!$show_this->EOF) {
$content .= '<a class="list-group-item list-group-item-action list-group-item-secondary" href="' . zen_href_link(FILENAME_PRODUCTS_NEW) . '" title="' . zen_href_link(FILENAME_PRODUCTS_NEW) . '">' . CATEGORIES_BOX_HEADING_WHATS_NEW . '</a>';
}
}
if (SHOW_CATEGORIES_BOX_FEATURED_PRODUCTS == 'true') {
$show_this = $db->Execute("SELECT products_id FROM " . TABLE_FEATURED . " WHERE status = 1 LIMIT 1");
if (!$show_this->EOF) {
$content .= '<a class="list-group-item list-group-item-action list-group-item-secondary" href="' . zen_href_link(FILENAME_FEATURED_PRODUCTS) . '" title="' . zen_href_link(FILENAME_FEATURED_PRODUCTS) . '">' . CATEGORIES_BOX_HEADING_FEATURED_PRODUCTS . '</a>';
}
}
if (SHOW_CATEGORIES_BOX_PRODUCTS_ALL == 'true') {
$content .= '<a class="list-group-item list-group-item-action list-group-item-secondary" href="' . zen_href_link(FILENAME_PRODUCTS_ALL) . '" title="' . zen_href_link(FILENAME_PRODUCTS_ALL) . '">' . CATEGORIES_BOX_HEADING_PRODUCTS_ALL . '</a>';
}
}
$content .= '</div>';
What new content are you adding?
Quote:
Link Title Attribute Best Practices
You should use a link title when you are providing more information about the link.
Don’t use a link title to provide the information over again, as this is a usability fail that will only result in annoying your users.
Cindy - I think I found an issue with the Bootstrap and the Remember Me plugin.
The plugin puts a "Remember Me" checkbox on the login page. However, due to the input class of the checkbox, the actual checkbox isn't displaying.
The code looks like this:
As you can see in the screenshot, it doesn't display the actual checkbox:Attachment 20248 Attachment 20249Code:<input class="custom-control-input" type="checkbox" name="permLogin" value="1" checked="checked" id="permLogin">
Now, if I manually change the class to anything else, it works. The problem is that I don't know where to change it.
I ASSUME that I need to change it in the observers/class.remember_me_observer.php on this line:
However, I don't know how! I did try to edit that line of code above to say 'id="permLogin" class="testing", but all that did was create a checkbox with the class saying class="custom-control-input testing".Code:zen_draw_checkbox_field('permLogin', '1', $this->checkbox_default, 'id="permLogin"') .
'<label class="checkboxLabel" for="permLogin" title="' . TEXT_REMEMBER_ME_ALT . '">' . TEXT_REMEMBER_ME . '</label>';
The problem is that the checkbox itself won't display with the "custom-control-input" class. Perhaps there's a CSS edit to be made?
Any help is appreciated.
@Jeff_Mash, you'll need to edit /includes/classes/observers/class.remember_me_observer.php. Find this method
and change it to read as follows for compatibility with the bootstrap template:Code:public function create_checkbox()
{
if (!$this->enabled) {
return '';
}
$return_value =
'<br />' .
zen_draw_checkbox_field ('permLogin', '1', $this->checkbox_default, 'id="permLogin"') .
'<label class="checkboxLabel" for="permLogin" title="' . TEXT_REMEMBER_ME_ALT . '">' . TEXT_REMEMBER_ME . '</label>';
return $return_value;
}
.. essentially wrapping the checkbox and its label in a custom_control custom-checkbox div.Code:public function create_checkbox()
{
if (!$this->enabled) {
return '';
}
$return_value =
'<br>' .
'<div class="custom-control custom-checkbox">' .
zen_draw_checkbox_field('permLogin', '1', $this->checkbox_default, 'id="permLogin"') .
'<label class="checkboxLabel" for="permLogin" title="' . TEXT_REMEMBER_ME_ALT . '">' . TEXT_REMEMBER_ME . '</label>' .
'</div>';
return $return_value;
}
That still didn't work, Cindy. Here is a screenshot to show you the Inspect Code. You can see it has the changes you requested (wrapping the text in the custom_control custom-checkbox).......but I cannot get the checkbox to show up unless I somehow change the input class of the zen_draw_checkbox_field () so that it doesn't say "custom-control-input".
Attachment 20250
That image should show the code and the still-hidden checkbox field.
To summarize.........This doesn't work:
But this will work:Code:<div class="custom-control custom-checkbox"><input type="checkbox" name="permLogin" value="1" checked="checked" id="permLogin" class="custom-control-input"><label class="checkboxLabel" for="permLogin" title="Tick this box to be automatically logged in on your next visit. Note: This will place create a cookie in your current browser that can only be read by this website.">Remember me?</label></div>
Is there anyway to change that input class when calling zen_draw_checkbox_field()?Code:<div class="custom-control custom-checkbox"><input type="checkbox" name="permLogin" value="1" checked="checked" id="permLogin" class="LiterallyAnythingElse"><label class="checkboxLabel" for="permLogin" title="Tick this box to be automatically logged in on your next visit. Note: This will place create a cookie in your current browser that can only be read by this website.">Remember me?</label></div>
What version of the template? Running the v3.5.2 on zc158a and enabling the privacy to be displayed on the create-account page, the associated checkbox (er) displays.
I am running 1.5.8a with the latest Bootstrap.
When I enable the privacy box (under Create Account), that checkbox displays just fine. Here's the code:
But for some reason, the checkbox for Remember Me (on the Log In page) doesn't show up. Here is the code:Code:<div class="custom-control custom-checkbox mb-3 mt-2">
<input class="custom-control-input" type="checkbox" name="privacy_conditions" value="1" id="privacy" required=""> <label class="custom-control-label checkboxLabel" for="privacy">I have read and agreed to your privacy statement.</label>
</div>
Here's what I don't understand. I can get the Remember Me checkbox to display if I go to INSPECT the code and manually change the input class="custom-control-input" to say something else (like input class="anythingElse"Code:<div class="custom-control custom-checkbox"><input class="custom-control-input" type="checkbox" name="permLogin" value="1" checked="checked" id="permLogin"><label class="checkboxLabel" for="permLogin" title="Tick this box to be automatically logged in on your next visit. Note: This will place create a cookie in your current browser that can only be read by this website.">Remember me?</label></div>
But this is the exact same input class="custom-control-input" as the Privacy checkbox which does display without any issues.
What do you think the problem could be? If you want to see it, I currently am leacvin
The last sentence in my previous reply was cutoff. I was saying, if you want to see the checkbox on my site, I currently have it enabled here: https://www.mjmmagic.com/store/index...ain_page=login
My bad; you need to add the custom-control-label class to that (er) <label> tag.
I am having difficulty using any other PHP version than the ancient version 5.4
If I select any other version above 5.4 such as 7 all the way to 8.1 my site does not load at all (blank site without any error message)
Zen Cart Version 1.5.6c
In my cPanel I can set the PHP version in this menu:
MultiPHP Manager
System PHP Version
The system default PHP version is set by the system administrator.
Any domain that is set to the inherit value indicates that it does not have its own PHP version explicitly set. Read more about inherit.
Set PHP Version per Domain
Select the domains that you wish to change from the table, then apply a PHP version from the list.
Any help will be appreciated
But WHERE do I add that? This is the code that spits out the checkbox:Quote:
Originally Posted by lat9
As you can see, there is no way to edit the "class value" for the zen_draw_checkbox_field() function in that line of code.Code:'<div class="custom-control custom-checkbox">' .
zen_draw_checkbox_field('permLogin', '1', $this->checkbox_default, 'id="permLogin"') .
'<label class="checkboxLabel" for="permLogin" title="' . TEXT_REMEMBER_ME_ALT . '">' . TEXT_REMEMBER_ME . '</label>' .
'</div>';
Now, I can APPEND a class value to it by doing this:
Then it only appends that class to the existing class like this (which still doesn't work):Code:zen_draw_checkbox_field('permLogin', '1', $this->checkbox_default, 'class="custom-control-label" id="permLogin"')
The only way for it to work seems to be to change wherever zen_draw_checkbox_field() is getting that default "custom-control-input" when it outputs it. Where do we change THAT so that it can be something else?Code:<input type="checkbox" name="permLogin" value="1" checked="checked" class="custom-control-input custom-control-label" id="permLogin">
That's definetely an old version. Have you checked your store/log directory to see what error messages are being written to the log files? That will usually indicate exactly why the screen is blank and help you narrow down the issue.Quote:
Originally Posted by arxvaldex
It's probably some outdated PHP function that is still being used by your older site but has been deprecated in more current versions.
ChangeQuote:
Originally Posted by Jeff_Mash
toCode:'<label class="checkboxLabel" for="permLogin" title="' . TEXT_REMEMBER_ME_ALT . '">' . TEXT_REMEMBER_ME . '</label>' .
Code:'<label class="custom-control-label checkboxLabel" for="permLogin" title="' . TEXT_REMEMBER_ME_ALT . '">' . TEXT_REMEMBER_ME . '</label>' .
Have checked the Store Log the only errors are from AdminNotifications.php but these errors are with a running site on PHP 5.4
I have created an exact duplicate of my setup in another folder and will remove plugins one by one to source which is giving troubles on PHP 8
Thank you much appreciated
New install Zen 1.5.8a, PHP 7.3, Bootstrap 3.5.2, OPC 2.4.5 w/o guest checkout enabled.
Error:
[08-Apr-2023 08:32:23 America/New_York] Request URI: /xxxxx/ajax.php?act=ajaxPayment&method=prepareConfirmation, IP address: 134.215.175.155
--> PHP Parse error: syntax error, unexpected '.' in /home/xxxxx/public_html/xxxxx/includes/templates/bootstrap/templates/tpl_ajax_checkout_confirmation_default.php on line 321.
Broken piece
Code:<div id="checkoutConfirmationDefault-btn-toolbar" class="btn-toolbar justify-content-between confirm-order" role="toolbar">
<?php echo '<strong'> . $title_continue_checkout . '</strong><br>' . TEXT_CONTINUE_CHECKOUT_PROCEDURE; ?>
<?php echo zen_image_submit(BUTTON_IMAGE_CONFIRM_ORDER, BUTTON_CONFIRM_ORDER_ALT, 'name="btn_submit" id="btn_submit"') ;?>
</div>
Error prevents checkout using PayPal Pro
Quote:
Originally Posted by mprough
Move the Quote thus
I have submitted a pull request, but it has not been actioned yet.Code:<div id="checkoutConfirmationDefault-btn-toolbar" class="btn-toolbar justify-content-between confirm-order" role="toolbar">
<?php echo '<strong>' . $title_continue_checkout . '</strong><br>' . TEXT_CONTINUE_CHECKOUT_PROCEDURE; ?>
<?php echo zen_image_submit(BUTTON_IMAGE_CONFIRM_ORDER, BUTTON_CONFIRM_ORDER_ALT, 'name="btn_submit" id="btn_submit"') ;?>
</div>
I know how to fix it =) I was reporting it so Lat could get it resolved
PR has been accepted. I was waiting to see if there are any other issues reported and, if not, I'll get v3.5.3 released this week.Quote:
Originally Posted by mprough
v3.5.3 of the ZCA Bootstrap Template is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2191
This release contains corrections for the following GitHub issues:
#231: Correct PHP Parse error when payment methods "collect credit card data on-site".
#232: Correct PHP Warning logged by shopping_cart template.
#233: Correct products' model alignment on listing pages.
#234: Add language constant added for zc158 that doesn't exist in zc157.
#235: Add missing text 'lead-in' for products' quantity on listing pages.
Not sure if this is bootstrap related, 1.5.8a related, or just something messed up in my settings.
I have a 20% off coupon with restrictions: Only allow on Category A. Category A has one product.
I added that product to my order along with an indifferent item from Category B.
Problem 1: The 20% discount being taken off is MORE than 20%. It's almost like it's factoring in tax or something?
Problem 2: The TOTAL doesn't add up correctly. It's actually shorting me out money since the total should be higher.
This screenshot should help: Attachment 20259
And here is my Coupon Settings which appear to be correct (allowing the 20% discount to only apply to items in that category): Attachment 20260
And here are the settings for the ot_coupon, where I don't have it calculating tax or shipping: Attachment 20261
Can anyone help explain why those two problems are happening?
EDIT: It's definitely related to tax in some way. I did a test with an account that didn't have tax and it calculated fine. So for some reason, the discount is being influenced by the tax, and it's miscalculating the total. Perhaps something to do with the ORDER in which the discount is applied and total is calculated?
In reference to the issue above, I was able to solve Problem #2 (subtotal being incorrect). This is related to the sorting order of the Order Total Modules. If I had the ot_coupon lower than the ot_tax (on the checkout page), then the ot_total was incorrect.
By changing the Sort Order so that ot_coupon was displayed higher (meaning it has a lower sort order value) than the ot_tax, that seems to have corrected the ot_total calculation.
I still cannot figure out WHY problem #1 is still happening: the coupon discount is being affected by something whenever it's used in a region with sales tax, even though I don't have sales tax being factored into my ot_coupon settings.
Man, I'm sorry for all these posts, but I find more information after I post something!Quote:
Originally Posted by Jeff_Mash
So the issue with Problem #1 doesn't seem to be related to tax, because I reproduced it on an order without tax.
Check out this example: Attachment 20262
As you can see, it works fine with the one item (which qualifies for the discount). But when I add a second item which isn't part of the discount category, the 20% value isn't calculated correctly.
Any ideas?
@Jeff_Mash, you need to post these questions in the "Discounts/Coupons" thread, since they're targeted at ot_coupon's misbehaving.
how to install this template?
It's always worth first checking the instructions included with any template or plugin. There is a readme.html file in the docs folder of the downloaded template that will have what you need.Quote:
Originally Posted by ckosloff
I downloaded zip file and uncompressed but don't see any installation instructions.
I would like to use it from now on.
Please post installation instructions or point me in the right direction.
Thank you,
CK
Since you've unzipped the distribution file, you'll see a /docs/bootstrap directory; the readme.html is in there.Quote:
Originally Posted by ckosloff
The ajax_search has a message 'ajaxTimeoutErrorMessage. But it is never defined.
includes\templates\bootstrap\jscript\ajax_search.js line 48
So if there is a timeout the pages seems to hang and the user does not know there has been a timeout.PHP Code:alert(ajaxTimeoutErrorMessage);
If you have the debug consol open, you can see the message "Uncaught ReferenceError: ajaxTimeoutErrorMessage is not defined"
That's not good! :( GitHub issue opened: https://github.com/lat9/ZCA-Bootstra...ate/issues/237Quote:
Originally Posted by brittainmark
I installed template into my test site but could not launch site because got blank page.
I could access the admin but template selector did not show bootstrap.
What I did:
renamed admin folder but did not copy it over, I used my file manager to split screen and opened both admins, then copied the downloaded files into the test site's folder, so I did content to content not folder to folder. Could this be the cause?
I do have a backup of site and could restore it, but it would not have bootstrap
1. If you get a blank page (aka whitescreen), there's a myDEBUG*.log file in the site's /logs directory indicating what the problem is.
2. The bootstrap template doesn't automatically become your site's template, you need to use the admin's Tools :: Template Selection.
3. When copying the files from the distribution, all the files in the /YOUR_ADMIN directory need to be copied to your site's admin directory; all files in the /includes directory need to be copied to your site's /includes directory.
[ZC 1.5.8][Bootstrap 3.5.2]
Back-to-top button is sometimes covering important buttons.
This is may be more of a style question but is there a way to push this button towards outside the main block meanwhile reducing rest of the block size especially on desktop view?
Attachment 20287
Possibly just moving the button will work for you.
You might try putting this in your site specific css file:
This centers the button in the center of the page just above the footer. Should be out of the way of everything and will stay in the center no matter the screen size.Code:#back-to-top {right:50%;}
You may need to adjust the percentage silghtly for mobile portrait to make it centered better.
Adding a currency select dropdown in the footer - works but the list of options shown when you click is quite a way from the cursor position. No idea why. Any ideas?
Attachment 20288
Not without a link to the site.
Have you tried this?Quote:
Originally Posted by zamzom
In your css for the button insert clear:both (if clear:left or clear:right do not work)
https://www.w3schools.com/cssref/pr_class_clear.php
and/or apply margins eg margin-top:1em
https://www.w3schools.com/cssref/pr_margin-top.php
hope this helps
I think that this could be solved via a CSS z-index setting; I'll take a look (eventually).Quote:
Originally Posted by dw08gm
As a suggestion, a template option to disable this button would be nice.
I have removed it from includes/templates/bootstrap/common/tpl_main_page.php on quite a few sites.
This would be more of a feature request, but is there an easy way to have the "Newsletter Subscribe" checkbox also featured on the checkout page?
It would be the same exact code as seen on the Account Creation page, I'd imagine.
Here's why. Since we have guest checkout, we want the opportunity to capture as many newsletter subscribers as possible. These are people who may not create an account, or perhaps may have forgotten that we offer a newsletter after they created their account.
By also displaying the "Subscribe to our Newsletter" box on the checkbox page, it gives us one more opportunity to increase our mailing list since there's more daily orders vs daily account creations.
Could you tell me what code to copy into which file in order to make that one of the boxes? It could look just like it does on the account creation page: https://i.postimg.cc/FHZHXvGH/Electr...Dimensions.png
Quote:
Originally Posted by swguy
I've created GitHub issues to note these requests; they should be included in the next template release.Quote:
Originally Posted by Jeff_Mash
Hi There,
Has anyone had any luck with webp images with bootstrap carousel, I've tried but no success.
Thanks in advance.
Using the carousel ... how? I can't think of a reason why that image type wouldn't work.
my testing code is below
<div id="carouselExampleIndicators" class="carousel slide" data-ride="carousel">
<ol class="carousel-indicators">
<li data-target="#carouselExampleIndicators" data-slide-to="0" class="active"></li>
<li data-target="#carouselExampleIndicators" data-slide-to="1"></li>
<li data-target="#carouselExampleIndicators" data-slide-to="2"></li>
</ol>
<div class="carousel-inner">
<div class="carousel-item active">
<img class="d-block w-100" src="images\banners\Toronto.webp" alt="First slide">
<div class="carousel-caption d-none d-md-block">
<h5>Toronto</h5>
<p>Hello</p>
</div>
</div>
<div class="carousel-item">
<img class="d-block w-100" src="images\banners\PRIME-Header.webp" alt="Second slide">
<div class="carousel-caption d-none d-md-block">
<h5>Fever-Tree</h5>
<p>Mixers</p>
</div>
</div>
<div class="carousel-item">
<img class="d-block w-100" src="images\banners\Essentia.webp" alt="Third slide">
<div class="carousel-caption d-none d-md-block">
<h5>Essentia</h5>
<p>Water</p>
</div>
</div>
</div>
<a class="carousel-control-prev" href="#carouselExampleIndicators" role="button" data-slide="prev">
<span class="carousel-control-prev-icon" aria-hidden="true"></span>
<span class="sr-only">Previous</span>
</a>
<a class="carousel-control-next" href="#carouselExampleIndicators" role="button" data-slide="next">
<span class="carousel-control-next-icon" aria-hidden="true"></span>
<span class="sr-only">Next</span>
</a>
</div>
the webp images not appear but if I use .jpg they do.
What version of Zencart?Quote:
Originally Posted by allmart
Does the browser's dev tools give any clues? Perhaps under the Console or Network tabs.
1.5.7dQuote:
Originally Posted by simon1066
no errors or clues in the dev tools
test site:Quote:
Originally Posted by lat9
https://www.allmart.ca/store/
I don't have a solution to hand but carousel images show in Firefox, not in Chrome or Edge though.Quote:
Originally Posted by allmart
It might be that Chrome's being more picky than Firefox about all those <script></script> and <style></style> elements sprinkled through the header and the slideshow.
The HTML validator (https://validator.w3.org/nu/?doc=htt....ca%2Fstore%2F) has a bunch of 'bad' things to say!
I just discovered that when using webp for any of my images on my test site, they don't appear.Quote:
Originally Posted by simon1066
You might take a look at https://optipic.io/en/webp/zencart/
Suppoasedly, you can keep your png, gif, jpg for those browsers that do not play well with webp but the connection will present the image in webp if the browser is compatible.
Inspecting a .webp image in Chrome dev tools shows a mixture of back and forward slashes in the src path. It seems that Firefox does a better job at resolving this mixture than the other two browsers.
They should all be forward slashes, I suspect this is the way in which they were added to the slider, possibly by copying the relative path from Notepad or such like. I haven't seen the other instances of .webp images throughout the site but hopefully the same is happening there.HTML Code:https://www.allmart.ca/store/images\banners\Toronto.webp
Changed all to forward slashes with no effect.Quote:
Originally Posted by simon1066
Well, the slider images are showing for me in Chrome and Edge now. Perhaps clearing browser cache might help.Quote:
Originally Posted by allmart
Edit: Actually you've reverted the slider images to .jpg (with nivo slider) so scrap the above.
Ok, I think I know the why. Visiting this image in chrome, dev tools shows it as having a type of 'document', it should be 'webp'
Attachment 20296HTML Code:https://www.allmart.ca/store/images/banners/PRIME-Header.webp
So you can rule out the slider plugin. I don't have the answer though, possibly server or .htaccess related.