Super Orders 2.0 - Bug and clarification of Append Comments & Notify Customer
Okay this has been gone over many times before and it's probably best if I go over the wording. Apologies is anyone if taught to suck eggs, but errors with notify have been reported and fixed, but a search for "append" brings up nothing...
In the original "Customers" > "Order", we have two checkboxes, one that says "Notify Customer" and one that says "Append Comments". If neither of the boxes are ticked, then the order history still updates with whatever in the textarea.
The original
- "Notify Customer" means send the customer the change in status email,
- "Append Comments" means add the comments in the textarea to the "change in status email".
At no point does the "Append comments" have anything to do with adding comments to the order history.
With Super Orders 2.0rev46, we have the same type of thing. If one
- unticks "append comments",
- puts something in the text box,
- then the text box writing gets put into the Status History.
If one ticks "notify customers" then it sends the change in status to the customer and it should only send the writing in the textarea to the customer when the "append comments" box is checked.
It doesn't, Super orders 2.0rev46 sends comment by email regardless of the ticking of the box "apend comments" out all of the time (called notify_comments in the PHP/HTML).
In super_orders_functions.php approx line number 447
Code:
if (zen_not_null($status_info->fields['comments']) && $status_info->fields['comments'] != '') {
$notify_comments = EMAIL_TEXT_COMMENTS_UPDATE . $status_info->fields['comments'] . "\n\n";
}
should read
Code:
if (zen_not_null($status_info->fields['comments']) && $status_info->fields['comments'] != '' && $_POST['notify_comments'] == 'on') {
$notify_comments = EMAIL_TEXT_COMMENTS_UPDATE . $status_info->fields['comments'] . "\n\n";
}
currently the customer always gets the information that is written in the textarea if "notify customer" is chosen.
To make things clearer I suggest re-wording the define ENTRY_NOTIFY_COMMENTS to "append comments to notification email"
Thank you
Philip.