Zen Lightbox addon [Support Thread]

PM sent. Just trying to add a background .gif at the top..

First off, thanks for a great mod! It has come a long was since I started using it :smile:

I recently updated Lightbox to 1.5, which went great. However, I am having problems with my 1.38a/1.5 shop as Woody was below:

Quote:

---

Originally Posted by Woodymon

Gems14k:

I'm think we are in agreement. I will use your site as an example of the issue...

The review page which customers will have access to and see (after the review has been approved) does not display the malformed text in the link.

See here:
http://www.nokoria.com/genuine/index...8&reviews_id=2

But the page the review author will observe immediately after submitting the review and the page the customer will see if review has not been approved does indeed show the malformed text for the link.

See here:
http://www.nokoria.com/genuine/index...roducts_id=358

So what I was trying to say is the error impacts product_reviews but does not impact product_reviews_info.

I observe everything behaves/degrades correctly when JavaScript is disabled.

Looking at tpl_modules_main_product_image.php updated for Lightbox/ImageHandler 2:

Code:

---

  <!-- begin zen lightbox v1.3 aclarke 2006-10-20 -->
  <script language="javascript" type="text/javascript"><!--
document.write('<?php echo '<a href="' . zen_image_lightbox_IH2_url($products_image_large, addslashes($products_name), LARGE_IMAGE_WIDTH, LARGE_IMAGE_HEIGHT) . '" rel="lightbox[gallery]" title="' . addslashes($products_name) . '">' . zen_image($products_image_medium, addslashes($products_name), MEDIUM_IMAGE_WIDTH, MEDIUM_IMAGE_HEIGHT) . '<br /><span class="imgLink">' . TEXT_CLICK_TO_ENLARGE . '</span></a>'; ?>');
//--></script>
  <!-- end zen lightbox v1.3 aclarke 2006-10-20 -->

---

Which generates the following HTML on product_reviews page:

Code:

---

  <!-- begin zen lightbox v1.3 aclarke 2006-10-20 -->

  <script language="javascript" type="text/javascript"><!--
document.write('<a href="images/rings/1940RY-RB.jpg" rel="lightbox[gallery]" title="Genuine Ruby Band Ring 14K Yellow Gold<br /><span class=\"smallText\">[1940RY-RB]</span>"><img src="images/rings/1940RY-RB.jpg" alt="Genuine Ruby Band Ring 14K Yellow Gold [1940RY-RB]" title=" Genuine Ruby Band Ring 14K Yellow Gold [1940RY-RB] " width="267" height="225" /><br /><span class="imgLink">zoom</span></a>');

//--></script>
  <!-- end zen lightbox v1.3 aclarke 2006-10-20 -->

---

Note:

Code:

---

<br /><span class=\"smallText\">[1940RY-RB]</span>">

---

Hopefully this leads you in the right direction.

Woody

---

On the main product page, the main image displays properly but on the list of reviews page, I get some of the product's model displayed as HTML just before the image. On the individual review page, it is fine again.

By getting the shop to output the $products_name, I am seeing that the main product page just shows the name, but the review list page adds the model to the end of the name. This seems to choke the Lightbox code and results in the erroneous text being displayed...

Any ideas on how I can fix this?

ta,

Nick :cool:

Hi Nick,

Do you have a link to your website (or even the page in question) please?

If so, post it here (or PM me) and I'll take a look.

Many thanks,

Alex

Hi Alex, thanks for your reply!

I have been banging my head against this all night, and have finally nailed it I think!

The problem page was http://www.knightkit.co.uk/index.php...oducts_id=3027
as that is the only product with a review.

What I reckon was causing it was "includes/modules/page/product_reviews/header_php.php". In that file around line 42, the code adds the product's model number to the product's name. The brackets added during this process then broke the HTML, leading to the ouputted model before the product image!

All sorted now, and I need to rummage back through the thread and let the other couple of folks know how I fixed it :)

Nick

Hi Nick,

Thanks for the update.

This issue was fixed in a previous version. However, I think v1.5 may have broken the fix! :blink:

If you don't mind, could you post your solution (fix) here as it will help others and I may also include it in v1.6.

Cheers,

Alex

Hi Alex, no probs :)

I changed line 42 of "includes/modules/page/product_reviews/header_php.php" from:

Code:

---

if (zen_not_null($review->fields['products_model'])) {
    $products_name = $review->fields['products_name'] . '<br /><span class="smallText">[' . $review->fields['products_model'] . ']</span>';
  } else {
    $products_name = $review->fields['products_name'];
  }

---

to:

Code:

---

{
    $products_name = $review->fields['products_name'];
}

---

Just thought - should I have used an override for this instead?

ta,

Nick

Great contribution thanks!

This is my first time using the lightbox addon and I have noticed that on some computers it does not work with Firefox. I checked the browser version and all of them were updated to the current firefox.

Has anyone else noticed this?

Works fine on my Mac and PC Firefoxes - when you say "it doesn't work", could you be a bit more specific? :smile:

Nick

Sorry for being so vague.

By not working, I mean that the image is greyscaled as well as the background, making it hard to view.

Thanks!

Have you got a screencap we can have a look at please?

Nick