Thanks a lot! I'll do the first patch as suggested and would appreciate it a lot if you continue with the very fine contribution!!!
Printable View
Thanks a lot! I'll do the first patch as suggested and would appreciate it a lot if you continue with the very fine contribution!!!
-NG - I'm running mysql 4.0.27 it seemsQuote:
Originally Posted by NotGoddess
So when I pressed "upgrade" it gave errors. Of course, stupidly I didn't record the errors...
I was upgrading from newsletter subscribe 202
I presume I can force the errors to appear again if I reupload all the admin files?
also, I did the line change above for tpl_unsubscribe_default.php
if I leave the email box blank and press unsubscribe I get re-dired to the login page...is this what was supposed to happen? Just checking :D
thanks!
Well I tried that and no upgrade button appeared...I hope I'm okay :PQuote:
Originally Posted by woodlandsprite
[quote]
also, I did the line change above for tpl_unsubscribe_default.php
if I leave the email box blank and press unsubscribe I get re-dired to the login page...is this what was supposed to happen? Just checking :D
[/quote
well, put it back to the original code, and the same thing happens. I note no difference between the original code vs
Code:
<?php if (empty($unsubscribe_address) || ((!isset($_GET['action']) || ($_GET['action'] != 'unsubscribe')))) { ?>
re: unsubscribe-I'll have to check into it. I may have made a change with the header as well. the redirect is supposed to happen under the 'basic' model because people have to be logged in to unsubscribe *normally*.
re the db errors.
I was probably the 'create table if not exists' syntax. Even tho the manual says this is supported by MySQL 3.23 onward, I've found it shakey at versions lower than 4.1. I guess I'll have to find another way to ensure the table exists (I know of a few but each has it's own drawbacks).
The main alteration of the update was to add the test groups/configuration values/email groups as outlined in the readme. If you have all those, you are okay.
If anyone is hesitant, just wait...I'll work on an alternative tonight/tomorrow and get the patch out on Friday. You can still put in the new files...just don't hit the 'update' button.
-Ng_
btw. Thank you to all who've reported issues...while I in one sense hate getting them :) I need to get any problems fixed asap.
I have found an issue - I am now receiving notices whenever a newsletter only subscrition is created. I have this set to 0 in admin-email options.
(and the email address to send notice to isnt defined - it's sending to my store owner default email)
Possibly a result of my database not updating properly?
:cry: is it too late for me? :P I'll go look at my db and see if I can decipher what is supposed to be there...Quote:
Originally Posted by NotGoddess
I suppose I can attempt a restore of my DB via phpmyadmin...
thank *you* for such a wonderful contrib. I just wish I was more savvy so I could debug too!Quote:
btw. Thank you to all who've reported issues...while I in one sense hate getting them :) I need to get any problems fixed asap.
No, it's not too late :) I just might have a little difficulty helping until late tonight (work). if you want, for now edit modules/pages/subscribe/header_php.php
I found an error that is probably the problem:
At the very bottom you'll see these lines:
change toCode:if(defined('NEWSONLY_SUBSCRIPTION_CC_STATUS') &&
defined('NEWSONLY_SUBSCRIPTION_CC') &&
NEWSONLY_SUBSCRIPTION_CC_STATUS != '') {
...and I changed my mind. I think, given this very very silly error on my part along with another earlier I've proven I shouldn't be doing a release at 2am.Code:if(defined('NEWSONLY_SUBSCRIPTION_CC_STATUS') &&
defined('NEWSONLY_SUBSCRIPTION_CC') &&
NEWSONLY_SUBSCRIPTION_CC_STATUS == 1 &&
NEWSONLY_SUBSCRIPTION_CC != '') {
I'll work on the patch, but will wait until tomorrow night to release so I can do it after a good night's rest. :)
-Ng_
NG - I checked my subscribers table in my db.Quote:
Originally Posted by NotGoddess
The columns I have in there are:
Subscriber ID
customers ID
email address
email format
confirmed
subscribed date
In admin->email options I do have the
-send notice of newsletter subscription only to status (which seems to not be working properly as mine is set to 0 and I am still getting notified of newsletter only subscriptions)
-send notice of newsletter only subscriptions to
-newsletter test group email
Under admin->tools->send email
even tho I have defined a newsletter test group email, there is no such item/address in the dropdown in the email tool.
lolQuote:
Originally Posted by NotGoddess
Boy I know what that's like! when I first started working on my cart, I worked on it until stupid stupid hours....way beyond the point of being productive!
looking forward to the patch :) (and hopefully the news also that my db is complete ;) )
NG:Quote:
Originally Posted by woodlandsprite
I went back, reinstalled my backup version of my database.
The error wasn't with the "if not exists"
The error is as follows:
1146 Table 'dbname.query_builder' doesn't exist in:
[INSERT INTO query_builder (query_category, query_name, query_description, query_string) VALUES ('email,newsletters', 'Email Test Group - Newsletter-only subscribers', 'Returns name and email address of Newsletter-only subscribers designated in Email test group configuration.', 'SELECT s.email_address as customers_email_address FROM TABLE_SUBSCRIBERS as s LEFT JOIN TABLE_CONFIGURATION as q on LOCATE( s.email_address, q.configuration_value) >= 1 WHERE configuration_key = ''NEWSONLY_SUBSCRIPTION_TEST_GROUP'' ') ]
Hope this helps you with the patch :)