Re: Tabbed Products Pro (TPP) Contrib - Official Thread
An example of Google Checkout and Tabbed Products Pro working correctly together is my site. Just click the link in my signature.
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Quote:
Originally Posted by
smile
Kuroi,
Just Curious ..
What in the code analysis of Tabbed Product Pro add-on
gives you concern ?
Best Regards
Ken
Hi Ken
That wasn't a reflection on the quality of the code. It was motivated by concern that it has been extended into areas that feel more the province of core code than a add-on to enhance the product info page.
So all that minification feels like it ought to be a mod in its own right rather than an addendum to the TPP. And the associated html_header changes have the potential to clash with other plugins, several of the free templates and most commercial ones.
On a functional level, I don't like the way that by default the add-to-cart button seems to be hidden inside an inactive tab ... goes against all that we know about e-commerce conversion - but I'm sure that can be changed.
Those are the reasons why I, personally, would hesitate to use it. But equally there will be circumstances and people for whom it's a good approach.
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Thank you very much!
Quote:
Originally Posted by
Get Em Fast
An example of Google Checkout and Tabbed Products Pro working correctly together is my site. Just click the link in my signature.
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Quote:
Originally Posted by
DivaVocals
All of my clients have the additional images tabs turned on and additional images only display in the tab once I turn the tab on and in the default location if the tab is off..
You're seeing them in two places if I understand correctly??
Yeah, I finally removed them from the product info template itself. The review button does the same thing.
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Quote:
Originally Posted by
dkerfoot
While I mentioned that I had recently upgraded to 1.3.9 in the first post - trying to answer the long list of questions we are prompted to answer for clarity dontcha know - it was actually working fine for two days after the upgrade - GCO and all, before I installed TPP. Then GCO stopped working the moment TPP was installed.
Then, a few weeks later, on a fully upgraded and perfectly working separate install, installing TPP again broke GCO.
While your logic clearly seems impeccable in your own mind, it is unfortunate that you are continuing to ignore empirical evidence - i.e.: every time I install the mod it breaks GCO.
You seem unable to conceive of the idea that GCO was working up to and until TPP was installed. Do you get that? GCO was working. Then TPP broke it. TPP broke GCO. GCO was working, then TPP broke it. Got it?
Twice. Same results. GCO worked - TPP broke it. Twice. Are you with me now?
And yes, I can play with colors and font sizes too, aren't you impressed?
Hmm, well getting nasty sure doesn't help anything. The only thing that proves is that something went wrong with your installation - not that the two can't work together.
What you observed on simonbbc.com is also a scrabbled together googlecheckout that was put in long before the tabbed products was. He has a special situation with his shipping quotes which required changes. Installing tabbed products did not change the google checkout.
The google checkout button in the cart pops up the estimator and then you have to click on the button in the estimator to get to googlecheckout. Convoluted and not what anyone wants but there again - this is a google checkout question -
not a tabbed products question. I know you won't get answers in the googlecheckout thread but this is not the place for your questions.
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Quote:
Originally Posted by
delia
Yeah, I finally removed them from the product info template itself. The review button does the same thing.
Somewhere in this thread is a post by me on how to remove the "double" review buttons. The original author for some reason didn't think this was an "issue".. I thought it just looks DUMB to have two review buttons.. If you don't find my post, I'll see if I can dig it up..
Quote:
Originally Posted by
kuroi
Hi Ken
That wasn't a reflection on the quality of the code. It was motivated by concern that it has been extended into areas that feel more the province of core code than a add-on to enhance the product info page.
So all that minification feels like it ought to be a mod in its own right rather than an addendum to the TPP. And the associated html_header changes have the potential to clash with other plugins, several of the free templates and most commercial ones.
Nods in agreement.. I never understood how the addition of the minification functionality enhanced TPP either..
The introduction of this "feature" in v1.06 always felt to me like this was not as much of an enhancement of TPP as it was simply just adding in something that SHOULD HAVE been a separate add-on submission in it's own right..
It was at the point that this change was made (the introduction of the minification add-on to TPP) that the original author stopped supporting this module.. TPP has been community supported ever since.
I personally still use version 1.05 because it still works, and if I WANT/NEED js/css minification I can install the CJ Loader SEPARATELY.
Quote:
Originally Posted by
kuroi
On a functional level, I don't like the way that by default the add-to-cart button seems to be hidden inside an inactive tab ... goes against all that we know about e-commerce conversion - but I'm sure that can be changed.
Those are the reasons why I, personally, would hesitate to use it. But equally there will be circumstances and people for whom it's a good approach.
While I too found the "Global Add To Cart Tab" option :lookaroun ummmm silly, it is not turned on by default. Rather it is one of the tab options this mod offers.. As you can see on the following page, the add to cart button is not inside a tab..
http: // hairisle . com /Less-Than-Perfect/Processed-Wefts/Indian-Remy-Machine-Weft-Relaxed-Texture-4-Oz.
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Quote:
Originally Posted by
DivaVocals
Somewhere in this thread is a post by me on how to remove the "double" review buttons. The original author for some reason didn't think this was an "issue".. I thought it just looks DUMB to have two review buttons.. If you don't find my post, I'll see if I can dig it up..
Nah, I left it - since he wanted the tell a friend button left on, I just put the two buttons side by side down there. Not as distracting as the additional images. Just info to keep in my head as to what to do if and when I run into this again. Geez, zen cart respository in my head!
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Quote:
Originally Posted by
delia
Nah, I left it - since he wanted the tell a friend button left on, I just put the two buttons side by side down there. Not as distracting as the additional images. Just info to keep in my head as to what to do if and when I run into this again
Well my client INSISTED that it had to go (and I kinda agreed) So I HAD to "make it go away"!!:laugh:
Quote:
Originally Posted by
delia
Geez, zen cart respository in my head!
:laugh::laugh: This is why you are the WOman!!!:smile:
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Kuroi,
Thanks for the reply .
Thanks for your effort.
Thanks for your insight.
Best regards
Ken
Re: Tabbed Products Pro (TPP) Contrib - Official Thread