Re: Winchester Responsive
Quote:
Originally Posted by
rbarbour
The reason it was not working is because it was looking for a $_SESSION on page load which did not exist, I fixed that!
Now the php-detect class renders the proper responsive files on page load and YES, sets the $_SESSION after a link is clicked.
My fix will be added to the update of the DIY Responsive Template Default for v1.5.x package, Anne may use or choose to go your route or any other as she sees fit. Just looking at what you provided, I'm sure it works but have not tested.
Got it. Just wanted to mention the fix in case anyone was developing a site and depended on the switches to test the layouts. Just did not want anyone to waste their development time to only find out later they were not modifying the correct files.
A note to Anne is that the fix you implemented has not solved the switches. The demo site looks like it is using the updated version you submitted, but if you were to use the switches on the homepage, it will not work. The files being pulled are static. If you don't have the fix from rbarour, you can use the workaround I posted above by including the session is blank and it will now allow the switches to change display. I have tested it this and works fine.
And your templates are top notch that is very user friendly for customers and shop owners.
Re: Winchester Responsive
The code below from post #115 is correct, works as intended and should be the ONLY code used. Using alternate code will only make future template upgrades that more difficult.
I personally updated the php-mobile-detect code within the html_header.php file of this DEMO first time around and did not inform Anne it should also be replaced in any file she used the php-mobile-detect code to call device specific code, my apologies.
I have just updated the rest of this DEMOS php-mobile-detect code and tested. I am confident that as soon as time permits, Anne will resubmit!
Again, my apologies.
Anne, my hat is off to you, this template is truly a masterpiece and most definitely the next generation of Zen Cart responsive templates.
Code:
if ($detect->isMobile() && !$detect->isTablet() or $detect->isMobile() && !$detect->isTablet() && $_SESSION['display_mode']=='isMobile' or $detect->isTablet() && $_SESSION['display_mode']=='isMobile' or $_SESSION['display_mode']=='isMobile') {
echo $responsive_mobile;
} else if ($detect->isTablet() or $detect->isMobile() && $_SESSION['display_mode']=='isTablet' or $detect->isTablet() && $_SESSION['display_mode']=='isTablet' or $_SESSION['display_mode']=='isTablet'){
echo $responsive_tablet;
} else if ($detect->isMobile() && !$detect->isTablet() && $_SESSION['display_mode']=='isDesktop' or $detect->isTablet() && $_SESSION['display_mode']=='isDesktop' or $_SESSION['display_mode']=='isNonResponsive'){
echo '';
} else {
echo $responsive_default;
}
Re: Winchester Responsive
Quote:
Originally Posted by
rbarbour
The code below from post #115 is correct, works as intended and should be the ONLY code used. Using alternate code will only make future template upgrades that more difficult.
I personally updated the php-mobile-detect code within the html_header.php file of this DEMO first time around and did not inform Anne it should also be replaced in any file she used the php-mobile-detect code to call device specific code, my apologies.
I have just updated the rest of this DEMOS php-mobile-detect code and tested. I am confident that as soon as time permits, Anne will resubmit!
Again, my apologies.
Anne, my hat is off to you, this template is truly a masterpiece and most definitely the next generation of Zen Cart responsive templates.
Code:
if ($detect->isMobile() && !$detect->isTablet() or $detect->isMobile() && !$detect->isTablet() && $_SESSION['display_mode']=='isMobile' or $detect->isTablet() && $_SESSION['display_mode']=='isMobile' or $_SESSION['display_mode']=='isMobile') {
echo $responsive_mobile;
} else if ($detect->isTablet() or $detect->isMobile() && $_SESSION['display_mode']=='isTablet' or $detect->isTablet() && $_SESSION['display_mode']=='isTablet' or $_SESSION['display_mode']=='isTablet'){
echo $responsive_tablet;
} else if ($detect->isMobile() && !$detect->isTablet() && $_SESSION['display_mode']=='isDesktop' or $detect->isTablet() && $_SESSION['display_mode']=='isDesktop' or $_SESSION['display_mode']=='isNonResponsive'){
echo '';
} else {
echo $responsive_default;
}
rbarbour, thank you so much for your help with this! The php mobile detect should be working 100% now thanks to the edits made by rbarbour :smile:
I am in the process of packaging up all of the changes and other found bugs and will be submitting an update later today.
Thanks,
Anne
Re: Winchester Responsive
Quote:
Originally Posted by
picaflor-azul
I am in the process of packaging up all of the changes and other found bugs and will be submitting an update later today.
If it's not too late, may I suggest a small addition.. in the "includes/templates/winchester_responsive/templates/tpl_modules_mobile_categories_tabs.php" file add an admin control for turning the EZ Pages menu item on or off.. Not adding pages to the menu is not enough to stop the dropdown from appearing..
Code:
<?php if (SHOW_EZ_PAGES_MENU == 'true') { ?>
<li><a href="#"><?php echo TITLE_EZ_PAGES; ?></a>
<ul>
<?php require(DIR_WS_MODULES . 'sideboxes/' . $template_dir . '/' . 'ezpages_drop_menu.php'); ?>
</ul>
</li>
<?php } ?>
Re: Winchester Responsive
Quote:
Originally Posted by
DivaVocals
If it's not too late, may I suggest a small addition.. in the "includes/templates/winchester_responsive/templates/tpl_modules_mobile_categories_tabs.php" file add an admin control for turning the EZ Pages menu item on or off.. Not adding pages to the menu is not enough to stop the dropdown from appearing..
Code:
<?php if (SHOW_EZ_PAGES_MENU == 'true') { ?>
<li><a href="#"><?php echo TITLE_EZ_PAGES; ?></a>
<ul>
<?php require(DIR_WS_MODULES . 'sideboxes/' . $template_dir . '/' . 'ezpages_drop_menu.php'); ?>
</ul>
</li>
<?php } ?>
Ok, I will take a look at this, thank you for the suggestion. I will also be fixing the mobile menu (I hope ;) before submitting the update.
Thanks,
Anne
Re: Winchester Responsive
Quote:
Originally Posted by
DivaVocals
If it's not too late, may I suggest a small addition.. in the "includes/templates/winchester_responsive/templates/tpl_modules_mobile_categories_tabs.php" file add an admin control for turning the EZ Pages menu item on or off.. Not adding pages to the menu is not enough to stop the dropdown from appearing..
Code:
<?php if (SHOW_EZ_PAGES_MENU == 'true') { ?>
<li><a href="#"><?php echo TITLE_EZ_PAGES; ?></a>
<ul>
<?php require(DIR_WS_MODULES . 'sideboxes/' . $template_dir . '/' . 'ezpages_drop_menu.php'); ?>
</ul>
</li>
<?php } ?>
I tried to incorporate this switch, adding the constant to the database and it does turn on and off the ezpages in the header menu, but when turned on it is not showing the ezpages marked as on in the header with a sort order.
Thanks,
Anne
Re: Winchester Responsive
Quote:
Originally Posted by
picaflor-azul
I tried to incorporate this switch, adding the constant to the database and it does turn on and off the ezpages in the header menu, but when turned on it is not showing the ezpages marked as on in the header with a sort order.
Thanks,
Anne
Disregard this post, I think I have it working now ;)
Thanks,
Anne
Re: Winchester Responsive
Quote:
Originally Posted by
picaflor-azul
Disregard this post, I think I have it working now ;)
Thanks,
Anne
Cool!!!:clap:
Re: Winchester Responsive
I just submitted an update with these changes:
05/27/2014------Added admin control for turning the EZ Pages menu item on or off in includes/templates/winchester_responsive/templates/tpl_modules_mobile_categories_tabs.php
05/27/2014------Added includes/templates/winchester_responsive/css/responsive.css div#mobile-nav1.hidenav1 {display:none;}
05/27/2014------Fixed class "onerow-fluids" includes/templates/winchester_responsive/common/tpl_footer.php, includes/templates/winchester_responsive/common/tpl_header.php, includes/templates/winchester_responsive/common/tpl_header_mobile.php, includes/templates/winchester_responsive/common/tpl_header_tablet.php, includes/templates/winchester_responsive/common/tpl_main_page.php
05/27/2014------Added code to exclude main image and additional image popups from being responsive /includes/templates/winchester_responsive/common/html_header.php
05/27/2014------Fixed php mobile detect script includes/templates/winchester_responsive/templates/tpl_modules_mobile_categories_tabs.php
05/27/2014------Fixed php mobile detect script includes/templates/winchester_responsive/common/tpl_main_page.php
Thanks,
Anne
1 Attachment(s)
Re: Winchester Responsive
hi... i want copy only header from (westmister_new) to this template please help .. i want add this header to this template Attachment 14149 (this header From westmister_new template )
