Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Quote:
Originally Posted by
Gerjan
Don't forget your own sig;
"Nothing is impossible, as long as you're willing to try, make mistakes, and learn." :wink: :thumbsup:
:D:P:D I know, and that is why i am still trying.
Maybe a litle update is in place
I removed the integrated minify from this project, in favour over the new minify from numinix, which was updated to work with zen cart 1.5
I have TPP working, but for some reason it won't read the database values for the tabs, so it only shows the default settings. So there is some progress :wink:
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Quote:
Originally Posted by
Design75
I do not know why this error happens, because I never used the integrated minify, but always the stand alone version, and therefore do not if there are any differences.
Hello Design75 and thanks for your reply much appreciated.
When you say you are running the standalone version do you mean you are running version 1.05 of TPP or something else?
Quote:
Originally Posted by
Design75
Which version of Zen Cart are you running?
Currently using version 1.3.9h as I am waiting on a number of mods to be updated including this one before I upgrade to 1.5 plus I'm using a custom template which will need to be upgraded as well and that might take some time :(.
Quote:
Originally Posted by
Design75
You could turn minify off in your admin, and see if the error is still occurring
:oops:
Thanks I didn't think of that... but that doesn't surprise with all the work I have been doing to the site of late and by turning off minify it stopped the errors from happening.
:clap:
But would still like to know what is causing them if anyone has any ideas. Mainly because I am the kind of person who likes to know how everything works. I remember pulling my brothers antique grand father clock apart when I was a kid... sadly I never was able to get it back together again. So I put all the parts behind the clocks door hoping he would not notice. But he did....
Quote:
Originally Posted by
Design75
Currently. i am trying to make TPP work properly in Zen Cart 1.5 in my spare time, but so far with little luck. :censored:
Yes it surely would be a worthy edition to get it compatible with ZenCart 1.5. I only wish I had more time to learn about PHP and CSS myself so you are one up on me. I have a good understanding of HTML but sadly I don't know much about PHP and CSS. Have been thinking of going to TAFE and seeing if there is some courses for me to learn it.
Thanks again for taking the time to reply!
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
CybaGirl,
I am runing 1.07 but removed the integrated minify because i am also running FEC, which also uses minify and I installd the stand aloen version from Rubiks, found here: https://github.com/yellow1912/cjloader
You could do some comparing and find out what the differences are. I know there are some big differences in the file called browser.php (this could also be the solution for your error.
Love your clock story, reminds me a lot of my own youth I also used to "de construct" everything in the house. :laugh:
As for the new version of TPP, I had a breakthrough this morning and the database values are being read now. The last thing to do is to let TPP find the css file, in the tpp folder, and rewrite the sql files and the readme.
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Please tell me you are removing that minify program that got bundled in for no particular purpose to TPP.. IMHO, the author of CJ Loader should have simply submitted that CJ Loader "addition" as it's OWN add-on versus slapping it arbitrarily into TPP.. it really NEVER should have been added to TPP the way it was..
Quote:
Originally Posted by
Design75
CybaGirl,
I am runing 1.07 but removed the integrated minify because i am also running FEC, which also uses minify and I installd the stand aloen version from Rubiks, found here:
https://github.com/yellow1912/cjloader
You could do some comparing and find out what the differences are. I know there are some big differences in the file called browser.php (this could also be the solution for your error.
Love your clock story, reminds me a lot of my own youth I also used to "de construct" everything in the house. :laugh:
As for the new version of TPP, I had a breakthrough this morning and the database values are being read now. The last thing to do is to let TPP find the css file, in the tpp folder, and rewrite the sql files and the readme.
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Yes I kicked out the minify files, and it has to be downloaded as a separate module again.
Or do you mean to remove the autoloader function also ???
I finally have tpp working, and I must admit it was very simple. :blush: I almost don't dare to tell this, but I simply forgot to copy some files :blush::frusty::blush::blush::oops:
So now all that's left is to update the readme and resubmit the addon, unless there are some last minute requests.
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
OK it's official I now have a headache after ZenCarting for over twelve hours today according to my Cuckoo Clock and I still haven't completed everything I wanted to. :(
So please excuse my ignorance or tiredness should I say... but may I ask what you did to remove the integrated minify in v1.07? Or should I just uninstall v1.07 (and hope that something doesn't break :D) and install v1.05... or should I just go to bed and forget about the whole thing :laugh: ....
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Quote:
Originally Posted by
Design75
I finally have tpp working, and I must admit it was very simple. :blush: I almost don't dare to tell this, but I simply forgot to copy some files :blush:
:clap::clap::clap:
This is awesome news and it makes me want to stay up even longer even though I really should be going to bed and getting some sleep :laugh: .
Quote:
Originally Posted by
Design75
So now all that's left is to update the readme and resubmit the addon, unless there are some last minute requests.
One question though. Did you manage to get the sub tags to work? As I could never get them to work on v1.07 for some reason.
Once again thanks so very much for all your work on this!
:smartalec:
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
You should probably go to sleep first :yes: After that you have a clear mind. It always helps me.
The sub tags work fine for me.
For the 1.5 version, don't stay up, because it may not be until it is available in the downloads section.
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Quote:
Originally Posted by
Design75
Yes I kicked out the minify files, and it has to be downloaded as a separate module again.
Or do you mean to remove the autoloader function also ???
I finally have tpp working, and I must admit it was very simple. :blush: I almost don't dare to tell this, but I simply forgot to copy some files :blush::frusty::blush:
So now all that's left is to update the readme and resubmit the addon, unless there are some last minute requests.
I meant the CJ Loader minify application that was added ARBITRARILY to TPP starting with v1.06. The addition of the CJ Loader app in my opinion has added NO VALUE to TPP and it has been a CONSISTENT source of install issues since it's introduction to TPP and needs to be KICKED TO THE CURB!!:laugh::laugh: The CJ Loader author should have submitted it as a separate add-on and not tacked it on to the TPP add-on.. (seemed somewhat self serving IHMO to do this - YEP I said it!!!:shocking:)
Kuroi summed this up best here:
Quote:
Originally Posted by
kuroi
Hi Ken
That wasn't a reflection on the quality of the code. It was motivated by concern that it has been extended into areas that feel more the province of core code than a add-on to enhance the product info page.
So all that minification feels like it ought to be a mod in its own right rather than an addendum to the TPP. And the associated html_header changes have the potential to clash with other plugins, several of the free templates and most commercial ones.
On a functional level, I don't like the way that by default the add-to-cart button seems to be hidden inside an inactive tab ... goes against all that we know about e-commerce conversion - but I'm sure that can be changed.
Those are the reasons why I, personally, would hesitate to use it. But equally there will be circumstances and people for whom it's a good approach.
Re: Tabbed Products Pro (TPP) Contrib - Official Thread
Quote:
Originally Posted by
CybaGirl
When you say you are running the standalone version do you mean you are running version 1.05 of TPP or something else?
He means DO NOT use the files/folders in the "min" folder included with the add-on, and undo the SQL changes from the "cj_loader_install.sql" file. This is all part of that CJ Loader add-on that was SHOVED into TPP starting with v1.06. I SHOULD have kicked it to the curb when I submitted v1.07...