MSRP contrib

I just installed this mod and it works fine except that it DOES NOT display the prices correctly.

It has something to do with:
TEXT_PRODUCT_MSRP
TEXT_PRODUCT_SAVE
TEXT_PRODUCT_OUR

in the includes/functions/functions_prices.php file.

because they show up in the storefront instead of what should be there!

I looked this up in the developers took kit and this is what it came up with:

Code:

---

Line #297 : $final_display_price = '<span class="smalltext1"><s>'.TEXT_PRODUCT_MSRP.$currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</s></span><br><span class="save">'.TEXT_PRODUCT_SAVE.$currencies->display_price($save, '').'&nbsp;&nbsp;('. number_format((($display_msrp_price - $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)'.'</span><br><span class="norm">'.TEXT_PRODUCT_OUR.$show_special_price . $show_sale_price . $show_sale_discount.'</span>' ;

Line #304 : $final_display_price = '<span class="smalltext1"><s>'.TEXT_PRODUCT_MSRP.$currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</s></span><br><span class="save">'.TEXT_PRODUCT_SAVE.$currencies->display_price($save, '').'&nbsp;&nbsp;('. number_format((($display_msrp_price - $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)'.'</span><br><span class="norm">'.TEXT_PRODUCT_OUR.$show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount.'</span>' ;

---

Can someone point out what I am missing?

Simple fix, I reviewed the files I uploaded and I missed one, done!

Does anyone know how to switch the display order?

For example, instead of:
List Price
You Save
Our Price

==========
List Price
Our Price
You Save

Quote:

---

Originally Posted by autoace

Does anyone know how to switch the display order?

For example, instead of:
List Price
You Save
Our Price

==========
List Price
Our Price
You Save

---

Yes. In the file ./includes/functions/functions_prices.php between line 295 and 309 (line numbers might not be exact, but close enough) you'll find the following code:

Code:

---

      // don't show the $0.00
          if(($display_msrp_price!='')&&($display_msrp_price!='0')){
          $save=$display_msrp_price-$display_normal_price;
              $final_display_price = '<span class="smalltext1"><s>'.TEXT_PRODUCT_MSRP.$currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</s></span><br><span class="save">'.TEXT_PRODUCT_SAVE .$currencies->display_price($save, '').'&nbsp;&nbsp;('. number_format((($display_msrp_price -  $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)'.'</span><br><span class="norm">'.TEXT_PRODUCT_OUR.$show_special_price . $show_sale_price . $show_sale_discount.'</span>' ;
          }else{
                  $final_display_price = $show_special_price . $show_sale_price . $show_sale_discount;
          }
    } else {
        if(($display_msrp_price!='')&&($display_msrp_price!='0')){
        $save=$display_msrp_price-$display_normal_price;
              $final_display_price = '<span class="smalltext1"><s>'.TEXT_PRODUCT_MSRP.$currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</s></span><br><span class="save">'.TEXT_PRODUCT_SAVE .$currencies->display_price($save, '').'&nbsp;&nbsp;('. number_format((($display_msrp_price -  $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)'.'</span><br><span class="norm">'.TEXT_PRODUCT_OUR.$show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount.'</span>' ;
          }else{
                  $final_display_price = $show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount;
          }
    }

---

You see the entries TEXT_PRODUCT_SAVE and TEXT_PRODUCT_OUR, you'll need to rearrange the functions into the order you want.

Here's the code I put in place:

Code:

---

      // don't show the $0.00
          if(($display_msrp_price!='')&&($display_msrp_price!='0')){
          $save=$display_msrp_price-$display_normal_price;
              $final_display_price = '<span class="smalltext1"><s>'.TEXT_PRODUCT_MSRP.$currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</s></span><br><span class="norm">'.TEXT_PRODUCT_OUR.$show_special_price . $show_sale_price . $show_sale_discount.'</span><BR><span class="save">'.TEXT_PRODUCT_SAVE .$currencies->display_price($save, '').'&nbsp;&nbsp;('. number_format((($display_msrp_price -  $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)'.'</span>' ;
          }else{
                  $final_display_price = $show_special_price . $show_sale_price . $show_sale_discount;
          }
    } else {
        if(($display_msrp_price!='')&&($display_msrp_price!='0')){
        $save=$display_msrp_price-$display_normal_price;
              $final_display_price = '<span class="smalltext1"><s>'.TEXT_PRODUCT_MSRP.$currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</s></span><br><span class="norm">'.TEXT_PRODUCT_OUR.$show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount.'</span><BR><span class="save">'.TEXT_PRODUCT_SAVE .$currencies->display_price($save, '').'&nbsp;&nbsp;('. number_format((($display_msrp_price -  $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)'.'</span>' ;
          }else{
                  $final_display_price = $show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount;
          }
    }

---

The key is the contents between the <span></span> tags.

Additionally I added a font size tag (yeah I know depreciated but it works) and an extra <BR> tag to get, in my opinion, a better flow to the price block.

Now looks like this:

Quote:

---

ACU Coat

Starting at:
Retail Price: $44.99
Our Price: $34.99
You save: $10.00 (22%)
Report a cheaper price seen elsewhere
You earn 34 reward points

---

The <BR> tag was inserted on line 298 after $final_display_price = '<BR> and again on line 305 after $final_display_price = '<BR>


That dropped the prices after the "Starting at:".

I also added a <font size=2> on line 298 before the <span class="save">' and a </font> at the end of line 298 before the ';

I did this again on line 305.

Those changes just make the whole block look a lot cleaner in my opinion.

These changes also carry over to the product listing as well since it was done in the functions code rather than the layout template.


Anyhoo, I hope all this and the above posted rambling works out.

Thanks for the idea too, it looks much more logical!! :clap:

i just installed msrp and now im getting this when i go into the admin console. The msrp is working on the front end though. Any ideas?

Fatal error: Cannot redeclare zen_update_products_price_sorter() (previously declared in D:\Hosting\5493129\html\admin\includes\functions\general.php:2517) in D:\Hosting\5493129\html\admin\includes\functions\functions_prices.php on line 1378

D:\Hosting\5493129\html\admin\includes\functions\general.php:2517

Doesn't sound right. Looks like you might have a path error.

I got it figured out. I just copied in a new functions_prices.php and its working again.
Thanks

Quote:

---

Originally Posted by sonjamichelle

Yes. In the file ./includes/functions/functions_prices.php between line 295 and 309 (line numbers might not be exact, but close enough) you'll find the following code:

Code:

---

      // don't show the $0.00
          if(($display_msrp_price!='')&&($display_msrp_price!='0')){
          $save=$display_msrp_price-$display_normal_price;
              $final_display_price = '<span class="smalltext1"><s>'.TEXT_PRODUCT_MSRP.$currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</s></span><br><span class="save">'.TEXT_PRODUCT_SAVE .$currencies->display_price($save, '').'&nbsp;&nbsp;('. number_format((($display_msrp_price -  $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)'.'</span><br><span class="norm">'.TEXT_PRODUCT_OUR.$show_special_price . $show_sale_price . $show_sale_discount.'</span>' ;
          }else{
                  $final_display_price = $show_special_price . $show_sale_price . $show_sale_discount;
          }
    } else {
        if(($display_msrp_price!='')&&($display_msrp_price!='0')){
        $save=$display_msrp_price-$display_normal_price;
              $final_display_price = '<span class="smalltext1"><s>'.TEXT_PRODUCT_MSRP.$currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</s></span><br><span class="save">'.TEXT_PRODUCT_SAVE .$currencies->display_price($save, '').'&nbsp;&nbsp;('. number_format((($display_msrp_price -  $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)'.'</span><br><span class="norm">'.TEXT_PRODUCT_OUR.$show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount.'</span>' ;
          }else{
                  $final_display_price = $show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount;
          }
    }

---

You see the entries TEXT_PRODUCT_SAVE and TEXT_PRODUCT_OUR, you'll need to rearrange the functions into the order you want.

Here's the code I put in place:

Code:

---

      // don't show the $0.00
          if(($display_msrp_price!='')&&($display_msrp_price!='0')){
          $save=$display_msrp_price-$display_normal_price;
              $final_display_price = '<span class="smalltext1"><s>'.TEXT_PRODUCT_MSRP.$currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</s></span><br><span class="norm">'.TEXT_PRODUCT_OUR.$show_special_price . $show_sale_price . $show_sale_discount.'</span><BR><span class="save">'.TEXT_PRODUCT_SAVE .$currencies->display_price($save, '').'&nbsp;&nbsp;('. number_format((($display_msrp_price -  $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)'.'</span>' ;
          }else{
                  $final_display_price = $show_special_price . $show_sale_price . $show_sale_discount;
          }
    } else {
        if(($display_msrp_price!='')&&($display_msrp_price!='0')){
        $save=$display_msrp_price-$display_normal_price;
              $final_display_price = '<span class="smalltext1"><s>'.TEXT_PRODUCT_MSRP.$currencies->display_price($display_msrp_price, zen_get_tax_rate($product_check->fields['products_tax_class_id'])).'</s></span><br><span class="norm">'.TEXT_PRODUCT_OUR.$show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount.'</span><BR><span class="save">'.TEXT_PRODUCT_SAVE .$currencies->display_price($save, '').'&nbsp;&nbsp;('. number_format((($display_msrp_price -  $display_normal_price) / $display_msrp_price), 2, '.', '') * 100 . '%)'.'</span>' ;
          }else{
                  $final_display_price = $show_normal_price . $show_special_price . $show_sale_price . $show_sale_discount;
          }
    }

---

The key is the contents between the <span></span> tags.

---

Thank you, worked great!

Quote:

---

Originally Posted by sonjamichelle

Additionally I added a font size tag (yeah I know depreciated but it works) and an extra <BR> tag to get, in my opinion, a better flow to the price block.

Now looks like this:



The <BR> tag was inserted on line 298 after $final_display_price = '<BR> and again on line 305 after $final_display_price = '<BR>


That dropped the prices after the "Starting at:".

I also added a <font size=2> on line 298 before the <span class="save">' and a </font> at the end of line 298 before the ';

I did this again on line 305.

Those changes just make the whole block look a lot cleaner in my opinion.

These changes also carry over to the product listing as well since it was done in the functions code rather than the layout template.


Anyhoo, I hope all this and the above posted rambling works out.

Thanks for the idea too, it looks much more logical!! :clap:

---

Would you know how to separate the text from the numbers?
i.e.
List Price: $99.99
and so forth