Edit Orders v4.0 Support Thread

I've through so many websites and iterations of this module that I'm not sure what was and what is. So I installed this for a client who wants to add exact shipping to orders. That works fine but the payment method is paypal - using the paypal rest mod. So once the orginal order is placed, it's ready to be captured. I was thinking there was some mechanism to change the updated amount. But also the restful does give the buyer the choice of paypal or credit cards. So it's done different than the paypal pro.

My long winded question comes down to can edit orders be used to change the total and update the charge - any charge? Does the payment method matter?

Quote:

---

Originally Posted by delia

I've through so many websites and iterations of this module that I'm not sure what was and what is. So I installed this for a client who wants to add exact shipping to orders. That works fine but the payment method is paypal - using the paypal rest mod. So once the orginal order is placed, it's ready to be captured. I was thinking there was some mechanism to change the updated amount. But also the restful does give the buyer the choice of paypal or credit cards. So it's done different than the paypal pro.

My long winded question comes down to can edit orders be used to change the total and update the charge - any charge? Does the payment method matter?

---

I've had EO on the back-burner for a while and haven't tested its integration with PayPal RESTful. From looking through the paypalr code, I'll state that at this time, the payment module is not compatible with EO 4.x.

Plus, while the "old" PayPal could capture up to 115% of authorization, I see no evidence that RESTful can do the same.

Still Testing.

Quote:

---

Originally Posted by dbltoe

Plus, while the "old" PayPal could capture up to 115% of authorization, I see no evidence that RESTful can do the same.

Still Testing.

---

You need to put some glasses on; PayPal RESTful can also capture up to 115% of an authorization. But that's another support-thread.

See this PayPal RESTful wiki article for details: https://github.com/lat9/paypalr/wiki...-a-transaction

yep

trifocals can be a problem

should have said I saw no online verification from PayPal. My only site with Rest is down. Thus the still testing.

Quote:

---

Originally Posted by lat9

I've had EO on the back-burner for a while and haven't tested its integration with PayPal RESTful. From looking through the paypalr code, I'll state that at this time, the payment module is not compatible with EO 4.x.

---

So the old payal pro does work correctly?

Quote:

---

Originally Posted by delia

So the old payal pro does work correctly?

---

I misspoke before, since EO doesn't actually load any shipping/payment modules. PayPal RESTful will work in the same manner (with the same restrictions) as the older PayPal Pro.

so, the order details do not show a shipping address but edit orders does. I checked to make sure all the files are in place and can't see why this would be happening at all. Companion site (almost identical) has no issues - upgraded at the same time but the other site doesn't have edit orders installed. No core edits, only mod installed is image handler.

zc 2.01, php 8.3.10

Quote:

---

Originally Posted by delia

so, the order details do not show a shipping address but edit orders does. I checked to make sure all the files are in place and can't see why this would be happening at all. Companion site (almost identical) has no issues - upgraded at the same time but the other site doesn't have edit orders installed. No core edits, only mod installed is image handler.

zc 2.01, php 8.3.10

---

That'll happen if storepickup is used as the order's shipping method.

even without edit orders? I don't remember that behavior before. Thanks for the quick answer.

Hi All,

Zencart 1.58a with 8.1php and edit orders 4.7.1

I am getting this warning log message:
[26-Oct-2024 01:51:57 Australia/Sydney] Request URI: /admin/index.php?cmd=edit_orders&page=1&oID=25994&action=edit, IP address: 173.245.209.20, Language id 1
#0 /home/xxxx/outdoorking.com.au/admin/includes/modules/edit_orders/eo_edit_action_osh_table_display.php(161): zen_debug_error_handler()
#1 /home/xxxx/outdoorking.com.au/admin/includes/modules/edit_orders/eo_edit_action_display.php(581): require('/home/xxxx...')
#2 /home/xxxx/outdoorking.com.au/admin/edit_orders.php(169): require('/home/xxxx...')
#3 /home/xxxx/outdoorking.com.au/admin/index.php(11): require('/home/xxxx...')
--> PHP Warning: Undefined array key 6 in /home/xxxx/outdoorking.com.au/admin/includes/modules/edit_orders/eo_edit_action_osh_table_display.php on line 161.

Can anyone point me in the right direction on how to fix the issue to stop coming up in the logs.

Order 25994 has at least one status-history record that identifies an orders-status id of '6' which, for whatever reason, does not exist in the site's Localization :: Orders Status.

The best I can offer at this time is to stop trying to edit that order.

Quote:

---

Originally Posted by lat9

Order 25994 has at least one status-history record that identifies an orders-status id of '6' which, for whatever reason, does not exist in the site's Localization :: Orders Status.

The best I can offer at this time is to stop trying to edit that order.

---

Doesn't viewing that same order under the built-in Customers :: Orders exhibit the same problem, i.e. a log generated due to a no-long-present status-history definition?

Quote:

---

Originally Posted by lat9

Doesn't viewing that same order under the built-in Customers :: Orders exhibit the same problem, i.e. a log generated due to a no-long-present status-history definition?

---

Ok when checking I found a reference to Super Orders would that be causing the issue with edit orders.

Here is what the reference says in admin/invoice.php file on live site:

// BEGIN Super Orders edit
// add CC data as a line item to SO payment system
if (isset($this->info['cc_type']) && zen_not_null($this->info['cc_type']) || isset($this->info['cc_owner']) && zen_not_null($this->info['cc_owner']) || isset($this->info['cc_number']) && zen_not_null($this->info['cc_number'])) {
require(DIR_WS_CLASSES . 'super_order.php');
$so = new super_order($insert_id);
$so->cc_line_item();
}
// END Super Orders edit

On the dev site it has this reference the same file:

// BEGIN Super Orders edit
// add CC data as a line item to SO payment system
if (zen_not_null($this->info['cc_type']) || zen_not_null($this->info['cc_owner']) || zen_not_null($this->info['cc_number'])) {
require(DIR_WS_CLASSES . 'super_order.php');
$so = new super_order($insert_id);
$so->cc_line_item();
}
// END Super Orders edit

Should that be delete out of the file on the live site?

Changes to the invoice aren't going to affect EO. Would you please answer the question that I'd asked:

Quote:

---

Doesn't viewing that same order under the built-in Customers :: Orders exhibit the same problem, i.e. a log generated due to a no-long-present status-history definition?

---

Hi all, just recently installed EO 4.7.1 on my site and having some issues with sales tax displaying when items are added/removed from an order.

Example: 1 item order
Sub-Total: $0.25
Ground Advantage® (3 - 5 days): $4.95
CA State Sales Tax (7.25%): $0.02
Total: $5.22

Used EO to add second item, also taxable:

Sub-Total: $1.00
Ground Advantage® (3 - 5 days): 4.9500
Total: $6.02

The tax line is removed from the order. Tax is still calculated correctly in the total, but no longer displays in admin OR on customer order history page. Did I missing something here?

I tried installing with and without the optional overrides without any change in result. Anyone able to point me in the right direction? Thank you.

Quote:

---

Originally Posted by mcqueeneycoins

Hi all, just recently installed EO 4.7.1 on my site and having some issues with sales tax displaying when items are added/removed from an order.

Example: 1 item order
Sub-Total: $0.25
Ground Advantage® (3 - 5 days): $4.95
CA State Sales Tax (7.25%): $0.02
Total: $5.22

Used EO to add second item, also taxable:

Sub-Total: $1.00
Ground Advantage® (3 - 5 days): 4.9500
Total: $6.02

The tax line is removed from the order. Tax is still calculated correctly in the total, but no longer displays in admin OR on customer order history page. Did I missing something here?

I tried installing with and without the optional overrides without any change in result. Anyone able to point me in the right direction? Thank you.

---

Try ticking the "Reset totals prior to update" box.

Quote:

---

Originally Posted by lat9

Try ticking the "Reset totals prior to update" box.

---

Tried both checked and unchecked and same result. Tax line disappears completely when adding a product.

Quote:

---

Originally Posted by mcqueeneycoins

Tried both checked and unchecked and same result. Tax line disappears completely when adding a product.

---

May I make a suggestion? Do you use new 2.1.0 version of Zen-Cart ?

It seems, there are some issues with loading language files using new ResourceLoaders there

(only suggestion!! I have not had time to investigate further)

Quote:

---

Originally Posted by yesaul

May I make a suggestion? Do you use new 2.1.0 version of Zen-Cart ?

It seems, there are some issues with loading language files using new ResourceLoaders there

(only suggestion!! I have not had time to investigate further)

---

No, I'm using 1.5.8a

Quote:

---

Originally Posted by mcqueeneycoins

Hi all, just recently installed EO 4.7.1 on my site and having some issues with sales tax displaying when items are added/removed from an order.

Example: 1 item order
Sub-Total: $0.25
Ground Advantage® (3 - 5 days): $4.95
CA State Sales Tax (7.25%): $0.02
Total: $5.22

Used EO to add second item, also taxable:

Sub-Total: $1.00
Ground Advantage® (3 - 5 days): 4.9500
Total: $6.02

The tax line is removed from the order. Tax is still calculated correctly in the total, but no longer displays in admin OR on customer order history page. Did I missing something here?

I tried installing with and without the optional overrides without any change in result. Anyone able to point me in the right direction? Thank you.

---

Anyone have additional thoughts on this issue? I enabled debug and log file appears to have tax calculated, just not displayed. Could there be an issue with my order total module or something else I have set?

Code:

---

2024-12-31 05:16:41, Edit Orders entered (4.7.1) action (edit)
Enabled Order Totals: ot_subtotal.php;ot_shipping.php;ot_coupon.php;ot_group_pricing.php;ot_tax.php;ot_loworderfee.php;ot_gv.php;ot_total.php
getOrderInfo(edit), on entry: Called by /home/.../edit_orders.php on line #112
        Subtotal: (not set), Shipping: (not set), Shipping Tax-Rate:  (not set), Shipping Tax-Description:  (not set), Shipping Tax: (not set), Tax: 31.1815, Total: 467.3715, Tax Groups: {"7.2500":"1"}
        $_SESSION['shipping']: (not set)

Order Totals
                ot_subtotal. Text: $430.09, Value: 430.0900
                ot_shipping. Text: $6.10, Value: 6.1000
                ot_total. Text: $467.37, Value: 467.3715

---

Quote:

---

Originally Posted by mcqueeneycoins

Anyone have additional thoughts on this issue? I enabled debug and log file appears to have tax calculated, just not displayed. Could there be an issue with my order total module or something else I have set?

Code:

---

2024-12-31 05:16:41, Edit Orders entered (4.7.1) action (edit)
Enabled Order Totals: ot_subtotal.php;ot_shipping.php;ot_coupon.php;ot_group_pricing.php;ot_tax.php;ot_loworderfee.php;ot_gv.php;ot_total.php
getOrderInfo(edit), on entry: Called by /home/.../edit_orders.php on line #112
        Subtotal: (not set), Shipping: (not set), Shipping Tax-Rate:  (not set), Shipping Tax-Description:  (not set), Shipping Tax: (not set), Tax: 31.1815, Total: 467.3715, Tax Groups: {"7.2500":"1"}
        $_SESSION['shipping']: (not set)

Order Totals
                ot_subtotal. Text: $430.09, Value: 430.0900
                ot_shipping. Text: $6.10, Value: 6.1000
                ot_total. Text: $467.37, Value: 467.3715

---

---

After a lot of trial and error, I discovered a small modification in the ot_tax.php file that apparently caused this issue. I have restored the file to the original ZC distribution and it now displays properly. However, it is showing up as follows:

CA State Sales Tax (7.25%) + Shipping Tax (0.0000%): $23.58

Is there any way to "hide" the + Shipping Tax portion?

Quote:

---

Originally Posted by mcqueeneycoins

After a lot of trial and error, I discovered a small modification in the ot_tax.php file that apparently caused this issue. I have restored the file to the original ZC distribution and it now displays properly. However, it is showing up as follows:

CA State Sales Tax (7.25%) + Shipping Tax (0.0000%): $23.58

Is there any way to "hide" the + Shipping Tax portion?

---

That would be (most likely) a combination of Zen Cart Configuration settings:

My Store // Sales Tax Display Status, set to 0. That will remove the display of any 0-value taxes, like shipping in your example.
My Store // Show Split Tax Lines, set to true. That will result in each type of tax being separately reported. For your example, that would display as

CA State Sales Tax (7.25%): $23.58
Shipping Tax (0.0000%): $0.00

Good day

Is anybody using EO with new ZC v2.1.0 ??

I'm trying to experiment with EO 4.7.1 on freshly installed ZC v2.1.0 (no another modules installed or no any changes made)

Problems are appearing with loading language files for different OT modules
(for ex: Could not locate language file: includes/languages/english/modules/order_total/ot_shipping.php)

Systems crashes also by calling zen_calculate_tax function from editOrders->calculateOrderShippingTax
(for ex: Uncaught TypeError: Unsupported operand types: string * int)

Quote:

---

Originally Posted by yesaul

Good day

Is anybody using EO with new ZC v2.1.0 ??

I'm trying to experiment with EO 4.7.1 on freshly installed ZC v2.1.0 (no another modules installed or no any changes made)

Problems are appearing with loading language files for different OT modules
(for ex: Could not locate language file: includes/languages/english/modules/order_total/ot_shipping.php)

Systems crashes also by calling zen_calculate_tax function from editOrders->calculateOrderShippingTax
(for ex: Uncaught TypeError: Unsupported operand types: string * int)

---

Yep, EO 4.1.7 isn't ready for zc210. I'm working hard to get EO-5 ready (see https://github.com/lat9/edit_orders) for progress and pre-release testing.

Quote:

---

Yep, EO 4.1.7 isn't ready for zc210. I'm working hard to get EO-5 ready

---

Thank you. We'll be waiting

I updated my first live order using EO 4.7.1 with 1.5.8a and had a couple of issues/questions:

1) I received this error when updating the order:

Code:

---

Warning: The coupon code was not found in the database. Note: the title / text of a coupon is usually formatted like "Discount Coupon : coupon_code :".

---

I have a feeling it has to do with changes I made to how the coupon code displays to the customer, and I believe the change I need to make is in the eo_update_order_action_processing.php file here:

Code:

---

// Look for correctly formatted title
                    preg_match('/([^:]+):([^:]+)/', $coupon, $matches);
                    if (count($matches) > 2) {
                        $order_total['title'] = trim($matches[1]);
                        $coupon = $matches[2];
                    }
                    $coupon = trim($coupon);
                    $cc_id = $db->Execute(
                        "SELECT coupon_id, coupon_type
                          FROM ". TABLE_COUPONS . "
                          WHERE coupon_code = '$coupon'
                          LIMIT 1"
                    );

---

The change I made to the ot_coupon.php file is:

Code:

---

$this->output[] = [
                'title' => $this->title . ' (' . $this->coupon_code . '):',
                'text' => '-' . $currencies->format($od_amount['total']),
                'value' => $od_amount['total']
            ];

---

Can someone help me correct the EO code to prevent this error in the future?

2) I have EO set to reset totals on update in the config menu. When I change a quantity to 0 to remove an item, should the totals automatically update (like an auto page refresh), or is it normal to not display any changes until I click "Update"? I was hoping to be able to see the impact the changes have prior to finalizing an update but that's not happening.

Quote:

---

Originally Posted by mcqueeneycoins

I updated my first live order using EO 4.7.1 with 1.5.8a and had a couple of issues/questions:

1) I received this error when updating the order:

Code:

---

Warning: The coupon code was not found in the database. Note: the title / text of a coupon is usually formatted like "Discount Coupon : coupon_code :".

---

I have a feeling it has to do with changes I made to how the coupon code displays to the customer, and I believe the change I need to make is in the eo_update_order_action_processing.php file here:

Code:

---

// Look for correctly formatted title
                    preg_match('/([^:]+):([^:]+)/', $coupon, $matches);
                    if (count($matches) > 2) {
                        $order_total['title'] = trim($matches[1]);
                        $coupon = $matches[2];
                    }
                    $coupon = trim($coupon);
                    $cc_id = $db->Execute(
                        "SELECT coupon_id, coupon_type
                          FROM ". TABLE_COUPONS . "
                          WHERE coupon_code = '$coupon'
                          LIMIT 1"
                    );

---

The change I made to the ot_coupon.php file is:

Code:

---

$this->output[] = [
                'title' => $this->title . ' (' . $this->coupon_code . '):',
                'text' => '-' . $currencies->format($od_amount['total']),
                'value' => $od_amount['total']
            ];

---

Can someone help me correct the EO code to prevent this error in the future?

2) I have EO set to reset totals on update in the config menu. When I change a quantity to 0 to remove an item, should the totals automatically update (like an auto page refresh), or is it normal to not display any changes until I click "Update"? I was hoping to be able to see the impact the changes have prior to finalizing an update but that's not happening.

---

1) Change that section to read

Code:

---

// Look for correctly formatted title
                    preg_match('/\((.+)\)/', $coupon, $matches);
                    if (count($matches) === 2) {
                        $order_total['title'] = rtrim(str_replace('(' . $matches[1] . ')', '', $order_total['title']), ' :');
                        $coupon = $matches[1];
                    }
                    $coupon = trim($coupon);
                    $cc_id = $db->Execute(
                        "SELECT coupon_id, coupon_type
                          FROM ". TABLE_COUPONS . "
                          WHERE coupon_code = '$coupon'
                          LIMIT 1"
                    );

---

2) EO 4.7.1 can be quite finicky. The totals 'should' automatically update to reflect the removed item; if not, just click the reset-totals box and update again.

:beta:
EO v5.0.0-beta1 is now available for (er) beta-testing: https://github.com/lat9/edit_orders/...g/v5.0.0-beta1

Currently supported on Zen Cart 2.1.0 only.

zen 210 php 8.3 lots of mods when editing an order and you apply shipping to an order and you update the order, customers cant see the edits on the invoice or i cant see in orders, i see the amount was applied but does not show what the amount was applied to, or maybe im not doing something right.

> EO v5.0.0-beta1 is now available for beta-testing

Fantastic news! Thank you @lat9!

Quote:

---

Originally Posted by jimmie

zen 210 php 8.3 lots of mods when editing an order and you apply shipping to an order and you update the order, customers cant see the edits on the invoice or i cant see in orders, i see the amount was applied but does not show what the amount was applied to, or maybe im not doing something right.

---

I'm guessing that you're using EO 4.7.1. That version doesn't include details as to the changes made.

Quote:

---

Originally Posted by lat9

I'm guessing that you're using EO 4.7.1. That version doesn't include details as to the changes made.

---

I DELETED EVERY FILE FROM 4.71 tried to install 5.0 from plugin manager and get this

Code:

---

This version of EO cannot be installed until you remove the files associated with the non-encapsulated version. See the generated log-file for details.

---

I tested EO5 on a freshly installed ZC 2.1.0 with demo data (PHP 8.3.15 and 8.4.2). I got some problem with product quantity and total not updating. Here is what I did:
Installed EO5 without any problem.
First placed an order with the first two action DVDs from demo data.
Then in admin order page edit this order. As soon as I changed product quantity of first item from 1 to 2 I got this debug file:

Code:

---

[16-Jan-2025 13:24:50 Asia/Tokyo] Request URI: /admin/ajax.php?act=ajaxEditOrdersAdmin&method=updateProduct, IP address: 116.58.186.193, Language id 1
#0 [internal function]: zen_debug_error_handler()
#1 xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php(828): trigger_error()
#2 xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php(648): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 xxxx\ajax.php(77): zcAjaxEditOrdersAdmin->updateProduct()
#4 xxxx\zclast\admin\ajax.php(17): require('...')
--> PHP Notice: array (
  'name' => 'Bill Smith',
  'company' => 'JustaDemo',
  'street_address' => '123 Any Avenue',
  'suburb' => '',
  'city' => 'Here',
  'postcode' => '12345',
  'state' => 'California',
  'country' =>
  array (
    'id' => '223',
    'title' => 'United States',
    'iso_code_2' => 'US',
    'iso_code_3' => 'USA',
  ),
  'format_id' => 7,
  'zone_id' => '12',
  'country_id' => 223,
  'state_code' => 'CA',
) in xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php on line 828.

---

In admin page everything looks good with new quantity and subtotal/total except in comment where subtotal and total modification are reported but not quantity and product total ones.
Then I commit changes to order and product quantity and total goes back to origin. Order subtotal and total are thenew updated ones. There is no new debug file.

It seems there is a problem with ajax update.

Just after having done test in precedent post, if I try to click on Edit button for a product, nothing happens and I got a similar debug file:

Code:

---

[16-Jan-2025 13:55:30 Asia/Tokyo] Request URI: /admin/ajax.php?act=ajaxEditOrdersAdmin&method=getProductUpdateModal, IP address: yyyy, Language id 1
#0 xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php(589): zen_debug_error_handler()
#1 xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php(360): zcAjaxEditOrdersAdmin->getModalContent()
#2 xxxx\ajax.php(77): zcAjaxEditOrdersAdmin->getProductUpdateModal()
#3 xxxx\admin\ajax.php(17): require('...')
--> PHP Warning: Undefined array key "eoChanges" in xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php on line 589.

[16-Jan-2025 13:55:30 Asia/Tokyo] PHP Fatal error:  Uncaught Error: Call to a member function getOrderId() on null in xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php:589
Stack trace:
#0 xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php(360): zcAjaxEditOrdersAdmin->getModalContent()
#1 xxxx\ajax.php(77): zcAjaxEditOrdersAdmin->getProductUpdateModal()
#2 xxxx\admin\ajax.php(17): require('...')
#3 {main}
  thrown in xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php on line 589

[16-Jan-2025 13:55:30 Asia/Tokyo] Request URI: /admin/ajax.php?act=ajaxEditOrdersAdmin&method=getProductUpdateModal, IP address: yyyy
--> PHP Fatal error: Uncaught Error: Call to a member function getOrderId() on null in xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php:589
Stack trace:
#0 xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php(360): zcAjaxEditOrdersAdmin->getModalContent()
#1 xxxx\ajax.php(77): zcAjaxEditOrdersAdmin->getProductUpdateModal()
#2 xxxx\admin\ajax.php(17): require('...')
#3 {main}
  thrown in xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php on line 589.

[16-Jan-2025 13:55:30 Asia/Tokyo] Request URI: /admin/ajax.php?act=ajaxEditOrdersAdmin&method=getProductUpdateModal, IP address: yyyy
--> PHP Fatal error: Uncaught Error: Call to a member function getOrderId() on null in xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php:589
Stack trace:
#0 xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php(360): zcAjaxEditOrdersAdmin->getModalContent()
#1 xxxx\ajax.php(77): zcAjaxEditOrdersAdmin->getProductUpdateModal()
#2 xxxx\admin\ajax.php(17): require('...')
#3 {main}
  thrown in xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php on line 589.

---

Quote:

---

Originally Posted by pilou2

I tested EO5 on a freshly installed ZC 2.1.0 with demo data (PHP 8.3.15 and 8.4.2). I got some problem with product quantity and total not updating. Here is what I did:
Installed EO5 without any problem.
First placed an order with the first two action DVDs from demo data.
Then in admin order page edit this order. As soon as I changed product quantity of first item from 1 to 2 I got this debug file:

Code:

---

[16-Jan-2025 13:24:50 Asia/Tokyo] Request URI: /admin/ajax.php?act=ajaxEditOrdersAdmin&method=updateProduct, IP address: 116.58.186.193, Language id 1
#0 [internal function]: zen_debug_error_handler()
#1 xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php(828): trigger_error()
#2 xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php(648): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 xxxx\ajax.php(77): zcAjaxEditOrdersAdmin->updateProduct()
#4 xxxx\zclast\admin\ajax.php(17): require('...')
--> PHP Notice: array (
  'name' => 'Bill Smith',
  'company' => 'JustaDemo',
  'street_address' => '123 Any Avenue',
  'suburb' => '',
  'city' => 'Here',
  'postcode' => '12345',
  'state' => 'California',
  'country' =>
  array (
    'id' => '223',
    'title' => 'United States',
    'iso_code_2' => 'US',
    'iso_code_3' => 'USA',
  ),
  'format_id' => 7,
  'zone_id' => '12',
  'country_id' => 223,
  'state_code' => 'CA',
) in xxxx\zc_plugins\EditOrders\v5.0.0\catalog\includes\classes\ajax\zcAjaxEditOrdersAdmin.php on line 828.

---

In admin page everything looks good with new quantity and subtotal/total except in comment where subtotal and total modification are reported but not quantity and product total ones.
Then I commit changes to order and product quantity and total goes back to origin. Order subtotal and total are thenew updated ones. There is no new debug file.

It seems there is a problem with ajax update.

---

Please report EO-5 issues on GitHub and note that it's a beta version. https://github.com/lat9/edit_orders

Quote:

---

Originally Posted by jimmie

I DELETED EVERY FILE FROM 4.71 tried to install 5.0 from plugin manager and get this

Code:

---

This version of EO cannot be installed until you remove the files associated with the non-encapsulated version. See the generated log-file for details.

---

---

... and what did the generated log-file indicate?

As noted before, EO-5 issues (since it's still beta) are to be reported via GitHub issues: https://github.com/lat9/edit_orders

Code:

---

[16-Jan-2025 20:43:31 UTC] Request URI: /Jimmies_Admin/index.php?cmd=plugin_manager&page=1&colKey=EditOrders&action=doInstall, IP address: 35.139.236.145, Language id 1
#0 [internal function]: zen_debug_error_handler()
#1 /zc_plugins/EditOrders/v5.0.0/Installer/ScriptedInstaller.php(158): trigger_error()
#2 /zc_plugins/EditOrders/v5.0.0/Installer/ScriptedInstaller.php(16): ScriptedInstaller->nonEncapsulatedVersionPresent()
#3 /includes/classes/PluginSupport/ScriptedInstaller.php(64): ScriptedInstaller->executeInstall()
#4 /includes/classes/PluginSupport/Installer.php(94): Zencart\PluginSupport\ScriptedInstaller->doInstall()
#5 /includes/classes/PluginSupport/Installer.php(45): Zencart\PluginSupport\Installer->executeScriptedInstaller()
#6 /includes/classes/PluginSupport/BasePluginInstaller.php(29): Zencart\PluginSupport\Installer->executeInstallers()
#7 /includes/classes/ViewBuilders/PluginManagerController.php(145): Zencart\PluginSupport\BasePluginInstaller->processInstall()
#8 /includes/classes/ViewBuilders/BaseController.php(37): Zencart\ViewBuilders\PluginManagerController->processActionDoInstall()
#9 /Jimmies_Admin/plugin_manager.php(101): Zencart\ViewBuilders\BaseController->processRequest()
#10 /Jimmies_Admin/index.php(16): require('...')
--> PHP Notice: Non-encapsulated admin file (includes/classes/attributes.php) must be removed before this plugin can be installed. in /zc_plugins/EditOrders/v5.0.0/Installer/ScriptedInstaller.php on line 158.

---

Quote:

---

Originally Posted by jimmie

Code:

---

[16-Jan-2025 20:43:31 UTC] Request URI: /Jimmies_Admin/index.php?cmd=plugin_manager&page=1&colKey=EditOrders&action=doInstall, IP address: 35.139.236.145, Language id 1
#0 [internal function]: zen_debug_error_handler()
#1 /zc_plugins/EditOrders/v5.0.0/Installer/ScriptedInstaller.php(158): trigger_error()
#2 /zc_plugins/EditOrders/v5.0.0/Installer/ScriptedInstaller.php(16): ScriptedInstaller->nonEncapsulatedVersionPresent()
#3 /includes/classes/PluginSupport/ScriptedInstaller.php(64): ScriptedInstaller->executeInstall()
#4 /includes/classes/PluginSupport/Installer.php(94): Zencart\PluginSupport\ScriptedInstaller->doInstall()
#5 /includes/classes/PluginSupport/Installer.php(45): Zencart\PluginSupport\Installer->executeScriptedInstaller()
#6 /includes/classes/PluginSupport/BasePluginInstaller.php(29): Zencart\PluginSupport\Installer->executeInstallers()
#7 /includes/classes/ViewBuilders/PluginManagerController.php(145): Zencart\PluginSupport\BasePluginInstaller->processInstall()
#8 /includes/classes/ViewBuilders/BaseController.php(37): Zencart\ViewBuilders\PluginManagerController->processActionDoInstall()
#9 /Jimmies_Admin/plugin_manager.php(101): Zencart\ViewBuilders\BaseController->processRequest()
#10 /Jimmies_Admin/index.php(16): require('...')
--> PHP Notice: Non-encapsulated admin file (includes/classes/attributes.php) must be removed before this plugin can be installed. in /zc_plugins/EditOrders/v5.0.0/Installer/ScriptedInstaller.php on line 158.

---

---

nevermind got it

Quote:

---

Originally Posted by lat9

Please report EO-5 issues on GitHub and note that it's a beta version. https://github.com/lat9/edit_orders

---

Done!
I hope I could help more.

ZC 2.1
PHP 8.3
Ty Package Tracker

Would the following be something in my system or a bug I need to report on GitHub?

*****************************************
[02-Feb-2025 13:11:09 America/Boise] Request URI: //index.php?cmd=edit_orders&page=1&action=edit&oID=9870, IP address: , Language id 1
#0 //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php(22): zen_debug_error_handler()
#1 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(50): include_once('/...')
#2 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(34): Zencart\LanguageLoader\FilesLanguageLoader->loadFileDefineFile()
#3 //public_html/includes/classes/ResourceLoaders/LanguageLoader.php(105): Zencart\LanguageLoader\FilesLanguageLoader->loadModuleLanguageFile()
#4 //public_html/includes/classes/order_total.php(58): Zencart\LanguageLoader\LanguageLoader->loadModuleLanguageFile()
#5 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(43): order_total->__construct()
#6 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(907): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrderTotalsObject()
#7 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(123): Zencart\Plugins\Admin\EditOrders\EditOrders->getUnusedOrderTotalModules()
#8 //public_html/zc_plugins/EditOrders/v5.0.0/admin/edit_orders.php(242): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrder()
#9 //public_html/Zcf294AkrVd6csa550FeF/index.php(28): require('/...')
--> PHP Warning: Constant MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_TITLE already defined in //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php on line 22.

[02-Feb-2025 13:11:09 America/Boise] Request URI: //index.php?cmd=edit_orders&page=1&action=edit&oID=9870, IP address: , Language id 1
#0 //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php(23): zen_debug_error_handler()
#1 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(50): include_once('/...')
#2 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(34): Zencart\LanguageLoader\FilesLanguageLoader->loadFileDefineFile()
#3 //public_html/includes/classes/ResourceLoaders/LanguageLoader.php(105): Zencart\LanguageLoader\FilesLanguageLoader->loadModuleLanguageFile()
#4 //public_html/includes/classes/order_total.php(58): Zencart\LanguageLoader\LanguageLoader->loadModuleLanguageFile()
#5 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(43): order_total->__construct()
#6 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(907): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrderTotalsObject()
#7 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(123): Zencart\Plugins\Admin\EditOrders\EditOrders->getUnusedOrderTotalModules()
#8 //public_html/zc_plugins/EditOrders/v5.0.0/admin/edit_orders.php(242): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrder()
#9 //public_html/Zcf294AkrVd6csa550FeF/index.php(28): require('/...')
--> PHP Warning: Constant MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DESCRIPTION already defined in //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php on line 23.

Quote:

---

Originally Posted by wsworx

ZC 2.1
PHP 8.3
Ty Package Tracker

Would the following be something in my system or a bug I need to report on GitHub?

*****************************************
[02-Feb-2025 13:11:09 America/Boise] Request URI: //index.php?cmd=edit_orders&page=1&action=edit&oID=9870, IP address: , Language id 1
#0 //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php(22): zen_debug_error_handler()
#1 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(50): include_once('/...')
#2 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(34): Zencart\LanguageLoader\FilesLanguageLoader->loadFileDefineFile()
#3 //public_html/includes/classes/ResourceLoaders/LanguageLoader.php(105): Zencart\LanguageLoader\FilesLanguageLoader->loadModuleLanguageFile()
#4 //public_html/includes/classes/order_total.php(58): Zencart\LanguageLoader\LanguageLoader->loadModuleLanguageFile()
#5 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(43): order_total->__construct()
#6 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(907): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrderTotalsObject()
#7 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(123): Zencart\Plugins\Admin\EditOrders\EditOrders->getUnusedOrderTotalModules()
#8 //public_html/zc_plugins/EditOrders/v5.0.0/admin/edit_orders.php(242): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrder()
#9 //public_html/Zcf294AkrVd6csa550FeF/index.php(28): require('/...')
--> PHP Warning: Constant MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_TITLE already defined in //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php on line 22.

[02-Feb-2025 13:11:09 America/Boise] Request URI: //index.php?cmd=edit_orders&page=1&action=edit&oID=9870, IP address: , Language id 1
#0 //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php(23): zen_debug_error_handler()
#1 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(50): include_once('/...')
#2 //public_html/includes/classes/ResourceLoaders/FilesLanguageLoader.php(34): Zencart\LanguageLoader\FilesLanguageLoader->loadFileDefineFile()
#3 //public_html/includes/classes/ResourceLoaders/LanguageLoader.php(105): Zencart\LanguageLoader\FilesLanguageLoader->loadModuleLanguageFile()
#4 //public_html/includes/classes/order_total.php(58): Zencart\LanguageLoader\LanguageLoader->loadModuleLanguageFile()
#5 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(43): order_total->__construct()
#6 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(907): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrderTotalsObject()
#7 //public_html/zc_plugins/EditOrders/v5.0.0/admin/includes/classes/EditOrders.php(123): Zencart\Plugins\Admin\EditOrders\EditOrders->getUnusedOrderTotalModules()
#8 //public_html/zc_plugins/EditOrders/v5.0.0/admin/edit_orders.php(242): Zencart\Plugins\Admin\EditOrders\EditOrders->getOrder()
#9 //public_html/Zcf294AkrVd6csa550FeF/index.php(28): require('/...')
--> PHP Warning: Constant MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DESCRIPTION already defined in //public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php on line 23.

---

I ran a search in the developers toolkit and the only file it shows defining that constant is the 'public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php'

Quote:

---

Originally Posted by wsworx

I ran a search in the developers toolkit and the only file it shows defining that constant is the 'public_html/includes/languages/english/modules/order_total/ot_onetime_discount.php'

---

Okay so I figured out that there were a batch of old files form an old version of Edit orders still in the 'includes/languages/english/modules/order_total/' folder. I deleted those and this issue went away but now I have a new issue that seems to be a bug in the ver 5 edit orders but I am not 100% sure.
When I try to add a 'Onetime Discount' I get the following debug log:

************************************
[03-Feb-2025 12:35:08 America/Boise] PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143

[03-Feb-2025 12:35:08 America/Boise] Request URI: //ajax.php?act=ajaxEditOrdersAdmin&method=addOrUpdateOrderTotal, IP address: 107.204.159.118
--> PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143.

[03-Feb-2025 12:35:08 America/Boise] Request URI: //ajax.php?act=ajaxEditOrdersAdmin&method=addOrUpdateOrderTotal, IP address: 107.204.159.118
--> PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143.

**************************************************

When I look in the file that defines the constants for EO 5, lang.ot_onetime_discount.php, I do not see that constant listed. Only the two following constants are listed:

Code:

---

$define = [
    'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_TITLE' => 'Onetime Discount',
    'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DESCRIPTION' => 'Onetime Discount applied to the order',

---

I added the following to the file:

Code:

---

'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY' => 'Onetime Deduction Only',

---

this stopped the debug file from being created.

I also found that you must specify a negative amount for the discount or EO will not deduct the amount from the total but add it to the total.

Quote:

---

Originally Posted by wsworx

Okay so I figured out that there were a batch of old files form an old version of Edit orders still in the 'includes/languages/english/modules/order_total/' folder. I deleted those and this issue went away but now I have a new issue that seems to be a bug in the ver 5 edit orders but I am not 100% sure.
When I try to add a 'Onetime Discount' I get the following debug log:

************************************
[03-Feb-2025 12:35:08 America/Boise] PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143

[03-Feb-2025 12:35:08 America/Boise] Request URI: //ajax.php?act=ajaxEditOrdersAdmin&method=addOrUpdateOrderTotal, IP address: 107.204.159.118
--> PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143.

[03-Feb-2025 12:35:08 America/Boise] Request URI: //ajax.php?act=ajaxEditOrdersAdmin&method=addOrUpdateOrderTotal, IP address: 107.204.159.118
--> PHP Fatal error: Uncaught Error: Undefined constant "MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY" in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php:143
Stack trace:
#0 //public_html/includes/classes/order_total.php(209): ot_onetime_discount->collect_posts()
#1 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(764): order_total->collect_posts()
#2 //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/classes/ajax/zcAjaxEditOrdersAdmin.php(632): zcAjaxEditOrdersAdmin->processOrderUpdate()
#3 //public_html/ajax.php(77): zcAjaxEditOrdersAdmin->addOrUpdateOrderTotal()
#4 //public_html/Zcf294AkrVd6csa550FeF/ajax.php(17): require('/...')
#5 {main}
thrown in //public_html/zc_plugins/EditOrders/v5.0.0/catalog/includes/modules/order_total/ot_onetime_discount.php on line 143.

**************************************************

When I look in the file that defines the constants for EO 5, lang.ot_onetime_discount.php, I do not see that constant listed. Only the two following constants are listed:

Code:

---

$define = [
    'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_TITLE' => 'Onetime Discount',
    'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DESCRIPTION' => 'Onetime Discount applied to the order',

---

I added the following to the file:

Code:

---

'MODULE_ORDER_TOTAL_ONETIME_DISCOUNT_DEDUCTION_ONLY' => 'Onetime Deduction Only',

---

this stopped the debug file from being created.

I also found that you must specify a negative amount for the discount or EO will not deduct the amount from the total but add it to the total.

---

I have added these along with several other issues to the github for editorders.

Whenever an order with sales tax is updated, the sales tax for the city and state no longer appear in the invoices or on the order's info, but it is calculated correctly in the total. I'm on 1.5.8a. What is the fix for this? I need the tax to appear on invoices after an order is edited instead of it just disappearing. I checked my logs and they aren't showing any issues with the page.

I messaged mcqueenycoins since I was having the exact same behavior as them, however our ot_tax.php is completely unchanged and is the same as the vanilla 1.5.8a ot_tax.php in includes/modules/order_total so I don't have a clue what would be causing that line to no longer show up after an order is edited with Edit Orders 4.7.1

Sorry for the third post, I didn't make the 7 minute limit for the edits. I did discover some more information. So it shows the correct total with tax included in 'Details' and 'Invoice' views but it isn't showing the line for the tax. I did discover that when the order was edited, it seems to have deleted the ot_tax entry in the orders_total table of the database. I can manually add this record back in, but why would editing an order delete an entry for ot_tax in the orders_total table?

Quote:

---

Originally Posted by clam_man

Sorry for the third post, I didn't make the 7 minute limit for the edits. I did discover some more information. So it shows the correct total with tax included in 'Details' and 'Invoice' views but it isn't showing the line for the tax. I did discover that when the order was edited, it seems to have deleted the ot_tax entry in the orders_total table of the database. I can manually add this record back in, but why would editing an order delete an entry for ot_tax in the orders_total table?

---

What order-total modules are in use on the site?

Currently just using:
ot_coupon, ot_group_pricing, ot_gv, ot_loworderfee, ot_shipping, ot_subtotal, ot_tax, ot_total

Quote:

---

Originally Posted by jimmie

zen 210 php 8.3 lots of mods when editing an order and you apply shipping to an order and you update the order, customers cant see the edits on the invoice or i cant see in orders, i see the amount was applied but does not show what the amount was applied to, or maybe im not doing something right.

---

Anyone using EO should not upgrade to 2.1 yet.
I have EO 4.7.1 working in 2.0.1.
EO 4.7.1 does not function correctly in Zen 2.1.
EO 5 is in beta mode currently and is not ready for prime time although lat9 is working hard at getting it ready. :clap:
Anyone who has loaded Zen 2.1 and EO5, test sites only DO NOT USE ON LIVE SITE you've been warned lol, and is finding issues are asked to report those issues on the GitHub site for EO 5: EO5 GitHub

Quote:

---

Originally Posted by lhungil

Older versions of Edit Orders (< 4.1) allowed the store owner to manually modify almost the entire order (including order total lines). It was not uncommon to find problems with math (as these needed to be done by the person editing the order) in stores using older versions of Edit Orders. If you look through the forums there are a number of other posts regarding issues caused by older versions of Edit Orders (including other math related items).


As of Edit Orders 4.1.x, end users are no longer allowed to manually "adjust" the subtotal (and certain other order total lines) within Edit Orders to avoid such issues. And instead of Edit Orders handling any math related to the order total modules, the order total modules are actually run (same as during checkout). This allows the order total modules to do their own calculations based upon the order contents.

As a result, under Edit Orders 4.1.x if the "subtotal" was off before editing, it will be off after editing (it is not recalculated, just loaded from the database as-is and adjusted up / down when products are added / edited / removed).

If you create a new order in the new store, then attempt to edit the order:

• Are the order totals correct when the order is first loaded (no edits)?
• Change the product price and then press "update". Are the order totals correct?
• Add a product to the order and then press "update". Are the order totals correct?

I'll have to take a look at this. I think I know the cause, but want to verify the fix on a couple test sites.



If the database columns and tables were all set to use a CHARACTER SET of UTF8 previous to the upgrade, you are probably okay (you can check this in phpMyAdmin or similiar). This is rare because out of box Zen Cart < 1.5.0 always used iso-latin-1. When upgrading from Zen Cart < 1.5.0 if the 1.3.x database was iso-latin-1 you still need to manually address this (different store configurations need different massaging and conversions - especially multilingual stores, so this was not automated).



Ahhh, by default Zen Cart does not populate the "shipping" address when an order is completely virtual. If the shipping address contains an address with NO "country" (or a country not found in the Zen Cart database), this would be the cause of the message "Warning: One or more of the customer address fields contains a country name unknown to Zen Cart ("Locations / Taxes"->"Countries"). Taxes and some shipping modules may not function correctly until the issue has been resolved."

If all of the products are indeed virtual (and shipping will NEVER be used), you can disable the warning by making the following change in "/admin/edit_orders.php":

Code:

---

            if(!is_array($order->customer['country']) || !array_key_exists('id', $order->customer['country']) ||
                    !is_array($order->billing['country']) || !array_key_exists('id', $order->billing['country']) /*||
                    !is_array($order->delivery['country']) || !array_key_exists('id', $order->delivery['country'])*/) {
                    $messageStack->add(WARNING_ADDRESS_COUNTRY_NOT_FOUND, 'warning');
            }

---

NOTE: Also make sure you apply all known bugfixes for Edit Orders 4.1.4. Some examples (there may be others, but these two come to mind): bugfix when downloadable products are disabled and coupon validation functions are missing from the Zen Cart admin.

---

This issue is happening now to me after upgrading from 1.5.5 to 2.1. It was never an issue before. I don't pretend to edit the orders that are there but I can't make the suggested adjustments to the code because I manage both physical and digital products/services. Will this be an issue in the future when someone orders something that's digital? Will I be able to edit the orders? This will be useless then.

Ok, so after my post I saw wsworx's post and I uninstalled it (v5 is what I had). When searching for answers I looked for "countries" or similar to my error. I didn't know that version was on beta; BUT, I am having a lot of language files warnings with 4.7.1 version (and I see the fix for those were posted, so I will fix them and continue).

Thanks!

EO 4.7.1/ZC 2.0.0/ PHP 8.2

Customer edited an order and added a misc cost, which they renamed. The configuration for misc cost allows title changes.
Updated the order. Order shows correct new total, but does not show the line item for the misc cost. This seems to be a new behavior compared to 1.5.8.

Have you seen this before? Haven't tried to repro but they say it has happened multiple times.

Zen version 210
When editing an order, adding a quantity to order, order does update with new quantity but customer details only line item still shows original quantity, but total is correct.
Also after editing an order how do I suppress all the extra info like the update info that goes into the comments?

Quote:

---

Originally Posted by jimmie

Zen version 210
When editing an order, adding a quantity to order, order does update with new quantity but customer details only line item still shows original quantity, but total is correct.
Also after editing an order how do I suppress all the extra info like the update info that goes into the comments?

---

What version of EO is in use?

If you're referring to the customer-hidden comments that EO-5 adds to identify the changes that an admin has made, that suppression is not supported.

Quote:

---

Originally Posted by lat9

What version of EO is in use?

If you're referring to the customer-hidden comments that EO-5 adds to identify the changes that an admin has made, that suppression is not supported.

---

Yes, eo5. My mistake on suppressing comments she's been printing from the admin, that's why she she's the comments, but that is the only area we can tell if a order has been changed, the order itself never changes quantity, but order total changes. If I log into customers account and look at edited ordered it shows them only 1 x some product = unit price 11.40 total 22.80

Quote:

---

Originally Posted by jimmie

Yes, eo5. My mistake on suppressing comments she's been printing from the admin, that's why she she's the comments, but that is the only area we can tell if a order has been changed, the order itself never changes quantity, but order total changes. If I log into customers account and look at edited ordered it shows them only 1 x some product = unit price 11.40 total 22.80

---

There have been a number of EO-5 pre-releases. I've tried to replicate your issue using EO5-rc1 and cannot. Please retry with that release-candidate.

ZC 2.1
PHP 8.3
customer_tax_exempt_2.0.2
edit_orders-5.0.0
sitemapxml-4.0.3
usps-USPS_2024_08_25_K11l
zen_Image-Handler-5.3.5
zen_TyPackageTracker-5.0.0

Hi lat9

Is there a function in EO5 to allow adding the shipping address to an invoice if someone has checked out using "Walk In" instead of selecting a shipping option?
If not, can an Edit option be added for that purpose?

Attachment 20925

Quote:

---

Originally Posted by wsworx

ZC 2.1
PHP 8.3
customer_tax_exempt_2.0.2
edit_orders-5.0.0
sitemapxml-4.0.3
usps-USPS_2024_08_25_K11l
zen_Image-Handler-5.3.5
zen_TyPackageTracker-5.0.0

Hi lat9

Is there a function in EO5 to allow adding the shipping address to an invoice if someone has checked out using "Walk In" instead of selecting a shipping option?
If not, can an Edit option be added for that purpose?

Attachment 20925

---

EO-5 is simply mimicking the base Zen Cart's Orders, Invoices and Packing Slip functionality in this. Note, too, that changing the address in EO without also changing the shipping module from "storepickup" will have no effect on that address' display in invoices and packingslips.

Edit Orders v5.0.0 is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2400

This version requires Zen Cart 2.1.0 or later; it will not work with prior versions!

See the plugin's wiki articles for additional information: https://github.com/lat9/edit_orders/wiki

Fantastic progress, @lat9!

I will be updating the documentation shortly to point users of ZC 2.1.0 to the new plugin.

Hello,

I just installed on my local test site ZC version 2.1.0 running PHP version: 8.0.30. Plugins manager indicating that it is installed but there no new buttons on the orders page to edit the order

Quote:

---

Originally Posted by allmart

Hello,

I just installed on my local test site ZC version 2.1.0 running PHP version: 8.0.30. Plugins manager indicating that it is installed but there no new buttons on the orders page to edit the order

---

What are the site's configuration settings for Edit Orders?

Edit Orders is not appearing in the configuration drop-down

Quote:

---

Originally Posted by allmart

Edit Orders is not appearing in the configuration drop-down

---

Any admin debug logs?

sorry but no.

Attachment 20945
I was able to access my configuration setting manually after finding the id in phpMyAdmin

Quote:

---

Originally Posted by allmart

Attachment 20945
I was able to access my configuration setting manually after finding the id in phpMyAdmin

---

Was there a previous version of EO installed?

no, I uninstalled it, re-installed it, cleaned first but no change, still not showing in my configuration drop down

Quote:

---

Originally Posted by allmart

no, I uninstalled it, re-installed it, cleaned first but no change, still not showing in my configuration drop down

---

I can't fathom what the underlying issue is.

I'll suggest (a) uninstall and (b) remove the zc_plugins/EditOrders directory and all files.

Then re-copy that file-set from the EO distribution and try again.

Quote:

---

Originally Posted by swguy

Fantastic progress, @lat9!

I will be updating the documentation shortly to point users of ZC 2.1.0 to the new plugin.

---

I second that and anyone that hasn't donated yet for all this work, in addition to all the other done, needs to stop what they're doing and donate right now. :yes::yes:


https://www.paypal.com/paypalme/lat9...locale.x=en_US

Did a clean install, works now ... thanks!!!

v5.0.1 of Edit Orders is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2400

This release contains changes associated with these GitHub issues:

#324: Correct property 'scope'.
#323: Correct MySQL error when a customer's telephone and/or email-address are changed.