Re: Image Lazy Loader for the product listing page
Quote:
Originally Posted by
DivaVocals
What you did was awesome.. I didn't want to step on toes which is why I wanted to check in with the queen (dat be you!:laugh:) before I just did stuff all willy nilly..
And yes you DO need to create a Github repo missy!!:laugh: If you decide to create a Github repo for this module, I can fork it and create a pull request for you to review my changes, or if you're okay with it, I can simply package and submit the changes..
Would be nice if this little gem could work on the centerboxes as well.. I tried to apply similar changes to the centerbox module files, and got the spinning icon, but no image load.. :blink:
Did you ever get this package up yet with the fixes diva?
Re: Image Lazy Loader for the product listing page
Quote:
Originally Posted by
countrycharm
Did you ever get this package up yet with the fixes diva?
Nope.. been swamped.. sorry..
Re: Image Lazy Loader for the product listing page
Quote:
Originally Posted by
DivaVocals
Nope.. been swamped.. sorry..
Quite understandable:D
Re: Image Lazy Loader for the product listing page
Quote:
Originally Posted by
countrycharm
Quite understandable:D
If Delia creates a Github repo for this I can submit it as a fork and pull request..
Re: Image Lazy Loader for the product listing page
Quote:
Originally Posted by
countrycharm
Did you ever get this package up yet with the fixes diva?
Quote:
Originally Posted by
DivaVocals
If Delia creates a Github repo for this I can submit it as a fork and pull request..
Created a Github repo with my changes.. https://github.com/DivaVocals/zen_ZenCartLazyLoader
Re: Image Lazy Loader for the product listing page
well, dang I saw the first post and didn't see the second but really that was all the files anyway Diva. Now that I have successfully done the first one, I set up the other one we were talking about.
Re: Image Lazy Loader for the product listing page
Quote:
Originally Posted by
delia
well, dang I saw the first post and didn't see the second but really that was all the files anyway Diva. Now that I have successfully done the first one, I set up the other one we were talking about.
You have a Githubrepo now??? If you do, gimme the link and I'll submit a pull request with my updates.. :smile:
Re: Image Lazy Loader for the product listing page
ha, deleted it when I saw you had put one up for that. I have no files beyond what is in the download package.
Re: Image Lazy Loader for the product listing page
Quote:
Originally Posted by
delia
ha, deleted it when I saw you had put one up for that. I have no files beyond what is in the download package.
Don't delete it.. I was gonna submit a pull request to your Github repo so you could review my updates, and if you agree/approve you can accept my pull request and then submit the updates.. (that's how folks submit updates to the modules I have been maintaining that I've put up on Github)
Re: Image Lazy Loader for the product listing page