Printable View
Hi,Quote:
Originally Posted by Merlinpa1969
I just updated the original module so it runs on both PHP4 and PHP5. It does not require libxml since it doesn't use any of the DOM functions for constructing and parsing XML. The only requirement is cURL (libcurl) installed and enabled on your server.
Hope this helps,
Jacob
Aha! That makes sense. I haven't seen that before. The format did look rather peculiar to me . . .Quote:
Originally Posted by willalbro
Kool looks good,
will you make this more user friendly ( zen user )
and for more than just the 1.3.0
4 out of 5 hunks fail in our 1.3.5 demo ( has mods )
Jacob,
I have a few questions about the purpose of some of the code altered in core files.
1. /admin/modules.php
I don't see anything that requires this edition of the added makeSqlString() function. You declare this same function in two other places, but this is the only one that is set to return a value enclosed by $single_quote. Again, it seems that this file does not need to be touched, as this sole function is not used from here.
2. /admin/orders.php
I don't see anything in your code that uses the $payment_value variable defined:
$payment_value= MODULE_PAYMENT_GOOGLECHECKOUT_TEXT_TITLE;
3. two of your added files are duplicated, with ~ appended to the filename. I gather these are simply backups generated by an editor? However, since they are identical to each other, they don't appear to be merely backups. I see no references to ~ elsewhere in your changes, so it appears these files are not used/required.
Ok...I bitched enough yesterday and I have since decided to get back to being solution minded. I downloaded version 1.3.0 and applied the patch. Following is the command line output. In short one hunk failed and that block of code is a comment and is inconsequential.
patch -p1 </home/will/Test/zen- cart-v1.3.0-full-fileset/google-checkout-zencart.patch
patching file admin/includes/functions/general.php
Hunk #1 FAILED at 17.
1 out of 3 hunks FAILED -- saving rejects to file admin/includes/functions/gener al.php.rej
patching file admin/modules.php
patching file admin/orders.php
patching file googlecheckout/gcheckout.php
patching file googlecheckout/gcheckout.php~
patching file googlecheckout/response_error.log
patching file googlecheckout/response_message.log
patching file googlecheckout/responsehandler.php
patching file googlecheckout/xmlparser.php
patching file googlecheckout/xmlbuilder.php
patching file includes/languages/english/modules/payment/googlecheckout.php
patching file includes/modules/payment/googlecheckout.php
patching file includes/modules/payment/googlecheckout.php~
patching file includes/templates/template_default/templates/tpl_checkout_payment _default.php
patching file includes/templates/template_default/templates/tpl_login_default.ph p
patching file includes/templates/template_default/templates/tpl_shopping_cart_de fault.php
(Following is the general.php.rej hunk that failed, as you can see it's a comment.:)
***************
*** 17,23 ****
// | to obtain it through the world-wide-web, please send a note to |
// | license AT zen-cart DOT com so we can mail you a copy immediately. |
// +----------------------------------------------------------------------+
- // $Id: general.php 4316 2006-08-28 21:27:21Z drbyte $
//
////
--- 17,23 ----
// | to obtain it through the world-wide-web, please send a note to |
// | license AT zen-cart DOT com so we can mail you a copy immediately. |
// +----------------------------------------------------------------------+
+ // $Id: general.php 3415 2006-04-11 04:51:22Z drbyte $
//
////
I am going to now patch this file set into 1.3.5 or upgrade 1.3.0 to 1.3.5...or maybe I will take the files and make them into a Zen Friendly mod that would install the standard way?...any feedback?
Thanks,
Will
www.brooksestore.com
If you do, please post it here for the masses :D.Quote:
Originally Posted by willalbro
Ok...I made it into a zen friendly mod that can be installed and used right away :-D
I submitted it into the downloads section and it is under review. In the meantime you can find it here:
www.brooksestore.com/eStore/Google_Checkout.zip
Use it at your own risk and have fun. BTW it's on my site and functions great.
God Bless!
Will
Brooks eStore
www.brooksestore.com
does it integrate with super orders?
Personally, Im not sure. It is exactly what google coded, except I ran the patch utility on a fresh, non-modded 1.3.0 version and then used a file comparing utility to upgrade google_checkout to a fresh, non-modded version of 1.3.5.
I would guess yes, but I would test it on a non-production store.
Best of luck!
Will
www.brooksestore.com
Will,
Thanks for your efforts. They are appreciated.
I took it one step further for you ...
I did the same thing last night, and when I studied the code changes while converting to 1.3.5, I came up with a number of changes to the code in order to make it more Zen-friendly and easier to plug in, etc. Some of the issues encountered are listed earlier in this thread in the form of questions.
Like you, I've packaged it as a set of files which can be uploaded by FTP. The readme explains which files should be modified to suit your own custom template, etc.
Extraneous unused code is also removed from the updated module.
The update is now available as an update to the original contribution:
http://www.zen-cart.com/index.php?ma...roducts_id=314