Sounds like white font on white background or somethingQuote:
Originally Posted by scubes13
Printable View
Sounds like white font on white background or somethingQuote:
Originally Posted by scubes13
I have not downloaded this contribution yet. Looking through the thread I wanted to know if you can have a tab that will display the reviews of the product? It appears this would be a hard coded tab like "Customers Also Purchased" tab?
Thanks
It was discussed as one of the original ideas but it will be added to a later release, so not yet.
Anyone yet adapt the Tabbed Lite 2.7a version to support Cross Sell images or Ask A Question button. Being able to place Cross Sell (We Also Recommend) into a tab would be especially cool. I have attempted but so far no success.
Below is the necessary code that inserted into tpl_product_info_display.php
Cross Sell images:
Ask A Question button:Code:<!--bof xsell module-->
<?php
require($template->get_template_dir('tpl_modules_xsell_products.php', DIR_WS_TEMPLATE, $current_page_base,'templates'). '/' . 'tpl_modules_xsell_products.php');
?>
<!--eof xsell module-->
WoodyCode:<!--bof Ask A Question button -->
<?php
if ($flag_show_product_info_ask_question == 1) { ?>
<div id="productAskQuestionLink" class="buttonRow forward"><?php echo ($flag_show_product_info_ask_question == 1 ? '<a href="' . zen_href_link(FILENAME_ASK_QUESTION, 'products_id=' . $_GET['products_id']) . '">' . zen_image_button(BUTTON_IMAGE_ASK_QUESTION, BUTTON_ASK_QUESTION_ALT) . '</a>' : ''); ?></div>
<?php
}
?>
<!--eof Ask A Question button -->
I just install V2.7, but got error
Parse error: parse error, unexpected $end in C:\wamp\www\includes\templates\ilync\templates\tpl_product_info_display.php on line 680
any idea?
Thanks
ERIC
Updated version "2.7a" has been released but it does not look to be yet available in Zen Cart downloads area.Quote:
Originally Posted by ericpeng
To obtain patch see qhome post #88 . Download and replace tpl_product_info_display.php (or you easily make the two minor edits yourself). Then report back.
Your issue is likely with:
if ($bCustomerAlsoPurchased === false) {
Should be :
if ($bCustomersAlsoPurchased === false) {
Note the "s" needs added to the end of Customer
If this does not repair and you reeive an error report identifying a line number, open the file in a text editor that shows line numbers, and identify and report back with the code on that line, and also just before and just after that line (provide a brief code snippet).
Woody
Thanks for your reply. I tried the bugs on #88 but still the same problem.Quote:
Originally Posted by Woodymon
The 2.7a is availiable.But I got the same problem.
Parse error: parse error, unexpected $end in C:\wamp\www\includes\templates\ilync\templates\tpl_product_info_display.php on line 681
I found the problem is in Line#134Quote:
Originally Posted by ericpeng
change <? to <?php
Good catch. Time for v.2.7b ;)Quote:
Originally Posted by ericpeng
Just downloaded v.2.7a. Besides the two reported diffs between v2.7a and v2.7, I note one other diff which was not previosuly reported. Looks insignificant, but just checking.
2.7 line 476 shows:
echo '</div>'; //ditch-tab-pane-wrap
2.7a line 476 shows:
echo '</div id="duh">'; //ditch-tab-pane-wrap
- Woody
BWAHAHA! that was my way of finding out which div was which lol! When I was trying to find the problem with the table ending, I was trying to see how many times it looped through so I put that little identifier on there :P
I'll remove it and fix that <? tag for the next version.
I'll also take a look at cross sell. It should be pretty easy to make it a tab and Ill try to document how I do it.
CrossSell added to tabs in 10 steps :)
DEMO: http://www.unbannable.com/zen/index....&products_id=1
Attached a zip.. inside has 10 steps to adding the CrossSell Contrib as a tab. These 10 steps can also be a template to follow for adding any others.
Also included the completed tpl file for those who don't want to take the time adding those steps by themselves.
(Also fixed the <? and duh bugs mentioned above)
Thanks guys!
Is this a bug?
In admin panel - product description :
<!--%Product Description%-->
Line1
<!--%Extra Specs%-->
Line2
The 'Extra Specs' tab won't work.(left hand side bottom - error on page.)
But if I add <!--#AdditionalImages#--> to the bottom, then it works fine.
------------------
This is a great contribution, it makes the website looks much much better.
I just think if the tab could be apeared in admin panel(WYSIWYG), it'll be perfect.
Thank you
ERIC
Quote:
Originally Posted by ericpeng
Hmm Im trying this on my demo site and its working fine with and without the <!--#AdditionalImages#--> tag. can you post or PM the full description you are using that doesn't work.
It originally was. There is a TabbedProducts nonlite version that creates a whole new product type. But that requires a database field to be added for each tab you want. And it was too hard to customize.. thats why I switched to the this "tag" method so it could be done on a per-product level.Quote:
Originally Posted by ericpeng
ECKK.. i see it now. I removed the text before the tabs and i see the problem you are having now.. crraaaaappp
Ok ill take a look.. you can blame woodymon for needing all these extra features (LOL j/k) :)
[QUOTE=qhome]Hmm Im trying this on my demo site and its working fine with and without the <!--#AdditionalImages#--> tag. can you post or PM the full description you are using that doesn't work.
I tried again and same problem.
<!--%Product Description%-->
Detailed Product Description
512M Memory
<!--%Test%-->
This is another tab named test
That's all I have in products description.
Quote:
Originally Posted by ericpeng
FIXED:
FIND (TWICE!!) :
REPLACE WITH (TWICE!!) :Code:if (($chkTabStart && $chkTabEnd) || ($bAdditionalImages || $bProductDetails || $bCustomersAlsoPurchased)) {
I was using absolute string value check.. but if the tags weren't used, it sets the value of the chktabstart and end to -1 which is infact a real value...Code:if (($chkTabStart >= 0 && $chkTabEnd >= 0) || ($bAdditionalImages || $bProductDetails || $bCustomersAlsoPurchased) {
Thanks eric :)
I changed on Line# 261 and Line# 415 and it works.Quote:
Originally Posted by qhome
Thank you so much.
I think change the line #133 to <br class="clearBoth" /> will be a good idea(in case of big prodcut image).
Thansks again
ERIC
FYI - don't know if you've noticed this yet (haven't read the whole thread) but the first tab fits nicely in a small browser width but going to the second tab makes it jump off the right side of the screen.
I don't have the same problem.Quote:
Originally Posted by denliv
But I noticed the tabs will be disapered, when in certain width. If you make the browser's width a little bit biger or smaller, then it'll come out again.
Hmm I'm not sure waht u mean.. Alll the tabs are liquid(by default).. so they shift with the width.. so even if u had a 3 inch browser window.. u'd see all the tabs on top of each other.Quote:
Originally Posted by denliv
Sorry - the tabs are showing. I just mean the window of the second tab is to wide to fit in a narrow browser, say 800 pixels wide, whereas the window for the first tab fits it just fine.
Hmm thats a FF or IE thing and only happens when u change tabs while the window is small I think.. thats not really exclusive to the contrib tho.. that would happen with all tables and content I think.Quote:
Originally Posted by denliv
On a side note... I've attached the latest and greatest patched versions just so we dont lose track.
There are only the template files in this zip. One for WITH Cross Sell.. one for WITHOUT.
I'll let these get tested a bit more before making another official release in the download section.
Not sure if you know about this but I just dumped 3700 products to the database using the tab delimiters in the product description. Now the source data looks 100% fine, but only 90% of the actual products in the store have correctly formatted tabs. The rest are messed up - i.e. they show code --valid html transitional --> and also the layout of the tab is all wrong. (It is difficult to describe)
I have checked, checked and checked again the integrity of the source data being uploaded. No idea why this is not working - everything in the source data looks perfectly fine and as it should. I am thinking people who use the likes of Easypopulate will come across this issue at some point.
Is there any way to achieve the Tabbed look without having additional tabs (e.g. product_info just has one single tab with everything inside it). I ask because until I have figure dout why a bulk data upload does not work, it makes sense not to use the tab delimiters but have pure CSS instead.
This would actually be a neat idea anyway - have a default single tab layout for when you are not using tabbed delimiters. Then the product_info layout would look pretty seamless.
This is definitely an awesome mod but it is kinda confusing to move things around such as the Add to Card since there are numerous of them.
Is there any hint on which ones to move?
Do you have a site I can take a look at and see this? I will try it easy populate on my test site this weekend.Quote:
Originally Posted by JollyJim
Also quote the text in your description just to see if maybe there is something that I may have come across in creation that looks familiar.
(PM it to me if you like)
For tabbed layout, you mean just 1 tab that isn't really a tab, but looks like a tab? I guess if you only use one <!--%tabname%--> it would show it all as one tab.. if thats what you mean.Quote:
Originally Posted by JollyJim
Yes, in the code, there is a big block that says "END OF TAB PARSE CODE" (around line 535). everything under that is the original stuff with the addition of the If statements, but that shouldn't affect where u move it to. Just copy everything in between the bof/eof tags (and the tags as well)Quote:
Originally Posted by Berserker
Thanks for the quick reply.
Do you have to add the <br /> tag at the end of every tab?
Shouldn't have to. I added table tags to help make the separate the data for moments like when Javascript is turned off so you should no longer need the BRQuote:
Originally Posted by Berserker
Woodymon, empty your PM box.. its full and i cant reply!
Hi qhome. This is a really nice mod :yes: many thx.
It may be a quirk to do with my template, but I found that to get the tabs to work I had to add some HTML code *before* the first tab delimiter in the product description. Any code will do (for example an empty paragraph tag set) but without doing this, the tabs just didn't show for me.
Other than that, it works a treat... up to now!
It's a shame HTMLEditor doesnt show markers for comment tags in wysiwyg mode.
Yea, there is a patch version that should fix that problem here:Quote:
Originally Posted by Peekay
http://www.zen-cart.com/forum/showpo...&postcount=124
That fixed it!. Thx.
I have mostly items of the 'document-product' product type and they use a different template (tpl_document_product_info_display.php).
To get the tabs, I just copied your replacement for the 'ordinary' product template and renamed it. Seems to work, but are there any differences I may not be aware of between these two templates?
Actually... I've found I still have to put a para tag before the first tab delimiter to get the tab links to work. It's not really a problem though.
Quote:
Originally Posted by Peekay
Hmm i will have to do some further testing.. how many tabs are you using? are you using of the Core feature tabs (hardcode tags) like additionalimages or customersalsopurchased?
Just 2 tabs in my tests. I don't have any extra images or anything. There are some radio-button product options. If I use the code:
the links in the tab work, but if I putCode:<p><!--%Item Description%-->Item description text goes here.</p>
<!--%Extra Info%--><p>Some extra information...</p>
the tabs are generated, but the links don't work.Code:<!--%Item Description%--><p>Item description text goes here.</p>
<!--%Extra Info%--><p>Some extra information...</p>
You seem to have not replaced that version with the 2.7c version from above. It is fixed in that version for sure.
KILLER CONTIB..... makes things look sooo much better....
anyone else having a problem with there attributes?
for some reason my atributes dont show the added cost? when i preview it displays fine, its just not working on the displayed page. anyone know of a fix for this?
i merged the two tpl files, but there are so many changes i cant see where it might be....
any help would be great. thanks
Hi ,
is this contrib compatible with the old ZC version?
thanks
:smartass:
Got a link to your site?Quote:
Originally Posted by wickedklown
Unfortunately no because it wasn't until 1.3 that they changed from a table based product info to a <div> based page, So while functionally it would work, it doesn't have the same display style the old one had.Quote:
Originally Posted by titangen
http://www.myrcsupply.net/index.php?...roducts_id=575
there is a link to one of them that isnt working.... if you put the item in your cart, you will see that it does actualy rase the price, but it dont display it....
Quote:
Originally Posted by wickedklown
I dont see any attributes for that item. I see only the default price and thats what I see in the cart. Also, I would suggest taking a look at your site in the Opera Browser.. it is quite messed up looking.. While this maybe an Opera problem, its something that you would have to control on your end until they fix it.
Quote:
Originally Posted by qhome
Im sorry i was playing around with it tring to get it to work.... Its back up now and listed with the attributes....
On your comment about the site in the Opera browser, does all ZENcarts have this issue? or just mine? I dont see how it could be any worse than others becuase i use the classic template which i have just modified the images.... I suppose ill have to download that broswer and take a look.
any advice on the attribute not displaying the price would be great. Like i said, if you go to the checkout you will notice that it does correctly add the price to the total....
well i checked it in Opera, and it seems that my mainpage is what is making it do that in that browser. Im not sure how to fix it since there are no tables or anything used in my main_page. It looks fine in both FF and IE. I wonder how manny users are actualy using Opera to browse.
you happen to know a fix for this? or maybe i can make a donation for your time to help me fix this issue....
let me know
Thanks
Yes, sorry i should have added this to the original post. This is a zen-cart 1.3 issue with the top category bar. The Category bar for whatever reason doesn't autowrap with Opera, so it stretches the page out to fit it all inside.
option1: Remove the top categories bar
option2: look at how the top categories bar is coded and see if there is anything wrong there or maybe its in Opera. Perhaps you can add php code to add <br /> tags after every 6 categories, but that will leave you with some weirdness if you only have 7 categories as there would be one by himself on the next line.
option3: Maybe you could get fancy and calculate how many would go on each row based on the total. But that is wasted overkill for something like this. It really should wrap natively and Opera has no problem with wrapping normally so I think it would be a zen cart implementation problem. Sometimes what works isn't always whats proper.. but i haven't looked myself.
Quote:
Originally Posted by qhome
LOLZ, how do i remove the top catagory bar from the site. I cant seem to find the toggle in the menu... where is it located?
NEVERMIND I FIXED IT...
This has been removed from the download area...is there a reason for this?
Where can i find the latest version?/
Thanks
It's there. In Downloads under Templates (#11 on second page)Quote:
Originally Posted by splieg
Thanks!! It was under Product types before...hence the mix up on my part.
cheers
The very original version, non "LITE" version, was in Product Types. Now deprecated.Quote:
Originally Posted by splieg
This doesn't appear to be a Tabbed-LITE problem. Perhaps this should be posted in the General Questions area to get more exposure from those that might be a bit more savvy with this type of problem.Quote:
Originally Posted by wickedklown
ya iv figgured that out...
It seems that its a problem with this price markup calculater that im currently running. I love the contrib so i need to find a fix..
anyone happen to know there stuff, and have some time to make some extra cash???
that wouldbe great...
I have listed this problem in another catagory thats why i have found this information.
The problem is with functions_prices.php file that has been modified for the PMC contrib.
thanks for your help its much appriciated
Cool Mod. I will test it out on my new site.
I'd like to always display the "add to cart" & "Atrribute Options" as a whole new tab.
Right now, it must be hardcode tags only (at least one applied), then you can have a new tab.
How can I change the code to always have a new tab for "add to cart" & "Atrribute Options"?
Thanks
Hi Eric,Quote:
Originally Posted by ericpeng
I have actually been working on some new, better looking, and properly transparent cornered tabs. I will look into that option you requested as well.
For now, sneak a peak at the upcoming version. I have added rollover as well.
http://www.unbannable.com/zen/index....&products_id=1
I still have to add the noscript stuff, but they work properly and have no problems on different color backgrounds. Plus the script is about 10 times more efficient and extremely small.
Q-Quote:
Originally Posted by qhome
Nice job advancing the quality/features in your TabbedLite mod.
Yes global tab settings would be a nice feature. Therefore wouldn't have to customize tabs for each individual product (which can be quite a task for shops with large number of products), but allow overriding of global tabs config if wanted custom tabs layout for specific product(s).
Woody
Hi,Quote:
Originally Posted by qhome
Thanks for the great contribution.
The reason I'd like to have the attribute option in a single tab is because it's a long list. It'll make the page funny. Actually I think you should allow all the tabs to be independant, then the page will have Image on left, product name & price on right and a beautiful tabs block on bottom.
I'm just wondering: around how long will it take for your new version to come out? I'm really looking forward to try it out. And again, thank you for this great idea and a well-designed program.
Eric
Hmm Im not sure what you mean here. You can do that already. simpy remove "<!--#MainImage#-->" from the product description. unless I dont understandQuote:
Originally Posted by ericpeng
Funny, I removed global settings to give more flexibility, now its too flexible :P But I guess it would be good to have globals with overrides too.Quote:
Originally Posted by Woodymon
Do you suppose it would be easier or more confusing to "include" the tabs in a separate php file and then you would need only to add the include tag to your tpl file stating where you would want the tabs to show up? There would still be the need to add logic for "if inside tabs, do not show outside tabs", but I'm toying with the idea to think if that would work better.
I'm just racking my brain on how to make this more plugin-able, without the need for massive design changes.. but i dont know if its possible considering the fact that it has so much logic on the rest of the pieces.
Hi qhome,
first of all, thank for sharing this great contribution to zen-cart.
I did have a problem this June-13rd version of Tabbed Products LITE.
http://epad.cn/bookstore/index.php?m...oducts_id=7608
The tabs are showing perfectly in Firefox, no luck in IE so far.
I went through your demo site of Tabbed Products LITE and it is showing correctly both in FireFox and IE.
So, would you mind giving a shot at the above link and help me out,
Really appreicate,
Nick
Tried this on 1.3.0.2 and nothing works, the html editor seems to strip out the command lines.
Any fixes on this for 1.3.0.2???
mine works fine !
Thanks for the great contrib ! it's just great !
Well, I installed this in a fresh install. I also installed the update and use both French and English.
But, nothing works in tabbed mode, tried various ways and nothing. so something is not right unless I missed something, which is rare. The install of this is pretty straightforward unless there is a need to merge the css stylesheets or add a call to the css for this.
???
DOH
took it for granted,,,
Overlooked that you need to merge the css comments into your current css stylesheet and then it works.
Not enough coffee:smartass:
This is not a version thing. Since the commands are raw HTML, you would need to use the raw HTML editor for them, not HTMLArea or FCKEditor.Quote:
Originally Posted by IntelCos
Do you have a link that I can see it on?
Hmm there is no merging. The file structure is the way it should be uploaded, except that you would need to rename the "YOUR TEMPLATE" folder. The stylesheet is its own stylesheet.Quote:
Originally Posted by IntelCos
Please help out. I really appricate it.Quote:
Originally Posted by nick80
thanks.
nick
btw, I went through your site and I know it is working well in IE.
Hmm, i just checked your site in Opera, Firefox, and IE. The tabs worked fine for me in all 3. What version of IE are you using? Try another computer to test it out.. and maybe some others on the forum cant take a look at it to verify but it seems that the tabs are working just fine.Quote:
Originally Posted by nick80
I will have a new version coming out pretty soon.. this version is cleaner and also works on the major browsers I mentioned above, perhaps this will assist you.
So far in the new version I've added:
- global overrides (when turned on, they add the hardcode tabs for all products regardless of the tag existence in the product description) (thanks for the idea Woody)
- found an interesting by-product feature of the code! You may notice on my test site (see signature) I have tabs that have text with word wrapping. The text is also centered and I could pretty much do anything I want with the tabs by using standard html tags inside the tags. Examples:
- <!--%<center>Product<br />Description</center>%-->
- <!--%<I>Product<br /><font color="#00FF00">Description</I>%-->
- <!--%<marquee>Product<br />Description</marquee>%-->
- Roll over change
- using 2 images instead of 4, based on coords to show different sections of the image. (fancy ingenious code design)
- Cleaner, easier to modify/understand CSS
- Completely new tab system, totally new, smaller, optimized jscript
I'm finishing up the testing at the moment. Currently the Add to cart button, although it appears to be coded correctly, is showing up below the tab table on all browsers. And IE seems to have some problem with one of the hardcode tags. So as soon as I get those items fixed, it should be ready.
Another idea crossed my mind that I'd like to get some feedback on...
Instead of making the hardcode tabs based on the <!--#AdditionalImages#--> name, would it be useful to make a hard coded tag placed on the tab you want?
Like currently if you put
<!--%Tab1%-->
<!--%Tab2%-->
<!--#AdditionalImages#-->
<!--#ProductDetails#-->
that would make 4 tabs:
Tab1
Tab2
Additional Images
Product Details
But my proposal above would be
<!--%Tab1%-->
<!--%Tab2%-->
<!--%Tab3%-->
<!--&AdditionalImages&-->
<!--&ProductDetails&-->
This would make 3 tabs and have both additional images and product details on the same tab which you named "Tab3". This would allow combining of multiple sections into one tab.
I could maybe keep the current hardcode tags for global tab reasons.
Thoughts?
Started working on a slightly different style that I kinda liked:
http://www.unbannable.com/zen/index....=index&cPath=1
look at each of those, one has tabs for everything, one just has tabs for the hardcoded stuff
Hi there,Quote:
Originally Posted by qhome
I've checked your demo site about the new features, wow ~~~
Beautiful, kind of impressive.
I still have no clue about the Tabbed Products not showing in IE. My IE is 6.0 XP-SP2 version. I also tried maxton (an IE shell) and got no luck.
The opera does run the rendering very well though.
Thank you so much and I still have to find the problem........
I like this one. Good point. Maybe you can also delicate a tab for Manufactory / Author.Quote:
Originally Posted by qhome
Great contrib...Is there a way to move the tabs up the page, currently they are too low on the description page.
Thanks
Pete
Hi Pete,Quote:
Originally Posted by mediathing
You can edit the tpl file and search for <br /><br /><br /><br />
you can remove some of those to move it back up.
qhome, this is great work you're doing here! I haven't had the chance to test it but I frequently check this forum as well as your test site.
I was wondering...when this is all said and done, how easy would it to migrate the code changes from the general product template to music product type template.
The reason I am asking is because that's where I see the most benefit for me. For example, take a look at this page which is based on music product type: http://www.clevershoppers.com/index....products_id=82 I would like all the descriptions to be on one tab, the track listing to be on another tab, customer purchased and cross sell to be on another tab. This would be consisten for all the music CDs and DVDs.
What's are your thoughts?
Thanks!
Well it would actually be quite easy. I am not totally familiar with the music product type yet but either way its really not hard to get to work on any product type. I can probably do it for you in a day.Quote:
Originally Posted by BlessIsaacola
I'm going to look at the other product types and see what changes I would need for them and I'll get back to you.
can someone advise how to get 'additional images' to display above the tabs?
I'm too intimidated by tpl_product_info_display to start hacking without some help first...
thanks
:D
nice contribution that really adds a lot
I ended up doing a little cut & paste on tpl_product_info_display.php
in place of the spacers (br tags) located just aft of
I pasted theCode://########## Tabbed Lite Message##########
//#
//# Added these br tags here to shift ...#########
<br /><br /><br /><br />
and after some additional moving around of otherCode:<!--bof Additional Product Images -->
blah...blah...blah
<!--eof Additional Product Images -->
<!--bof xxxx -->
blah...blah...blah
<!--eof xxxx -->
it worked out great :thumbsup:
additional hint: if using IH2 - and you want the additional images to align evenly take advanage of the IH 'canvas' function by sizing 'small' images in admin/config/images with a ! and choose a background color, for example Small Image Width 100! Small Image Height 100! IH small image background 227:227:227 - this will put small images centered in the background, making them align... :sleep:
I still have a bit more space above the tabs (below additional images) than I would like, and I can't figure out how to make the tabs text bold - would appreciate suggestions. :yes:
bold text
since editor wouldn't do it, simply added font-weight : bold; to CSS
:blush:
this contribution has made a huge impact toward improving my site, thanks.
BUT.. the jscript 'investment' is high at over 32KB... is that normal?
This loads on the first page of my site too, is there anyway to reduce the size of the script and/or get it to load only on product info page?
THANKS
Even when not using any tabs the script loads on index page...quite heavy but looks great when used right.
I could probably prevent that somehow. But even so, the next version has such a small script it shouldn't be too bad.
I have an ickle suggestion that would make this cool, you could add some simple javascript buttons to the page that auctomatically puts in the correct code for the tab.
EG I want the tab to say "More Info" then I click the "More info" button that would insert the correct code for that tab into the item description. You could cut and paste the comments toolbar contrib code to do this.
Just thinking out loud here :smile:
Yea, you mean on the actual product description page in the admin. Yea I thought about that too.. actually just a generic one since people would have their own personal style of what to name the tab so click the button to addQuote:
Originally Posted by Reesy
<!--%Custom Tab%-->
and make other buttons for the hard coded tags like additional images and customers also purchased.
I need to take some time this week to put these ideas in my head to use.
Thx for your input!
I just installed your mod to my new test site. I haven't tested it out as of yet, but I was wondering is it possible to generate a tab that contains customer reviews?
Yea thats exactly what I meant sir.Quote:
Originally Posted by qhome
If you created say generic ones of say more info, extra images, also purchased it would be cool.
Its pretty easy to change the few characters of the buttons for peoples use.
Personally I think this should definately be included in the next zen cart core release as this isnt in any "other" carts AFAIK.
Ya i will be adding that in the next version if it behaves nicely.Quote:
Originally Posted by ctcentralinfo
Since I'm sorta-newbie when it comes to web stuff I don't know what the actual impact on page loading speed is but I went into the jscript and deleted most of the comments.
size of the file dropped by 11KB.
no adverse affect that I have found. less is more, right? :dontgetit
I should note that this contribution is destined for greatness
File size doesn't really matter as far as display. The renderer ignores all the comments so its really only sending a few lines of text which wouldn't be damaging unless you were on a 2400 buad connection :)Quote:
Originally Posted by wasana
Hey Q-
Just checked out http://www.unbannable.com/zen/index....&products_id=1
The new tab styles, tab colors, rollover/hover, and the word wrap inside the tab is quite cool.
Wondering with the new version will flexibility be maintained to allow display/positioning the main product image, the "Add to cart button", product attributes, and some random text above the tabs? Hope so ;-)
Although you show the style of the text in the tabs can be hard coded via HTML I assume they can also be stylelized via CSS also? Most of my customers would need larger text size, and setting a global class would be simpler for me than hard coding each tab tag.
Also if increase the text size in the tabs will the tabs resize and eventually wrap to a second tab row as previous version?
Also in your previous post regarding the new version you suggested global overrides are now implmented. Is that working out well?
And discounting my inital hope above, does the new version support displaying both the add to cart button and attributes in one tab (as eric asked about)? I see you stated there are issues with the add to cart button showing up in a tab (always shows up below the tabs).
And have you figured out yet how to place a portion of the product description text text below the tabs?
I do like the idea of allowing combining multiple sectons on one tab with the the naming convention you specified. I assume the combining would only apply to core entires on product info pages, and not mod additions (e.g. X-sell or other added mods). Or could code be manipulated to support combining tabs for mods also?
Also Reesy's suggest is a good one. On my /admin/orders.php edit page I have set up checkboxes to enable auto entering commonly used text strings into the "comments" text edit box. I used code from Grayson's PDF Order Center mod and I don't see why the same idea could not be easily applied for your mod to /admin/product.php new_product page.
Also to respond to your previous inquiry...
Yes I know you had such capability in the earlier db driven (not Lite) version ;-)Quote:
Funny, I removed global settings to give more flexibility, now its too flexible But I guess it would be good to have globals with overrides too.
Everyone wants there cake and eat it too ;-)
No qualms with the "include" solution. Although you have documented things very well that actually may end up easier for some folks to edit the template file.Quote:
Do you suppose it would be easier or more confusing to "include" the tabs in a separate php file and then you would need only to add the include tag to your tpl file stating where you would want the tabs to show up? There would still be the need to add logic for "if inside tabs, do not show outside tabs", but I'm toying with the idea to think if that would work better.
Any new updates on next TPL version? If you would like some assist testing please let me know.
Woody
When will the new files be available for download?...looks even better now!
Thanks
Pete
I have been loading up my 1.3 cart with contribs for a month now (so far so good!), and I have to say that I think this is one of the very best contribs I've seen. What I really like is that I can provide lots of info without making the page so long, before they get to the ordering part. And, if you view the page source, it's all there, all the info in all the tabs. So I gather that this is what the search engines are seeing??? I think one of the obstacles of getting zencart, oscommerce, and other sites high in the ranking is that you only get to put so much info on the page without detracting from the fact this it is a shopping cart. This contrib solves that problem.
I'm not crazy about how the tabs show up on my site, http://www.photoimprints.com/custom-...ounce-p-2.html
but I may develop custom ones later anyhow. I am starting to load up the tabs with all the questions I've been asked about products on my last shopping cart, that were hard to fit in.
Many thanks for this one!
Hi guys..
The reason for the delay is my brain trying to find better ways of doing things but it seems that people don't seem to mind the way it is so long as I comment it nicely. (And use spaces instead of tabs :) wood)
I guess I will clean up my current code and release it for now so you guys can utilize the new tabs. I have 2 sets of tab types.. the XP tabs you see here:
http://www.unbannable.com/zen/index....&products_id=1
and the other type here:
http://www.tvclassico.com/index.php?...products_id=29
Also there is the flexibility shown here to add tabs After the text as seen here:
http://www.unbannable.com/zen/index....&products_id=2
Also notice the Title bar underneath the tabs. I added that for some extra robustness.. I will add a way to disable it as well.
And the tab title wrapping is done via HTML, but the style, color, etc is done via CSS.
I'll release the next beta tomorrow then with the new tabs. Just gotta clean up the xhtml valid stuff
See qhome's new tab style on his demo page. URL is in his previous posts.Quote:
Originally Posted by styledata
Can't wait for new version ;-)
Woody
LOL, LOL ;-)Quote:
Originally Posted by qhome
Note: I had to add more than one LOL for the forum to accept this post ;-)
Just took a look at the new tab styles. I like the 3-D look. Possible to combine the tab styles to make the "foreground" tab (and mouseover tab) yellow and at the same time make all the tabs 3-D? That is best of both tab styles.
Like the new title bar and being able to toggle on/of is a great idea.
Woody
I think Tabbed Products is pushing my main page width past 100%. This page, w/out tabs looks fine: http://www.photoimprints.com/persona...auto-p-10.html . This page, with tabs, exceeds the browser: http://www.photoimprints.com/custom-...ounce-p-2.html . I have looked at the tabbed css file, but I can't tell what to change to bring it in. Does anyone know?
Thanks in advance!
Hmm.. it might be your artwork tab.. the art goes the full width of the tabs and is forcing them to stay wide in IE..Quote:
Originally Posted by styledata
The non tabbed version has the images farther down so they dont bump the right side column so they can expand a bit and breathe.
this doesn't seem to be a problem in Opera, except opera doesnt like the zc header links (no auto wrap) but thats a problem with all zc1.3 top link users and opera.
But this diagnosis is just a guess Im not 100% certain. Wait till i release the new version and see if it is still a problem with that one.
Appears fine to me in Firefox. Did not check in IE.Quote:
Originally Posted by styledata
To figure out which CSS classes apply where, install the Web Developer plugin for Firefox.
On an unrelated note your breadcrumb appears to be pushing into the categories sidebox heading.
Sharp eye on the breadcrumb! I have a scrollbar on FF and IE, being more pronounced on IE. I have looked at class and ID details in FF, and tried some different settings in the css for tabbed products, with no change. I would really like to narrow the box that holds all the tabbed comments just a tad. Can you tell me how to accomplish that?
Thank you!
Well currently the tabs are set to liquid mode, and they will only go as far as the page allows them, but like anything else, if something larger is inside them that doesn't allow breaking, they too will stretch I dont know if it will help to make them fixed but to do it you can add:Quote:
Originally Posted by styledata
width: 400px;
under both:
.ditch-tab-skin-default .ditch-tab-pane-wrap {
&
.ditch-tab-skin-default .ditch-tab-wrap {
But after looking again, I notice its your CrossSell contrib that is stretching out farther than the rest at the bottom of the page. The page stops being liquid when it reaches that contribs table.