I'd be happy to try and help you out, but I don't really understand what the problem is. I've renamed my admin directory, and this still seems to work fine for me. What problem or error are you getting?
Printable View
I'd be happy to try and help you out, but I don't really understand what the problem is. I've renamed my admin directory, and this still seems to work fine for me. What problem or error are you getting?
Thanks,
A question that might clear it all up is simply, where are the order editing files supposed to be uploaded to? All the instructions say is to upload them to the "store". I assumed that meant the main directory, but now I'm thinking that it is probably supposed to be in the admin section, because the 404 error is for a page that it is searching for in the renamed admin section.
Are these files supposed to be there?
Also, do I upload the order edit "admin" directory, or the entire edit_orders directory. As it is unpackaged, it is edit_orders/admin/includes/etc.
I appreciate your timely response.
Shepherd
Ok, while I was waiting for a reply, I pushed over the files in the admin folder and tried it again. I still get the same message, which states that FILENAME_ORDER_EDIT.php?page=1 can't be found.
Looking in the edit_orders/admin directory, there is a file edit_orders, but no file order_edit.
So, is this file misnamed, or is the command looking for the file boogered up?
Shepherd
You've copied the files to the wrong directories. After unzipping, rename the folder admin to your new admin directory name. Then, copy the files from inside the main directory - edit_orders - into the main directory of your web site.
Or, since all the files are in the admin directory, just copy the files from the admin directory to your admin directory.
Thanks for your reply. Just have one more question. If I understand you correctly, I am to rename the existing folder edit_orders/admin to match the renamed folder on my site, then copy all of the files into that folder.
Since there is already an includes folder in there, won't it overwrite those files? Or, is that what I'm supposed to do. I see many matching files that will overlay each other if copied.
Sorry, for all the hand holding, but I just want to make sure before I nuke something.
Shepherd
Never mind about that question. I backed up my files, said a little prayer and pushed the button. At long last, it works. Thanks for your help. I'm not the sharpest knife in the drawer, but you've probably figured that out.
Shepherd
srturner47,
your update fixed many issues, but... i was trying to edit an order today by adding an item to an order and got this error:
fix ideas?Quote:
1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '27.0000', products_options_id = ' at line 5
in:
[insert into orders_products_attributes set orders_id = 2043, orders_products_id = 2383, products_options = 'length', products_options_values = '3/8" x 33'', options_values_price = '27.0000', products_options_id = '23', products_options_values_id = '174', price_prefix = '';]
If you were entering information, press the BACK button in your browser and re-check the information you had entered to be sure you left no blank fields.
thanks.
I'm not 100% sure, but I think I know why you are having this problem. Your product option 3/8" x 33' ends in an apostrophe. This closes the SQL command prematurely. Try renaming your option to 3/8 " x 33 ft ... if that doesn't work try 38 in x 33 ft. Let me know if that solves the issue.
Thanks srturner47.
I will go through and change all of my options. It will be a major PITA, but worth it.
:cheers: cheers!
If you have a LOT of options to change and you are adept with SQL, you could simply export the table to CSV, use a find/replace edit in Excel and then reimport the table.
It probably wouldn't be too hard to fix this problem with some simple edits to the mod -- you'd just have to remove this character from everything. I'm a little busy right now, but I'll try to look at it at some point.
I'm having an issue with it adding the group discount rather than subtracting it.
the order checks out correctly ,but when you look at the order under edit it is adding all the totals together.
Anyone else have this issue and know what the fix for it is?
Yes, I have noticed this issue. Temporary fix is to change the discount to a negative number. This applies for coupons as well.
i got one issues.. when i update the order status, HTML email is not working. I think it is not picking up the HTML template. Text email work fine.
Does it say: $EMAIL_MESSAGE_HTML in the email instead of having any information?
yea that's right.. look like it pick up default template but not showing the information...
OK. I know what is wrong as I was just troubleshooting the same issue for another mod. I'll get to this problem as soon as I can, but I am busy, so it may be a couple of weeks. In the meantime, use text emails! :)
OK. HTML email problem is solved. I just uploaded the new version, so it should be available in a day or two. Enjoy!
Edit Orders v1.51
Link
Changelog:
1. Fixed problems with emails when HTML emails are enabled.
Edit Orders v1.52 Released!
Link
Changelog:
1. Fixed problems with coupons and gift certificates adding to total instead of subtracting.
Enjoy!
thanks, I'll get this one installed ASAP.
THANK YOU THANK YOU THANK YOU!!! New version got rid of the issues I was having ever since installing this mod.
I really need to stop working on this -- I've wasted a lot of time on this today! :) Anyway, played around with the mod and read through the forums to refresh my memory and I found a few more bugs. They're fixed. Those apostrophes and quotes are a pain to deal with. If you are updating make sure you update all files this time. Enjoy!
Version 1.53
1. Fixed problem with customer's billing information not updating.
2. Fixed problem with adding product attributes with apostrophes causing an error.
3. Fixed problem with quotes and apostrophes being ignored.
LINK
Hi there - many thanks for the mod.
I have found a bug (1.3.7 and 1.3.8) when an order has a discount amount. What happens is that the minus sign is stripped off when the edit is saved so the discount is added instead of subtracted.
Many thanks - kevstor...:smile:
Update to newest version. This was fixed in 1.52.
Thanks for your swift reply -
Im running 1.52 but the discount Im using is using quantity discounts additional module, not coupons or gift vouchers, which is set to kick in if the order is over £400.
When I go to edit the order the minus is already stripped out of the value in the text box so only shows a positive amount?
thx - Kevstor
Thats correct. There are two values Zen Cart stores in the database, and the one you see should be positive. The way Zen Cart knows it is a discount is by checking the database to see what the subtotal value is. For example, if it is a gift certificate, it stores ot_gv in the database. If it is a coupon, is uses ot_coupon. So, to fix the problem, I had Edit Orders check the database to see what type of subtotal it is, and subtract instead of add if it is a coupon or a gift certificate. The only discounts I am aware of in Zen Cart are Gift Certificates and Coupons. It seems that the modification you are using has added a new class of discount. Hence, it would not work right.
If you can poke around in your database using phpMyAdmin or some other tool to look at an SQL database and let me know what class it is storing this as I can tell you how to fix your problem. The table you will find this in is called "zen_orders_total" and the value I need to know is stored under "class".
I finally got around to installing the latest update.
now I'm getting this error every time I hit the edit button I get this error..
Fatal error: Call to undefined function zen_field_exists() in /xxxxx/xxxxxx/public_html/Zen_Cart/admin/edit_orders.php on line 84
I would guess that you are running an old version of Zen Cart. Are you using 1.3.8a?
yes, I'm running version 1.3.8a.Quote:
Originally Posted by srturner47
I got it working, it seems that one of the files failed to install when I copied them over. I reinstalled all the files and it's working now.
thanks.
Just installed Order Edit 1.53 according to instructions, and get the following error when I click "Edit" to edit an order:
Not Found
The requested URL /zencart/admin/FILENAME_ORDER_EDIT.php was not found on this server.
Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.
Looks like I'm missing a file, however I did not find it in the package. Can anyone help?
Make sure you have edit_orders.php in your admin directory.
I'm trying to install the latest version of Edit Orders (1.53) to my install of Zen-cart 1.38a/zenmagick 0.90.
The install (readme.txt) includes instructions on editing 'admin/orders.php'
INSTALLATION:
=============
1. Upload files to your store directory;
2. Make the following changes to admin/orders.php:
Find:
Replace With:Code:$contents[] = array('align' => 'center', 'text' => '<a href="' . zen_href_link(FILENAME_ORDERS, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=edit', 'NONSSL') . '">' . zen_image_button('button_edit.gif', IMAGE_EDIT) . '</a>');
The challenge is, I can't find the lines of code in orders.php to edit. I've gone back to the original install files for 1.3.8 and the code to edit is not in there.Code:$contents[] = array('align' => 'center', 'text' => '<a href="' . zen_href_link(FILENAME_ORDER_EDIT, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=edit', 'NONSSL') . '">' . zen_image_button('button_edit.gif', IMAGE_EDIT) . '</a>');
Am I missing something?
Perhaps someone could share line numbers where this code exists?
thanks in advance for your assistance.
Hi, I checked and yes I have edit_orders.php in my admin directory. Any other ideas? Thanks for responding.Quote:
Originally Posted by srturner47
-Kjohn
Kjohn, is admin/includes/extra_configures/edit_orders.php there? It looks like for some reason you don't have this line from this file being loaded:
invision, I have a slightly modified file, but for me it is on line 1082.Code:define('FILENAME_ORDER_EDIT', 'edit_orders.php');
For everyone's benefit, I found the first line to replace at line 854, the second line at line 898.
thanks again for your assistance.
Hi all.
Great Mod have been using it for a while with no problems.
However I have just implemented a new CC ON DEMAND processing Mod and have now found an oversight in the Order Editor mod.
When you edit an order using Order Editor it updates the totals stored in the Orders_ Total table but does not update the order total contained in the Orders table.
The mod that I use pulls the order value to be charged on the CC from Orders table. However if I edit and order and the total changes the total showed on ther orders.php is the same as the total stored in the orders_total but is different to the order_total stored in orders. When I process the payment the wrong un-edited value is sent.
I also presume that other scripts such as Order totals or reports may pull info from the orders table.
How can I modify the code of edit_orders.php so that as well as updating the orders_total it also updates the field order_total in the orders table.
Thanks for any assistance.
Nice catch! :) I'll try to get a bug fix out for this -- hopefully later this week.
My store sells digital downloads. I have installed Order Edit and tested it by adding a digital download product to a current order.
The item shows up as being added on the invoice however the file itself doesn't show up as an additional download that the customer can click on.
Any way I can make this work? Thanks!!
Sorry to be so impatient... Any news on this correction?Quote:
Originally Posted by srturner47
Thanks
Redmonds
sunflowertami -- I'll see if I can't fix that with the next version I release.
redmonds -- Sorry about the delay. I pushed really hard to get the Drop Ship Module v4 that I was working on out this last week, so I never got to the edit order mod. Hopefully I'll be able to address this next week.
Thanks! Your contribution is very valuable indeed and I hope that they will integrate it on the next version of zencart.
Thanks sunflowertami. Just to be clear though -- I don't want to take credit where it is not deserved. I didn't write this mod. I've sort of taken it over because no one was updating it and there were lots of bugs, but I didn't write the original code.
redmonds - your issue has been solved. Still working on sunflowertami's problem, and a couple other annoyances I've noticed. Hopefully I'll get it released later this week. :)
Hi, Another input to this module. I recently installed this to a store that did not have COWOA. When I tried to update information and send to customer, I got this error:
1054 Unknown column 'COWOA_order' in 'field list'
in:
[select customers_name, customers_email_address, orders_status, date_purchased, COWOA_order from zen_orders where orders_id = '20']
So a quick edit to this is to go into orders.php and take out the field COWOA_order, there are two in line 54 and 91.
In case you are updating this module, it would be best to have a version with COWOA and without COWOA. Thanks!
Hmmm... This mod doesn't have anything with COWOA in it. I searched the file. It appears you are searching in the orders.php file, which is part of Zen Cart, not the edit orders mod. The edit orders mod is in edit_orders.php.
Did you perhaps install and then uninstall COWOA and forget to remove instances from orders.php?
I've now successfully installed this (thanks to Invision post #135). Or have I? When I go to Edit the order, it seems that the stylesheet flips out? Yes, I can Edit the order and amend the postage but I wonder if I have made a "fat finger" error somewhere? Does that make any sense?
Oops! yes you are right. Sorry about that. I did install COWOA then decided not to use it. Anyway if any one is in the same situation they now know how to fix it!Quote:
Originally Posted by srturner47
spinnywoman -- make sure all files are in the right directories.
Hi srturner47, appreciate your work! It's a great mod.
I'm using version 1.5.3, but still have problems on the calculation of the shipping tax and group discount.
The shipping tax problem has been mentioned in some previous posts, but I didn't find the fix to that. The shipping fee is hard coded in edit_orders.php
Since the shipping tax rate varies according to the shipping address, the shipping tax rate should be retrieved from the database when needed.Code:$AddShippingTax = "0.0"; // e.g. shipping tax of 17.5% is "17.5"
The discount problem is also there. When edit an order with group discount in order_total, the mod will add the discount to the total instead of subtracting it from the total. This seems to be easy to get fixed.
BTW, I have a problem making Edit Orders mod and SplitTaxLines mod compatible. SplitTaxLines separates taxes into several lines and saves them by several rows in table order_total with same type 'ot_tax'. When I edit orders, the sum of taxe rates will be applied to each line of tax. As a result, the total tax may be doubled or tripled or more according to the number of tax lines.
Please help me out. Thanks!
stevenh76 --
I see what you mean about charging tax on shipping. I'm not quite sure how Zen Cart applies taxes to shipping, as I don't tax my shipping. But, I'll look into it.
As for the discount problem, I don't know what a group discount is. The only discounts I am aware of in Zen Cart are coupons and gift certificates. If there is another type of discount, I'd need to know what code Zen Cart uses to store it to fix this problem. Please go to phpMyAdmin in Cpanel, then find your database, and in that database find the table called "zen_orders_total". Click browse, then find a group discount line for an order. What is in the "class" field? The only two class fields that this mod subtracts for are ot_gv for gift certificates and ot_coupon for coupons. If you can give me the class code for group discounts, I can easily fix this problem.
As for the SplitTaxLine mod, it would be very difficult to make this mod compatible with the SplitTaxLine mod. Figuring out how taxes were split up and then duplicating this effort when an order is edited would be exceeding difficult as Zen Cart doesn't store any information about why taxes were added. The mod assumes you only have one tax line per order, which is Zen Cart's usual behavior without the SplitTaxLine mod. There really is no easy way to fix this. Sorry.
Hi srturner47, thanks for replying my questions so quick!
I'm working on the shipping tax also. Please keep me updated.
For the discount problem, the class of group pricing is ot_group_pricing. You can set group pricing info at "Customers>Group Pricing", which allows you to define different discount groups for your customers. And then, when editing customers's profile under "Customers>Customers", you can assign one of the discount group to your customer, so that they will always get that discount on their purchases. I guess this problem is easy to fix.
And for the SplitTaxLines mod problem, I had no clue on how to get the two mods compatible either. Finally, I've left SplitTaxLine aside. Since I don't wanna touch the core logic, I wrote some code to split the tax only when display. The taxes are manipulated and stored as it is. When displaying the tax, I just parse the title of the tax, if it's combined by several taxes, I split the title and the value and then display it in lines. In my store, the title combined by multiple taxes always appears like "5% GST #00000 + 8% PST(Ontario):". Several code blocks relating to tax display are modified. This may cause some trouble when upgrading or adding new mod. It's not decent to get this problem fixed like this, but at least I get it done in my case and it's in rush. So I don't recommend this solution to those who have the same problem. Anyway, if I have time later on, I'll try to find a better way to split the taxes.
Cheers
Steve
Stevenh76 -- Great! I'll fix the ot_group_pricing in the next version which I am working on right now.
There will be even more problems with the split tax version on the next version, as tax is also stored in the orders table, which wasn't being written before. I've fixed that, but it further complicates how the Split Tax line works. The orders_products table also has a tax line I believe that I plan to fix soon. I just don't know if there is a good way to make the edit orders mod jive with the SplitTax mod.
Still working on the shipping tax issue, but progress has been made. I've fixed the downloads issue, which actually ended up being tricky. I'm going through and trying to make sure that any other database changes that should be made are being made. There are tons of little changes that don't seem to affect anything, but may cause undesirable behaviors in certain rare situations, so I'm trying to be consistent with updates across different database tables.
This is still primarily a bug-fix release I am working on, but I think I will tag it 1.6, because it will be a major bug fix release. I'll keep you posted and hopefully have this out in the next week or so.
Agree, editing order involves so many detailed aspects. It's a hard work indeed and it's even harder to get everything run correctly. Thanks srturner47! We are all longing for the update.Quote:
Originally Posted by srturner47
:cool:
Bad News -- I've looked into the shipping tax issue and it appears that Zen Cart doesn't store any database information about whether or not taxes were charged on shipping and if so at what percentage rate. This data is only stored in the shipping module configuration.
Hence, it would be almost (I say almost because I guess you could check the name of the shipping and try to cross-reference that to the shipping type used and then find whether or not taxes were included for this type of shipping. But, this kind of flies in the face of this mod as any changes to the name of the shipping line would mess this up. Plus, shipping lines vary based on weight, so you'd have to write code for every shipping type and ignore the weight part. Too messy -- not worth it, and would fail in certain situations.) impossible to implement proper Shipping Taxes when editing an order.
So, I've thought it over, and I think the easiest and most flexible way to handle this would be to add a tax box next to the shipping amount. Unlike the products tax box, this would always default to 0% because there would be no database entry for it. If you need to add shipping taxes for an order when updating, you'd need to enter the tax amount in that box.
What do you think? Not a perfect solution, but I'm not sure a perfect solution exists. Let me know if anyone has any better ideas.
Yeah, I realized that too. There is no tax rate about shipping stored in order table. To get the correct shipping tax rate, we have to look up the configuration of appropriate shipping mod. Or I just have an idea -- can we just get the shipping tax by doing like what Zen Cart does during customer checkout procedure? I mean, we invoke the functions provided by Zen Cart. This seems to be complicated too, so I highly agree with your idea and just add an input box beside the shipping fee for shipping tax rate. Let users specify the tax rate for shipping.
Simplicity is always good!
Problems on adding new products!
When I add new product to an order, I found that the price was not correct. The price will be ok if it has no special price or other prices. But if a product has special price or quentity discount, the mod will still apply the normal price to the item. Users have to correct the price by hand.
I guess this problem is as hard as the shipping tax rate to fix. It's a quite complicated bug and we should leave it as is. The only thing that store admins should put more attention to is to check the price when they add new products.
Yes, I know about the specials pricing problem. This shouldn't be too difficult to fix, so I am hoping to have a solution to this problem when I release the new version.
The shipping tax is much more complicated as the only things stored in the database about shipping is the cost and a field that is meant to be displayed along with it. You'd have to somehow figure out which shipping type was used to determine which taxes should be applied, which would not be easy to do.
Quote:
Originally Posted by srturner47
Hi there. Triple checked. The problem seems to be with orders.php - post editing the two lines as follows. I am running 1.3.8.
Find:
$contents[] = array('align' => 'center', 'text' => '<a href="' . zen_href_link(FILENAME_ORDERS, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=edit', 'NONSSL') . '">' . zen_image_button('button_edit.gif', IMAGE_EDIT) . '</a> <a href="' . zen_href_link(FILENAME_ORDERS, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=delete', 'NONSSL') . '">' . zen_image_button('button_delete.gif', IMAGE_DELETE) . '</a>');
Replace With:
$contents[] = array('align' => 'center', 'text' => '<a href="' . zen_href_link(FILENAME_ORDER_EDIT, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=edit', 'NONSSL') . '">' . zen_image_button('button_details.gif', IMAGE_DETAILS) . '</a> <a href="' . zen_href_link(FILENAME_ORDERS, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=delete', 'NONSSL') . '">' . zen_image_button('button_delete.gif', IMAGE_DELETE) . '</a>');
Find:
$contents[] = array('align' => 'center', 'text' => '<a href="' . zen_href_link(FILENAME_ORDERS, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=edit', 'NONSSL') . '">' . zen_image_button('button_edit.gif', IMAGE_EDIT) . '</a>');
Replace With:
$contents[] = array('align' => 'center', 'text' => '<a href="' . zen_href_link(FILENAME_ORDER_EDIT, zen_get_all_get_params(array('oID', 'action')) . 'oID=' . $oInfo->orders_id . '&action=edit', 'NONSSL') . '">' . zen_image_button('button_edit.gif', IMAGE_EDIT) . '</a>');
Ruth
It is unlikely that the problem is with orders.php. Once you click edit, everything is handled in edit_orders.php.
One of our customers placed an order online using a coupon that gave them 30% off. Shortly after we received the order they emailed us to let us know that they ordered two of an item and they needed just one. So I installed this add on and I was able to change the quantity and things looked fine, but two issues:
1) the shipping did not get updated to reflect the change
2) and the tax was not figuring correctly due to the coupon. It looks like the tax was figured with the subtotal not taking the 30% off into account. So the tax was higher than it should have been. On another order with a dollar off coupon, I did a quick test and things looked like they were figured correctly(except the shipping still)
Other than that this is definatly a great add on to Zen Cart!
Thanks for the feedback. This is valuable information. I've been hard at work trying to sort out all the bugs and problems, but there are a lot of small things that need to be done, so it is taking a little longer than I thought. I just finished adding one-time attribute charges and price factors and offsets. I didn't even know what these did before I started working on this, so part of this has been discovery for me. There are sure a lot of options for an order, especially with attributes!
The shipping will never be updated automatically with this mod; you'll have to edit the shipping amount by hand. It would be too difficult to implement this, and it doesn't take much work to just change the shipping manually.
The taxes are calculated individually for each item using the assigned tax rate for that item. So, I don't think that a coupon should be calculated correctly when it comes to taxes. I'll look into this and see if the mod takes care of this somehow. If there is a problem, I'll see if there is a way to fix it.
It may be another week or so until I get this out, but the new version should fix most problems!
Great work! Looking forward to it!
I ended up doing a lot more with this than I originally intended. I've always wanted to implement a better system for handling attributes, and I've done that, as well as fixing the myriad of options that attributes have. Essentially, you can now select an attribute from a pull-down menu and any changes to the price will automatically be made. This took a boat load of new code, as there are a ton of options that Zen Cart has for attributes. Most of these options I've never used, so it took some exploration to learn what they do. Anyway, I think I've fixed them all, implemented the new attribute system, and addressed all other bugs and issues people posted. The code base grew tremendously, so I've tagged this as 2.0.
I've decided to release this exclusively through my website -- see the link in my signature below. It is still completely free (both as in beer and as in freedom), just change the options on my site to the free ones and complete the checkout process. You can always update later by simply logging in and redownloading.
Here is the changelog:
v 2.0 10/15/2008 - Scott Turner
1. Implemented new attributes handling in the following ways:
a) In addition to the more complicated attribute editor, a simpler option is available.
i) Select a new attribute from a drop-down menu in admin.
ii) The new price will be automatically calculated by subtracting the old attribute price and adding the new attribute price.
b) Text attributes now are implemented through a text box.
c) Fixed attribute pricing for the following scenarios:
i) One Time Charges Implemented
ii) Price Factor & Offset Implemented
iii) One Time Price Factor & Offset Implemented
iv) Attributes Qty Price Implemented
v) One Time Attributes Qty Price Implemented
vi) Price Per Word & Free Words Implemented
vii) Price Per Letter & Free Letters Implemented
viii) Specials and Sales Implemented for Attributes When Option is Selected for Attribute
d) Product one time charges are easily editable.
e) You can switch back and forth between the old advanced attribute editor and the easier one using a text-link.
i) The advanced attribute editor allows you to change the price and attribute option and value manually.
ii) The simple attribute editor allows you to choose from the attributes listed in your database.
iii) The advanced attribute editor will not update prices -- it leaves you to do this.
iv) The simple attribute editor updates prices automatically.
v) The simple attribute editor is the preferred method of altering attributes! The advanced is useful for advanced purposes.
f) Downloads are now implemented correctly and will change automatically when using the simple attribute editor.
g) All attribute data from TABLE_PRODUCTS_ATTRIBUTES now moves succesfully to TALBE_ORDERS_PRODUCTS_ATTRBIUTES when an attribute option is changed using the simple attribute editor.
2. Adding products has added a few new features.
a) You can choose whether or not new products use the special or sales price.
b) Text attributes now work with a text box.
c) Many new attribute options are implemented correctly when calculating the price for new products. See 1-c for more info.
d) Downloads are now implemented correctly.
e) All attribute data from TABLE_PRODUCTS_ATTRIBUTES now moves succesfully to TALBE_ORDERS_PRODUCTS_ATTRBIUTES when a new product is added with an attribute.
3. Coupon and group discounts now calculate correctly with taxes. To do so, the mod uses your average tax rate for all the products that were purchased.
4. Fixed problem with quantity discounts adding to total instead of subtracting.
5. Changed behavior so that clicking "details" on the order screen will give you the original edit orders page that Zen Cart has built in.
a) This allows you to choose which page you want to use. Click "details" for just the basics. Click "edit" to make some changes to an order.
6. Fixed problems with data in TABLE_ORDERS_PRODUCTS not updating includng products_price, products_tax, and final_price.
7. You can now enter a value for shipping taxes and this will calculate correctly. Zen Cart doesn't store this info in the database, so this must be changed every time when editing orders. A compromise, but better than nothing.
8. Added lines for edits to orders.php per popular demand on Zen Cart forums.
Enjoy!
when i click the add product link in the details page i am taken to the admin logon page. can anyone tell me why this is occuring?
That is very strange. Check the link for the "Add Product" link. It should be for: /edit_orders.php?oID=(ORDERNUMBERHERE)&action=add_product&step=1
Also, try pasting that link directly into the address bar of your browser. Does it still go to the login page?
Good to see the update released and I can see a huge amount of work was done. I could not see any reference to the Bug I mentioned regarding not updating orders table. Was this fix implemented in the current release?Quote:
Originally Posted by srturner47
Also will the new package straight upload over the existing package?
Thanks
Redmonds
Thanks redmond -- yes, this ended up being a big update. I didn't realize how many little details there were with attributes which could affect a product's price. I also didn't realize how many database entries that weren't mission critical were being ignored by the previous version.
Yes, I fixed that bug. And you are right, I forgot to add it to the changelog. Whoops!
And yes, just overwrite all the files from the previous version.
Sturner,
Thanks for the update.
I have applied and tested the totals update as per my requirements and it does not appear to have been corrected. That is the Order_total & Order_tax fields are not being updated in the Orders table.
In doing the update I uploaded all of the additional files but did not edit the existing files which I presumed where only adding links to the edit_orders.php page.
It also appears as though the Tax component is not recalculating properly. The old version would recalculate GST including GST in the shipping amount. However the new module calculates GST only on the products and not the shipping. This means that the GST shown is incorrect.
I would love some assistance in fixing both of these issues as I find myself using this component more and more. Again many thanks.
Regards
Redmonds
redmonds -- nice find! Yes, it appears I didn't completely fix the orders table updating. It will update just fine when using the "update" button, but adding a product won't update the orders table. I'll need to go back and fix this. Look for a new release with this fix in about 1 week (really a week this time -- I'm just going to fix this which should be pretty easy!). In the meantime, you can solve the problem by adding a product, and then clicking the "update" button without changing anything.
As for shipping tax, I don't quite understand how you were getting that behavior with the previous version. From my testing, and as reported by others on this thread, shipping taxes were never applied -- they were hard-coded as 0% in the source code. So, I added a box next to the shipping amount where you can enter a tax percentage. Unfortunately, Zen Cart doesn't store the tax rate for shipping on orders anywhere in the db, so you have to enter this tax rate every time you change an order.
If you charge a consistent tax rate to most or all of your customers, you can set the default tax rate in the source code. The default is currently set to 0%. Then, you just need to change the shipping tax rate when necessary. Look for the following line (I think its line 89) in the source code to do so:
Not the most elegant solution, but I thought it was better than the way it was implemented before, which was just to hardcode it as above without the option to change the shipping percentage in Zen Cart on an individual basis when needed. Unless Zen Cart starts recording the shipping tax rate for orders, this seems like the best way to handle this problem.Code:$AddShippingTax = "0.0"; // e.g. shipping tax of 17.5% is "17.5"
Version 2.0 - thanks for a great add-on. Works perfectly. As I have the need to refund the difference in postage (from small packet down to letter) or change the attributes of a product (from an out of stock colour to one that is available!) this is a fantastic and truly useful modification. Thanks again!
Just to confirm, this version of Order Editor works with 1.3.7? That hasn't changed, right? I'm going by the subject line.
Vicky :blink:
Did this fix, works "almost" great for me:blink:Quote:
Originally Posted by zc_tester
Same problem as lenny had with his euros.....
I use currency NOK as default. After updating prices, some values now turn up as $
What can I do to get my prices to show in NOK?
:smile:
New Version - 2.01 released. Click the link below to download. If you've already gone through checkout, just redownload the file, no need to go through checkout again.
v 2.01 11/16/2008 - Scott Turner
1. Fixed problem with TABLE_ORDERS not updating when adding a new product.
2. Fixed problem with wrong currencies when adding a new product.
TrvlFox - I would think it should work with 1.3.7 fine. I haven't done anything that I think would affect operation with 1.3.7, but I've never tested it with 1.3.7. Let me know if there are any problems with 1.3.7, but I doubt it.
lisbet - I just fixed some problems with the wrong currency when adding a product. See if the v2.01 does the trick.
redmonds - v2.01 fixes your problem once and for all! :) Thanks for being patient!
spinnywoman - glad you like it!
Just installed v2.1 and I get this error when trying to edit an order.
Fatal error: Call to undefined function zen_field_exists() in /edit_orders.php on line 84
What did I miss?
Thanks.
gsdcypher -- Sounds like admin/includes/functions/extra_functions/edit_orders.php didn't get copied to the right directory. Check to see if it is there.
weird... don't know how that didn't get uploaded. but you're right! it wasn't there.
next problem. when i try to edit an order:
step 1: selects the category correctly.
step 2: says "addproduct_text_select_product" and it won't allow any further selection
thanks.
It sounds like more files haven't ended up where they are supposed to go. This file is probably missing too if you have that problem:
admin/includes/languages/english/edit_orders.php
Please check carefully and make sure all files are where they are supposed to be.
I found the culprit. The latest build of FileZilla (3.1.5.1) does not upload files in subdirectories properly. So I downgraded my FileZilla to the previous build and wa-lah. It seems to be working... Sorry for the trouble. Thanks!
HI , I have your mod installed , but I think i got it from the downloads section , which i guess is a few versions behind.Quote:
Originally Posted by srturner47
Just a quick couple of questions before I upgrade .
1) is it easy to upgrade , just a case of copying files over ?
2) I have a problem where if I edit an order that has discounts ( qty discount ) the discount switches to positive instead of negative and the vat recalculates from the pre discounted figure. this means my order is then totally wrong. Does ver 2 fix this issue ?
Thanks for your time.
Mark
Right just installed the new version , it still sets the Qty discount mod to a positive integer. and even if you set this to positive , it still recalculates the VAT ( tax) on the full price before the discount has been applied.
If anyone has a workaround for this , that would be great.
Kind Regards
Mark .
Noticed my error in the above post,should beQuote:
it still sets the Qty discount mod to a positive integer. and even if you set this to positive ,
it still sets the Qty discount mod to a positive integer. and even if you set this to NEGATIVE
ANy ideas about this one ? Is there another support thread for this package that I should know about ?
Thanks
I've tried to include all the discounts I could think of, but I don't remember putting quantity discounts in there. It is a simple add, so I will update this later this weekend and it should work fine. Thanks for letting me know.
OK thanks for the reply , look forward to an updated version. - Appreciate your work.
Hi,
I'm a bit puzzled as I have the Ty Package Tracker installed and working for the last 6 months. I am now trying to get Edit Orders working (v2). I've made (and double checked) the changes in orders.php file and made sure all the files are uploaded correctly.
I also changed the code in tracker.php to reflect: define('FILENAME_EDIT', 'edit_orders.php');
I'm stumped on where to edit the order(s). When I go to Customers-> Orders I get a list of the orders but there is no "edit" button.
Any help would be most appreciated.
Thanks!
Art
www.tlracks.com
OK, after much searching I discovered this gem from "colosports" that solved my problem (I don't have Super Orders installed).
In Tracker mod, if you want the "Edit" button to link to Edit Orders, you must set "Is Super Orders Module Installed?" to true in Configuration->Ty Package Tracker. (This will display the Edit button in Tracker mod. )
Yikes, so simple and so hard to track down!
Art
Just wondering if you have had time to include this *Quantity Discounts* in your mod yet .Quote:
Originally Posted by srturner47
or what I need to edit to get it to work ?
Many thanks.
I just installed this, but can't make any changes to an order.
I go to customers/orders, then click on "details" and see the order, but am unable to change anything.
I'm using 1.3.8 of Zen Cart.
I made both changes to my orders.php file and just double checked them. So I'm not sure what I'm doing wrong. I do have the quantity discount module installed, if that makes a difference. But reading through the posts. others have that installed, but just have issues with the discount.
Also, I noticed when I went to change the orders.php file, the lines I had to change were 859 & 903. But i checked those lines, and everything was exactly as the read me file stated.
Should I see an "edit" button anywhere? I don't.
Um, yeah . . . the order I wanted to edit was really big, and I didn't scroll down to the bottom. I was looking for the "edit" button up at the top with the "details", "delete", "invoice" & "packing slip" . . .
So, I feel kinda stupid now!
Okay, I made my changes, added a minus sign to my quantity discount, clicked update and all was fine. But I went back so I could print the updated invoice, and it was the original, unupdated one. When I clicked on "update" to check it out, everything was as I had updated.
Do I need to do something differently so the invoice is updated?
I had changed the currency from euros to USD, and added shipping.
Edit: I wanted to change the currency to show USD, but I couldn't. I've changed my site to only show USD (after this order was placed), so I guess I don't need to worry about this.
Hi everyone,
I am using 1.3.8a and I have just installed this mod. I already have installed add customers from admin and ezpages meta tags modules.
Everytime I try to change anything in the admin panel customer orders I get this:-
Fatal error: Call to undefined function: zen_field_exists() in admin/edit_orders.php on line 84
Can anyone help me I thought I installed it all as per instructions .
Thanks
seanymph - Make sure the following file got copied to the right directory: admin/includes/functions/extra_functions/edit_orders.php
tracib - I'm a little confused about your problem. The invoice should pull the same data from the database as the edit and details page does. If it doesn't, clear your browsers cache. As for changing currencies after an order has been submitted, I don't think this is possible. (Feel free to correct me if I am wrong about this!!) But, all future orders should work just fine as long as they start in the right currency.
crazycucumber - Sorry! I've been awfully busy lately. I just took a look at the order_total modules, and quantity discount doesn't appear to be there. It seems that quantity discounts for attributes just affect the unit price directly -- it is not reflected as a discount in the order totals. So, I am pretty confused as to how you had this happen. Are you using some modification to Zen Cart that causes quantity discounts to show up in the order total lines instead of in the unit price for a product?
Hi all. This is labraxmauler from Spain. I'm new to the forum. First of all, let me apologize :blush: if this is the wrong place to post my question. Here it goes:
I recently downloaded and installed Edit Orders 2.1 from srturner47's website, but for some reason I can't manage to make it work. I can edit orders (add & modify products with their attributes) but once I make a single modification, my order total price resets to "0.00". There's no way I can change it once I start editing orders. Moreover, this "0.00" order total stays there when I go to Admin > Customers > Orders.
However, if I go to Admin > Reports > Customer-Order totals I can see the real order amount.
Any ideas about where the mistake is and how to solve it?
My Zen Cart version is the latest available, as stated by the "Check for updates" tool.
Thank you very much for your kind help.
Are you saying that the products still have their prices, but that the total is $0? That is very strange. Each time you update the order, it goes through each product and adds up your total. So, that is why your order total is most likely getting changed. What I don't understand is why you are getting $0. If your products have a price, your order total should have a price. The only reason you should have $0 for your total is that all your products are priced at $0.
Hi, srturner47! Thanks for your reply.
Regarding your question, my answer is 'yes' but anyway I'll try to explain it all a little better:
All products in my store have their prices and my customers make their purchases normally. After that, I can see all orders in 'Admin > Customers > Orders' with their different amounts. The problem comes when I use Edit Orders to add or remove products from an order: if I change something –even if it's only one product– the order total turns to '0.00'. I definitely can update the order and make changes, but product prices just don't add up to the order total.
Besides, every product in the order still keeps its own price – it's only the order total that turns to '0.00'. If I then go to 'Admin > Reports > Customer Order-Totals' I can see all orders with their correct total amount. Strange, isn't it?
Your sentence 'if your products have a price, your order total should have a price' makes a lot of sense, but I can't manage to find out why it doesn't work. Of course, I checked that the module is properly installed many times, but I haven't got much experience with PHP so there's nothing else I can do.
Thanks for your kind help!
labraxmauler - I still don't have any idea why that is happening. Go ahead and update to v2.02 and see if that fixes it.
Just released version 2.02. It fixes a couple of bugs. If you have already downloaded it using the link in my signature, just go ahead and log in and redownload it from your order history screen to get the new version. Special thanks to Numinix for finding the first bug in my changelog.
Changelog for V2.02
------------------------
1. Fixed problem with adding products when they are in the Top Category (i.e. they aren't in a category folder).
2. Fixed problem with adding products that are not on special being added at $0 when the apply special price box is checked.
Hi, guys. I'm so sorry to say this, but version 2.02 doesn't fix my problem. I downloaded and installed the module again, following the instructions in "read-me.txt" – no success. The 'Total 0.00' is still there as soon as I edit the order to add or delete a product.
I see there's a 'One Time Charges' window with '0.0000' inside under every product in the order. Is it correct? I don't know... I was just suggesting if this could be related to the problem.
Thank you very much for your help.
labraxmauler - One time charges is a feature of attributes. Don't worry about it; it shouldn't affect anything unless you change it from 0.
Don't know what to tell you, I have no idea why that is happening. If you'd need me to investigate further, I'd need to physically mess with your site by gaining access to your admin area and ftp. That is pretty invasive, and I certainly wouldn't let someone do that to my site, but I don't think I can help you otherwise. You could also hire a programmer you trust to check it out for you.
One last thing you might want to try -- create a product without attributes. Then, create an order with ONLY that product. Then, add that product again. If all works well, at least we know it has something to do with attributes. I did my best to test for all scenarios with attributes, but it is possible I missed something and it sounds like all your products have attributes as you mentioned that the One Time Charge is always listed below products.
Also, are you using 1.3.8? I haven't tested this with other versions (the title of this thread is very old!!!).
Just released 2.03. Special thanks to the person who emailed me identifying these bugs (no alias was given and I don't want to give real names out without permission, but thank you, thank you!). I would never have found these bugs myself! See the link in my signature to download. If you've already gone through checkout once, just login and redownload -- it should be the new version. Enjoy!
CHANGELOG for 2.03
------------------------
1. Fixed problems with updating text attributes when more than one text attribute is used in Zen Cart.
2. Fixed problems with adding a product with text attributes when more than one text attribute is used in Zen Cart.
3. Fixed problem with using apostrophes in a text attribute when adding a product.
Hi, guys!
srturner47, I'm sorry but unfortunately I'm not allowed to let you have a look at my admin area. However, I tried what you said about adding products without attributes –which I already had in my store– with the same disappointing result: the order total turns to '0.00'. According to what I can see in my Admin's server information, I'm working with Zen Cart 1.3.7.1 (database patch level: 1.3.8, fresh installation), PHP version 4.3.9, MySQL 4.1.22.
I'll download and install version 2.03 to see if it can fix the problem.
Thank you very much for your help.
Is it possible to get all the details (like shown in the first email) to get in the emails with a status update?