Discount Coupon Guide?!

ReCalculate Tax = None vs Standard

For Standard, it goes through the products list and for taxable products, computes the updated tax based on the discount provided by the coupon.
Finally, the tax line(s) are updated based on the new computation.

Quote:

---

Originally Posted by carlwhat

i hate coupons.

looking at this outstanding PR here:

https://github.com/zencart/zencart/pull/4324

i wanted the coupon amount to be included into the order info array.

this amount would then be used in any of your various ot tax modules to reduce said tax by that rate * the coupon amount.

i am not sure if that helps with your question, as i am not in a position to answer how it is 'supposed to work' nor what are the 'expected differences'.

best.

---

They're not my favorite, either.

Quote:

---

Originally Posted by swguy

ReCalculate Tax = None vs Standard

For Standard, it goes through the products list and for taxable products, computes the updated tax based on the discount provided by the coupon.
Finally, the tax line(s) are updated based on the new computation.

---

I got that, I'm looking for the processing difference between the "None" and "Standard" settings since "None" is how the client's got their coupons currently set up.

I'll note that the coupon calculations are off using the "Standard" setting as well when a site's products have multiple, additive tax rates that apply.

Here's another "How is it supposed to work?" question:

The base ot_coupon configuration contains a setting: Include shipping (true or false). Coupons can (since zc152) be defined to include free shipping and I'm wondering if this setting was created for pre-zc152 coupons.

Does anyone have a clue as to what processing is expected when "Include shipping" is set to true?

Include shipping just means the amount that a percent off coupon will apply to is grossed up by the shipping cost. (Without this, it's just the cost of all items which are valid for this coupon.)

Quote:

---

Originally Posted by swguy

Include shipping just means the amount that a percent off coupon will apply to is grossed up by the shipping cost. (Without this, it's just the cost of all items which are valid for this coupon.)

---

I saw that, but what's the setting's "business" purpose? You can create individual coupons that do/don't include shipping.

I think it's vestigial code. :)

Quote:

---

Originally Posted by swguy

I think it's vestigial code. :)

---

If that's the case, shouldn't it be removed (before it becomes cancerous)?

I think it still works and serves a purpose - you are right, there are now other ways of doing this but the old way also works.

Quote:

---

Originally Posted by swguy

I think it still works and serves a purpose - you are right, there are now other ways of doing this but the old way also works.

---

I'm questioning 'works' ...