https://github.com/lat9/one_page_che...ng_redirect.mdQuote:
Originally Posted by strelitzia
Printable View
https://github.com/lat9/one_page_che...ng_redirect.mdQuote:
Originally Posted by strelitzia
The report content is as follows:
'securityToken' => '132e9ad42270860df776214517249692', 'customers_host_address' => 'localhost', 'opc' => OnePageCheckout::__set_state(array( 'isGuestCheckoutEnabled' => true, 'registeredAccounts' => false, 'guestIsActive' => false, 'isEnabled' => true, 'tempAddressValues' => array ( 'ship' => array ( 'address_book_id' => '16922', 'customers_id' => '14057', 'zone_name' => NULL, 'gender' => '', 'company' => '', 'vat_number' => NULL, 'vat_validated' => '0', 'tva_intracom' => '', 'firstname' => 'Test', 'lastname' => 'User', 'street_address' => '1 The Street', 'suburb' => '', 'postcode' => 'ab1 2de', 'city' => 'The Town', 'state' => 'state', 'country' => '222', 'country_id' => '222', 'zone_id' => '0', 'error' => false, 'error_state_input' => false, 'country_has_zones' => false, 'validated' => true, 'selected_country' => '222', 'state_field_label' => '', 'show_pulldown_states' => true, ), 'bill' => array ( 'gender' => '', 'company' => '', 'firstname' => '', 'lastname' => '', 'street_address' => '', 'suburb' => '', 'city' => '', 'postcode' => '', 'state' => '', 'country' => 222, 'country_id' => 222, 'zone_id' => 0, 'zone_name' => '', 'address_book_id' => 0, 'selected_country' => 222, 'country_has_zones' => false, 'state_field_label' => '', 'show_pulldown_states' => true, 'error' => false, 'error_state_input' => false, 'validated' => false, ), ), 'guestCustomerInfo' => NULL, 'guestCustomerId' => 49930, 'tempBilltoAddressBookId' => 59537, 'tempSendtoAddressBookId' => 59538, 'dbStringType' => 'stringIgnoreNull', 'customerInfoOk' => NULL, 'billtoTempAddrOk' => NULL, 'sendtoTempAddrOk' => NULL, 'isVirtualOrder' => false, 'billtoAddressChangeable' => true, 'sendtoAddressChangeable' => true, 'observerAliases' => array ( 'NOTIFIY_ORDER_CART_SUBTOTAL_CALCULATE' => 'NOTIFY_ORDER_CART_SUBTOTAL_CALCULATE', ), 'label_params' => ' class="inputLabel"', )), 'cartID' => '61672', 'cart' => shoppingCart::__set_state(array( 'contents' => array ( 12224 => array ( 'qty' => '1', ), ), 'total' => 1.51, 'weight' => 0.01, 'cartID' => '61672', 'content_type' => 'physical', 'free_shipping_item' => 0, 'free_shipping_weight' => 0, 'free_shipping_price' => 0.0, 'download_count' => 0, 'total_before_discounts' => 1.512, 'display_debug_messages' => false, 'flag_duplicate_msgs_set' => false, 'flag_duplicate_quantity_msgs_set' => array ( ), 'observerAliases' => array ( 'NOTIFIY_ORDER_CART_SUBTOTAL_CALCULATE' => 'NOTIFY_ORDER_CART_SUBTOTAL_CALCULATE', ), )), 'check_valid_prod' => true, 'language' => 'english', 'languages_id' => 1, 'languages_code' => 'en', 'layoutType' => 'legacy', 'currency' => 'GBP', 'today_is' => '2022-04-27', 'updateExpirations' => true, 'antispam_fieldname' => 'MU19IqmzZl', 'session_counter' => true, 'customers_ip_address' => '::1', 'eu_min_order_login' => 0, 'customer_id' => '14057', 'customers_email_address' => '[email protected]', 'customer_default_address_id' => '16922', 'customers_authorization' => '0', 'customer_first_name' => 'Test', 'customer_last_name' => 'User', 'customer_country_id' => '222', 'customer_zone_id' => '0', 'valid_to_checkout' => true, 'cart_errors' => '', 'eu_minimum_order' => '0', 'billto' => '16922', 'sendto' => '16922', 'shipping_weight' => 3.01, 'cot_gv' => '0.00', 'shipping_tax_amount' => 0.7199999999999999, 'discount' => 0, 'jsweb_sagepay' => '1', 'shipping' => array ( 'id' => 'jswshipper_10-0-0', 'title' => 'Shipping (Royal Mail 2nd Class inc. Handling & Packaging NON-TRACKED (£3.60) (0.01Lbs))', 'cost' => 3.6, ), 'jswshipper_tax_class' => '2', 'shipping_tax_description' => 'UK VAT', 'order_current_total' => '£6.13', )
A screenshot's better, since that's got the styling that identifies the differences.Quote:
Originally Posted by strelitzia
Assuming the styling is an underline, then it's highlighted 'shipping_tax_description' => 'UK VAT'Quote:
Originally Posted by lat9
What are the before and after values?Quote:
Originally Posted by strelitzia
That's what makes no sense. It's 'UK VAT' at all times.Quote:
Originally Posted by lat9
The content of the div doesn't change from Attachment 19976
I'll note that the 'displayed' version has a trailing colon (:).Quote:
Originally Posted by strelitzia
It does, but is the same both before and after the reload.Quote:
Originally Posted by lat9
And yet checking the OPC debug log, all instances of 'shipping_tax_description' are displayed as 'UK VAT'. Is OPC stripping the colon out when generating the report?
If both instances are either with, or without a colon then there should be no difference that would lead to a hash change.
Why are line titles even being included in a check to see if monetary values have changed?
Quote:
Originally Posted by strelitzia
OPC is not stripping anything ... but one of your order-totals might be. OPC goes off a hash of the session, checking that nothing's changed since the customer indicated that the order is to be placed.Quote:
Originally Posted by lat9
As I'd requested before, a screenshot of the admin tool's difference display would help enormously.
I've just submitted v2.4.0 of One-Page Checkout for the Zen Cart moderators' review; I'll post back here when it's available for download.
Note: This version drops support for Zen Cart versions prior to 1.5.7a. If your site is using an older Zen Cart version, please continue to use OPC v2.3.12.
This release contains changes associated with the following GitHub issues:
#304: Drop support for Zen Cart versions prior to zc157a.
#312: Additional AJAX messages to distinguish various timeout scenarios.
#313: Improve performance on admin's orders' listing display.
#315: Correct address handling when "Enable Shipping=Billing" is set to 'false'.
#316: Render OPC overlay when an address (either billing or shipping) is changed via dropdown of existing addresses.
#317: Enable interoperation with the square_webPay payment method.
#318: Add a breadcrumb on the order_status page.
#319: Use zen_cfg_read_only for OPC's "Version" value.
#320: Correct PHP Fatal error received when an issue requiring a customer message is detected by OPC's observer.
#321: Add zone_code to data supplied by the NOTIFY_OPC_INIT_ADDRESS_FROM_DB notification.
#322: Correct number of parameters supplied to zen_prepare_country_zones_pull_down.
#324: (Partial) Additional information gathered for "Invalid request, tempAddressValues not set." error log.