Printable View
Please see issue #328 and #331
With just #328's corrections, our sites were getting the OPC circular warning AND the line 234 error for Square WebPay. Making the change in #331 stopped both the OPC logs and the Square logs.
No glitches for two days now.
that is not unique to square_webPay. square_webPay merely exposed that bug which was already there.Quote:
Originally Posted by dbltoe
And, since you said you didn't want to be bothered, it's not on the WebPay thread.Quote:
just so we are clear
- unless i ask for log files, please do not send them.
BUT... Anyone using OPC with WebPay needs to be aware of what is needed for them to operate correctly.
Or, do you disagree?
Right, ok so now I am even more confused....but don't take offence guys :DQuote:
Originally Posted by carlwhat
Where is the version of OPC that actually works please? And if there is an update to 2.4.0 somewhere, it obviously needs resubmitting as I won't be the only person having issues. :smile:
man, this is like an old school flame war from usenet.Quote:
Originally Posted by dbltoe
i was responding to nick1973 problem that he needed to apply my changes to the javascript. and was responding to that specific issue.
but hey if you want to continue whatever it is that you think you are doing, feel free.
i'm sure i can find other situations worthy of my coding skills.
best.
Is it like pulling teeth carlwhat? :DQuote:
Originally Posted by carlwhat
Right, so can we get this down in simple terms please.
So this is the post that I used to make changes to jquery.checkout_one.js
https://www.zen-cart.com/showthread....13#post1387913
these two changes appear to make the squarepay module work, although I think there might have been issues in opera and firefox with it hanging on the checkout page before the payment is taken for some reason. It's just that when it does that, the animated gif does not immediately appear. The screen just fades and takes a while to pull the gif up. It may also depend on internet connections.
My other issue is that for some reason on two sites, the Save Changes Button does not work.
Those changes were made before even 2.4.0.
The WebPay from the plugins and the files from lat9's github (including the pull request for #331) are the files needed to work with 1.5.6c=> and PHP 7.3.3=>.
Ok well I have all that installed. I have successfully installed one page checkout and Square Web Pay on another site this evening. So I need to work out what is different on the other two sites that I mentioned are having a problem. They are all 1.5.7d running the latest of OPC with the changes and Square Web Pay. And on PHP 7.4.Quote:
Originally Posted by dbltoe
I am getting this issue though in the logs.
[18-May-2022 20:41:10 Europe/London] Request URI: /index.php?main_page=checkout_one, IP address: 86.17.120.117
#1 var_export() called at [/home/MYSITE/public_html/includes/classes/OnePageCheckout.php:567]
#2 OnePageCheckout->startGuestOnePageCheckout() called at [/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php:41]
#3 require(/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php) called at [/home/MYSITE/public_html/index.php:35]
--> PHP Warning: var_export does not handle circular references in /home/MYSITE/public_html/includes/classes/OnePageCheckout.php on line 567.
[18-May-2022 20:41:10 Europe/London] Request URI: /index.php?main_page=checkout_one, IP address: 86.17.120.117
#1 var_export() called at [/home/MYSITE/public_html/includes/classes/OnePageCheckout.php:567]
#2 OnePageCheckout->startGuestOnePageCheckout() called at [/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php:41]
#3 require(/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php) called at [/home/MYSITE/public_html/index.php:35]
--> PHP Warning: var_export does not handle circular references in /home/MYSITE/public_html/includes/classes/OnePageCheckout.php on line 567.
[18-May-2022 20:41:10 Europe/London] Request URI: /index.php?main_page=checkout_one, IP address: 86.17.120.117
#1 var_export() called at [/home/MYSITE/public_html/includes/classes/OnePageCheckout.php:744]
#2 OnePageCheckout->updateOrderAddresses() called at [/home/MYSITE/public_html/includes/classes/observers/class.checkout_one_observer.php:422]
#3 checkout_one_observer->update() called at [/home/MYSITE/public_html/includes/classes/class.base.php:118]
#4 base->notify() called at [/home/MYSITE/public_html/includes/classes/order.php:425]
#5 order->cart() called at [/home/MYSITE/public_html/includes/classes/order.php:35]
#6 order->__construct() called at [/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php:158]
#7 require(/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php) called at [/home/MYSITE/public_html/index.php:35]
--> PHP Warning: var_export does not handle circular references in /home/MYSITE/public_html/includes/classes/OnePageCheckout.php on line 744.
[18-May-2022 20:41:10 Europe/London] Request URI: /index.php?main_page=checkout_one, IP address: 86.17.120.117
#1 var_export() called at [/home/MYSITE/public_html/includes/classes/OnePageCheckout.php:744]
#2 OnePageCheckout->updateOrderAddresses() called at [/home/MYSITE/public_html/includes/classes/observers/class.checkout_one_observer.php:422]
#3 checkout_one_observer->update() called at [/home/MYSITE/public_html/includes/classes/class.base.php:118]
#4 base->notify() called at [/home/MYSITE/public_html/includes/classes/order.php:425]
#5 order->cart() called at [/home/MYSITE/public_html/includes/classes/order.php:35]
#6 order->__construct() called at [/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php:158]
#7 require(/home/MYSITE/public_html/includes/modules/pages/checkout_one/header_php.php) called at [/home/MYSITE/public_html/index.php:35]
--> PHP Warning: var_export does not handle circular references in /home/MYSITE/public_html/includes/classes/OnePageCheckout.php on line 744.
If you are getting those issues, you are not using the files from github. Go to https://github.com/lat9/one_page_checkout, click on the Green CODE button and download the zip.
There are some changes in the admin files that need to be made for WebPay to work with some shipping modules AND some changes in files inside the includes folder to fix the var_export problem.
The errors you reported were fixed with the fix for #328 and ARE included in the download zip file.
You can fix the third var_export mentioned in the Pull Request either before or after you upload all the files. If you don't do the fix, you will get yet another var_export error for line 784 of includes/cllasses/observers/class.checkout_one_observer.php.
You can just overrite the existing files on your site and it wil work fine.
Right well this is obviously where I am getting confused and other people will get confused. So obviously this needs putting in 'Plugins' asap really as not everyone is aware they will exist there. Now I know which ones I should be using, I will go and get them though.Quote:
Originally Posted by dbltoe