OLD Super Orders 2.0 (See v3.0 thread instead)

Quote:

---

Originally Posted by BlindSide

@wickedklown et. al.
The problem you experienced with the tags being displayed improperly in status update comments is due to the comments not being properly scrubbed before inserting them into the DB. "Scrubbing" is the act of prepping the data for DB insert. The stock zen uses two functions -- zen_db_input() and zen_db_prepare_input() -- to complete this task. I combined the two and went a few steps further with the zen_db_scrub_in() function.

The important part for this problem is that we also do a conversion from <br> tags to newline returns (aka the br2nl() function). This process is then reversed when the status is outputted on the page (nl2br(), new lines become <br> tags again). Since the code isn't doing it on the way in, the output gets kinda screwy.

I know that it was there at some point, but it was probably edited/moved/removed and never re-added in the course of writing the file. My apologies. Here's how to fix it. Find this line near the top of super_batch_status.php...

Code:

---

$notify_comments = $_POST['notify_comments'];

---

Adjust the line to read as follows...

Code:

---

$notify_comments = zen_db_scrub_in($_POST['notify_comments'], true);

---

That will prevent the problem from occuring further. To correct already affected comments, go to the Orders Detail page for the affected order and click "edit status history" beneath the status history table. Edit the comments as necessary and click "Submit" (this file does perform the scrubbing correctly)

For those of you who do not use Admin > Customers > Batch Status Update, I still strongly recommend you perform the above fix, as not scrubbing the input leaves you vulnerable to SQL injections. Fortunately, since it's an admin file, the problem is only on the admin side, so access is extremely limited. Still, always better to be safe than sorry.

---

This problem didnt have to do with batch status. it was just when doing order status via super orders. I rarly use batch status update, or any of those batch's.

should i still preform this fix, and will it fix my current problem?

i preformed the edit as asked, however it didnt fix the problem. as i said, i dont use batch stuff, i only use super orders. So it has to be inside super orders somewhere. its still doing the same exact thing. it does bring it down to the next line, but it shows the <br/> tags at the end of each line. and under admin you see rn.

can you please take a look at SUPER_ORDERS.php and tell me what it could be that is going wrong.

im sorry that you keep thinking that my problem lies in the batch status, and your tring so hard to make it work. but i dont use that system *yet*

also, do you have a paypal account for donations for your hard work at this problem? id be glade to buy you a "cold one" for your troubles...

Dear Blindside,

I think there is a minor bug in the Super Order 2.0 Rev 45.

When I ran out of all options and kept getting following error message:

1064 You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'True', 'False'), ')' at line 1 in:
[INSERT INTO zen_configuration VALUES (NULL, 'Enable Purchase Order Module', 'MODULE_PAYMENT_PURCHASE_ORDER_STATUS', 'True', 'Do you want to accept Purchase Order payments?', 6, 1, now(), now(), NULL, 'zen_cfg_select_option(array('True', 'False'), ');]
If you were entering information, press the BACK button in your browser and re-check the information you had entered to be sure you left no blank fields.

I went back to the download section and downloaded the older contribs on this mod. Then I used BeyondCompare and found out that this line is what caused all my troubles:

INSERT INTO configuration VALUES (NULL, 'Enable Purchase Order Module', 'MODULE_PAYMENT_PURCHASE_ORDER_STATUS', 'True', 'Do you want to accept Purchase Order payments?', 6, 1, now(), now(), NULL, 'zen_cfg_select_option(array(\'True\', \'False\'), ');

I changed it to the following based on the older versions:

INSERT INTO configuration VALUES (NULL, 'Enable Purchase Order Module', 'MODULE_PAYMENT_PURCHASE_ORDER_STATUS', 'True', 'Do you want to accept Purchase Order payments?', 6, 1, now(), now(), NULL, 'zen_cfg_select_option(array(''True'', ''False''), ');

and it solved my problem with installation.

I don't know how other people got around this line. Maybe their PHP and MySql versions are different from mine. Here is my server info:

MySQL 4.0.27-standard
Server OS: Linux 2.6.9999-MIDPHAZED-410a66d10418e44a615e653ff4a8476e
HTTP Server: Apache/1.3.34 (Unix) mod_auth_passthrough/1.8 mod_log_bytes/1.2 mod_bwlimited/1.4 PHP/4.3.10 FrontPage/5.0.2.2635 mod_ssl/2.8.25 OpenSSL/0.9.7a
PHP Version: 4.3.10 (Zend: 1.3.0)
Database Host: localhost

Anyway, this Super Order is a great module and I finally got it working in my cart.

Thanks,

Frank

Blindside: see attached picture. What did I do wrong?

How do I test it to make sure everything will run fine. Thanks so much!

Blindside: It's working. I forgot to install one file. Slap me on the head! Thanks for such a great contribution and all your work. I have not fully tested it but it seems to be okay at the moment. Thanks again :)

New problem??

I have been using super orders for a while now but am just getting a chance to try the batch status update feature to notify multiple customers who purchased a certain item.

I have used it successfully many times to update things for my info (pending to shipped, for example) and I have used the details pages to update the status AND notify the customer. Worked like a charm... :D

The problem is coming when I try to use the batch update status page to send an email notification to mutiple customers. It APPEARS to work - I click the notify customer checkbox, paste the email into the box, and update -- status update notification works.

*but* the email never goes out - :( - it *is* noted on the customer details area that the customer was _not_ notified (even though I checked for it TO notify them). Again, if I use their details page it works fine - it is only from the batch page that the problem exists.
what have I missed??? :huh:

OK, cannot seem to edit my own post... LOL. I apparently was not using correct search terms to sind what I needed -the first five times around - sorry!

I did find where this was addressed a little while back. I tried the edits to super_batch_edits which were posted.

Quote:

---

>>Note the lack of curly braces { }. I want you to add those braces so it looks like the following...

Code:
if ($notify == 1) {
email_latest_status($oID);
}Then, as a precautionary measure, lets make sure that $notify is actually being set properly. Go back to the top of the page, and find this line...

Code:
$notify = $_POST['notify'];Let's define this so that it's set as a variable type int, like this...

Code:
$notify = (int)$_POST['notify'];>>

---

no luck.
You mention the debug. I am not qualified... LOL

red, some other posters mentioned this issue, and as you saw I investigated, but never heard back from them either way. I am hoping that they found the source of their issue and simply didn't post back here. I'll see if I can track them down.

Thanks! I really appreciate the mod, and if there is any kind of input you need from me to track down the problem let me know. I assume this does not happen to you on your install? :D

And I promise to post the fix here if nobody else has by then... :-)

Quote:

---

Originally Posted by BlindSide

red, some other posters mentioned this issue, and as you saw I investigated, but never heard back from them either way. I am hoping that they found the source of their issue and simply didn't post back here. I'll see if I can track them down.

---

Sorry I thought i posted last night , but now cant see my post .

All it said was :

Created brand new 1.3.5 version of Zen on my
PHP 4.4.4. server with
4.1.21 MySQL

installed the Superorders Mod , and still didn't work , made the adjustmnents to the code in the last few posts from BS , still no Joy .

Hope this info is of use to someone !

Cheers